admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
18,114 Commits 15 Branches 471 Tags
Commit Graph

2890 Commits

Author SHA1 Message Date
Markus Reiter
42d90f8bd9 Use same logic for installer script: and uninstall script:. 2019-03-03 06:21:11 +01:00
Shaun Jackman
82da3b43cc audit: Keg-only :provided_by_macos dep okay on Linux 
Disable this brew audit error on Linux:
* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
 2019-03-02 13:29:49 -08:00
Mike McQuaid
17f3ee1957
Improve Bundler cleanup 
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
 2019-02-27 14:02:46 +00:00
Mike McQuaid
d1f755959a
Merge pull request #5805 from BenMusch/handle-conflicts 
Fix bug in CLI arg/env var prioritization + corresponding tests
 2019-02-26 07:55:19 +00:00
Ben Muschol
4c6ca1c5d9 Fix stub orders, :env_var reference 2019-02-25 15:18:14 -05:00
Mike McQuaid
fcfabfb3c6
dev-cmd/pull_spec: require Homebrew/homebrew-core for subtest. 2019-02-25 17:21:09 +00:00
Mike McQuaid
921d4aad77
Unify test/vendor Gemfiles and bundler configuration. 2019-02-21 16:34:19 +00:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
dependabot[bot]
eca4af2031
Bump rubocop from 0.64.0 to 0.65.0 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.64.0 to 0.65.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.64.0...v0.65.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-21 12:55:49 +00:00
Shaun Jackman
3bcffeae15 tests: Disable tests that require being non-root 
Set the environment variable USER=root which is required by
brew tests --only=utils/user

Fix these tests:
rspec ./test/diagnostic_checks_spec.rb:26 # Homebrew::Diagnostic::Checks #check_access_directories
rspec ./test/pathname_spec.rb:120 # Pathname#ensure_writable makes a file writable and restores permissions
rspec ./test/utils/user_spec.rb:22 # User#gui? when the current user is in a console session gui? should equal true
rspec ./test/utils/user_spec.rb:6 # User should eq nil
 2019-02-16 12:55:09 -08:00
Mike McQuaid
f3716fe2d8
Merge pull request #5738 from BenMusch/handle-conflicts 
Prioritize CLI arguments over env vars when they conflict
 2019-02-16 19:15:05 +00:00
Ben Muschol
c7831a457d Get brew style to pass 2019-02-16 07:56:12 -05:00
Ben Muschol
c745738c55 Make from: required, fix flaky test 2019-02-15 14:15:34 -05:00
Markus Reiter
78d4373543 Simplify DEFAULT_DIRS. 2019-02-15 10:09:14 +01:00
Markus Reiter
707cb33346 Add tests for Cask::Config. 2019-02-15 10:09:14 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Markus Reiter
fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter
1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Ben Muschol
f8d84249aa Prioritize CLI arguments over env vars when they conflict 2019-02-15 00:52:30 -05:00
Mike McQuaid
3060125c45
rubocop: autofix problems. 2019-02-11 09:50:09 +00:00
Mike McQuaid
a30d0c7961
Merge remote-tracking branch 'origin/dependabot/bundler/Library/Homebrew/vendor/rubocop-0.64.0' into dependabot/bundler/Library/Homebrew/test/rubocop-0.64.0 2019-02-11 09:44:40 +00:00
Markus Reiter
6ae600b5e6
Merge pull request #5689 from Homebrew/dependabot/bundler/Library/Homebrew/test/parallel_tests-2.28.0 
Bump parallel_tests from 2.27.1 to 2.28.0 in /Library/Homebrew/test
 2019-02-11 03:28:11 +01:00
dependabot[bot]
f1c217b32b
Bump rubocop from 0.63.1 to 0.64.0 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.63.1 to 0.64.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.63.1...v0.64.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-10 13:56:34 +00:00
Markus Reiter
0fcc62db31 Run uninstall rmdir: after uninstalling artifacts. 2019-02-08 01:09:48 +01:00
dependabot[bot]
1304c329d0
Bump parallel_tests from 2.27.1 to 2.28.0 in /Library/Homebrew/test 
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.27.1 to 2.28.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.27.1...v2.28.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-07 19:27:02 +00:00
Danny Weinberg
b0124c4fb0 Cask handle already downloaded file 
The current logic for curl_download tries to restart any existing
partial download, but this fails for some servers when the file is
already fully downloaded, returning a status code 416. This updates the
function to check for the file being already downloaded and if so bails
early.

The following command used to fail when run more than once but now works
as expected:
```
brew cask info https://raw.githubusercontent.com/homebrew/homebrew-cask/master/Casks/docker.rb
```
 2019-02-01 14:57:50 -08:00
Mike McQuaid
fd4e45c688
lines_spec: fix a typo. 2019-01-30 21:59:55 +00:00
Mike McQuaid
4ace1af297
help: improve command --help output. 2019-01-30 21:39:29 +00:00
Mike McQuaid
9eabcdad7d
Make install/reinstall/upgrade options more consistent. 2019-01-29 19:25:59 +00:00
Mike McQuaid
618f75c071
Merge pull request #5619 from GauthamGoli/install-args 
install: Use CLI::Parser to parse args
 2019-01-29 14:11:22 +00:00
Mike McQuaid
49d3849507
cmd/install_spec: test new invalid option behaviour. 2019-01-29 10:48:39 +00:00
Mike McQuaid
24eb8e8e54
Remove (now) unused invalid_option_names. 
This is handled by `OptionParser` now instead in `cmd/install`.
 2019-01-29 08:31:45 +00:00
Markus Reiter
a198b0ef43
Merge pull request #5628 from reitermarkus/conflicts-with 
Refactor `ConflictsWith` to be a `DelegateClass(Hash)`.
 2019-01-28 22:31:08 +01:00
Mike McQuaid
28fa8a7c97
version: add CPU tests. 
Add a new API inspired by discussion in
https://github.com/Homebrew/homebrew-core/pull/36435 to query if a given
CPU option is supported by a version of macOS.
 2019-01-28 19:31:21 +00:00
Markus Reiter
d22c2eca9e Refactor ConflictsWith to be a DelegateClass(Hash). 2019-01-27 21:48:12 +01:00
Mike McQuaid
1aa8ad09e2
Deprecate macOS versions below Mavericks 
And remove all dead/unneeded code.
 2019-01-27 12:27:47 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup 
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
 2019-01-23 21:57:40 +00:00
Mike McQuaid
db7fd7b7a2
Tweak audits 
- Ensure that new formulae problems aren't duplicated
- Now that homebrew/core will imminently not have options adjust the
  various audits so they make more sense (and exclude taps)
- Exclude taps from more preferential audits
 2019-01-22 13:30:24 +00:00
Mike McQuaid
5fd2b24aff
Merge pull request #5579 from Homebrew/dependabot/bundler/Library/Homebrew/test/rubocop-0.63.1 
Bump rubocop from 0.63.0 to 0.63.1 in /Library/Homebrew/test
 2019-01-22 09:37:13 +00:00
dependabot[bot]
21036e1d58
Bump rubocop from 0.63.0 to 0.63.1 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.63.0 to 0.63.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.63.0...v0.63.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-22 03:04:15 +00:00
Mike McQuaid
79f3ff0a4e
cleanup: also consider ctime on prunes. 
If this is an old tarball then we may end up removing it otherwise if
we've respected the `mtime` from the server on download.
 2019-01-21 21:35:24 +00:00
Mike McQuaid
f82f3ffe7c
Merge pull request #5571 from MikeMcQuaid/supported-cleanup 
Warn more on unsupported configurations
 2019-01-21 15:38:49 +00:00
Mike McQuaid
234e4aec96
Improve use of default_prefix? in tests. 2019-01-21 14:33:56 +00:00
Mike McQuaid
5c7fbaf259
Update RuboCop RSpec rules 
Create a new, seperate RuboCop file that uses our RSpec rule
configuration if a specified tap has a `spec` directory.

Also, while we're here, fix up the various rules so that we don't have
any outdated TODOs, disable some rules for good and fix `brew style`
for Homebrew/bundle.
 2019-01-21 13:39:11 +00:00
Mike McQuaid
c3a46bc570
os/mac/diagnostic: remove some old/unneeded checks. 2019-01-21 12:40:12 +00:00
Gautham Goli
70c5b6f804
Merge pull request #5560 from GauthamGoli/cat-args 
cat: Use CLI::Parser to parse args
 2019-01-20 19:50:56 +05:30
Gautham Goli
9d287483b7
cat: Use CLI::Parser to parse args 2019-01-19 19:36:55 +05:30
dependabot[bot]
ae9d4d3465
Bump term-ansicolor from 1.7.0 to 1.7.1 in /Library/Homebrew/test 
Bumps [term-ansicolor](https://github.com/flori/term-ansicolor) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/flori/term-ansicolor/releases)
- [Changelog](https://github.com/flori/term-ansicolor/blob/master/CHANGES)
- [Commits](https://github.com/flori/term-ansicolor/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-18 09:08:20 +00:00
dependabot[bot]
c57c20af08
Bump rubocop from 0.61.1 to 0.63.0 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.61.1 to 0.63.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.61.1...v0.63.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-17 09:47:33 +00:00