10270 Commits

Author SHA1 Message Date
Markus Reiter
e6bce5ec27 Merge pull request #1342 from reitermarkus/fixtures
Move cask's fixtures to `test/fixtures`.
2016-10-24 22:09:45 +02:00
Markus Reiter
b28b21fd7f Don’t use bare percent literals. 2016-10-24 17:27:20 +02:00
Josh Hagins
3f3fa4d0f7 Merge pull request #1334 from jawshooah/cask/fix-tap-regex
hbc/qualified_token: simplify token parsing
2016-10-24 10:38:02 -04:00
Mike McQuaid
b39f87e710 audit: check for alpha/beta/rc usage in URLs.
Stable URLs should not use unstable versions.
2016-10-24 14:54:28 +01:00
Markus Reiter
31ec04704a Move cask fixtures to test/fixtures/cask. 2016-10-24 15:52:41 +02:00
Josh Hagins
b2870c2480 hbc/qualified_token: use regex captures instead of String#split 2016-10-24 09:50:33 -04:00
Mike McQuaid
762b76e437 audit: check the version does not decrease.
This will prevent `brew upgrade` from working correctly.
2016-10-24 10:21:07 +01:00
Josh Hagins
4ed51d8240 hbc/auditor: refactor and fix bug
Use instance methods to DRY things up, and fix a bug discovered in
caskroom/homebrew-cask#26067 where Casks with language blocks would
always fail audit.
2016-10-24 04:27:21 -04:00
Josh Hagins
b481ed73a0 Merge pull request #1252 from niw/fix_cask_command_changes_entire_directory_ownership
FIX: cask changes /usr/local ownership recursively
2016-10-24 01:21:08 -04:00
Josh Hagins
606a762344 Merge pull request #1248 from Git-Jiro/add_reinstall_cmd_to_cask
add cask reinstall command
2016-10-24 01:11:48 -04:00
Martin Schimandl
0b8af5771f Remove duplicate description of <token> 2016-10-24 05:30:49 +02:00
Josh Hagins
c7e6613f7b tap_constants: rename HOMEBREW_CASK_TAP_FORMULA_REGEX
New name is HOMEBREW_CASK_TAP_CASK_REGEX
2016-10-23 21:48:11 -04:00
Josh Hagins
44f1354d63 hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants
2016-10-23 21:48:11 -04:00
Josh Hagins
512a0c950e Merge pull request #1355 from reitermarkus/fix-depends-on-test
Fix locally failing `depends_on` test.
2016-10-23 21:42:48 -04:00
Josh Hagins
5d1412aba1 Merge pull request #1357 from reitermarkus/refactor-accessibility-test
Refactor accessibility test.
2016-10-23 21:41:35 -04:00
Josh Hagins
fcaa042736 Merge pull request #1358 from reitermarkus/refactor-audit-test
Refactor Audit test.
2016-10-23 21:40:54 -04:00
Josh Hagins
b59eade6c5 Merge pull request #1359 from reitermarkus/refactor-dsl-test
Refactor DSL test.
2016-10-23 21:40:06 -04:00
Josh Hagins
49155cce4d Merge pull request #1360 from reitermarkus/refactor-installer-test
Refactor Installer test.
2016-10-23 21:38:39 -04:00
Markus Reiter
4a9b48e9a6 Refactor Installer test. 2016-10-24 00:13:48 +02:00
Markus Reiter
7395c049dd Refactor Audit test. 2016-10-23 23:52:42 +02:00
Markus Reiter
bbc601c3fd Refactor DSL test. 2016-10-23 23:52:14 +02:00
Markus Reiter
b8ec62bf25 Refactor accessibility test. 2016-10-23 23:45:10 +02:00
Markus Reiter
1bcaad6f3f Update Gemfile dependencies. 2016-10-23 23:22:39 +02:00
Markus Reiter
c7a535de22 Refactor Hbc::UrlChecker test. 2016-10-23 22:58:01 +02:00
Markus Reiter
7cae29d3d7 Fix locally failing depends_on test. 2016-10-23 21:22:38 +02:00
Martin Schimandl
95d4a25891 Fix linting errors 2016-10-23 20:39:53 +02:00
Martin Schimandl
32dc78835d Add documentation for cask reinstall command 2016-10-23 20:20:08 +02:00
Markus Reiter
ddcab26a35 Use proper path to caskroom/cask tap in test_helper. 2016-10-23 19:07:45 +02:00
Eitot
0b176f9cc8 Add dictionary artifact 2016-10-23 17:43:06 +02:00
Markus Reiter
cb8af6d751 Fix failing test caused by repo_info. 2016-10-23 17:07:29 +02:00
Markus Reiter
8d15bddedb Auto-correct block delimiters. 2016-10-23 14:44:14 +02:00
Markus Reiter
827b48912a Avoid empty rescue. 2016-10-23 14:32:46 +02:00
Markus Reiter
8c488de3f6 Remove unnecessary string interpolation. 2016-10-23 14:32:34 +02:00
Markus Reiter
15b858ccc4 Use double quotes. 2016-10-23 14:32:27 +02:00
Markus Reiter
783dbcc937 Use short-style lambdas. 2016-10-23 14:32:15 +02:00
Markus Reiter
ceec5a82c1 Use guard clauses. 2016-10-23 14:32:04 +02:00
Markus Reiter
9f513cc60c Remove redundant selfs. 2016-10-23 14:32:04 +02:00
Markus Reiter
ad8ae33c1f Fix spacing and indentation. 2016-10-23 14:32:04 +02:00
Markus Reiter
2b7e6c1dcb Don’t use %i literal. 2016-10-23 14:32:04 +02:00
Markus Reiter
ae7b944238 Align end with beginning of line where if/unless is. 2016-10-23 14:32:03 +02:00
Markus Reiter
8e9eae695a Use () as delimiters for %Q and %q literals. 2016-10-23 14:32:03 +02:00
Markus Reiter
1a0f8b8a02 Use slash-delimited regular expressions. 2016-10-23 14:32:03 +02:00
Markus Reiter
40b7e36746 Use 0-only prefix for octal numbers. 2016-10-23 14:13:16 +02:00
Markus Reiter
13e3272e37 Remove Cask’s RuboCop configuration. 2016-10-23 14:13:16 +02:00
Markus Reiter
364adff35c Bring spec_helper in line with test_helper. 2016-10-23 14:13:16 +02:00
Markus Reiter
e51accecfd Remove test_cask, fake_fetcher, and fake_response_for methods. 2016-10-23 14:13:16 +02:00
Markus Reiter
622cac47ae Use test/lib/config for tests. 2016-10-23 14:13:16 +02:00
Martin Schimandl
31fb996800 Remove unncessary semicolon 2016-10-23 09:57:28 +02:00
Josh Hagins
1d8e59b31f dev-cmd/man: use SOURCE_PATH instead of HOMEBREW_LIBRARY
Don't Repeat Yourself.
2016-10-23 01:22:56 -04:00
Mike McQuaid
6c4042f593 More Rubocop tweaks.
- Don't enforce hash rockets on external commands.
- Enabled accidentally disabled ParenthesesAsGroupedExpression.
2016-10-22 15:55:13 +01:00