libgit2 clients struggle at parsing these otherwise because of how we
set up our ignore rules.
And remove now unneeded formula ignore rule.
ClosesHomebrew/homebrew#41593.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Dependency is another similar, related class and it's super confusing
to have some Requirements that are named *Dependency.
ClosesHomebrew/homebrew#38891.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
The original formula (disco) has been moved to use 0.5.0 style version
string. So actually no one is using such style.
Stop supporting such style, so it wouldn't be ambiguous with revision
part in `Formula#pkg_version`.
ClosesHomebrew/homebrew#38750.
Signed-off-by: Xu Cheng <xucheng@me.com>
Fixes the bottle regex problem seen in
https://github.com/Homebrew/homebrew-versions/pull/678.
I don’t know whether it’s a good regex, or an awful regex, but it works
and passes `brew tests` and a bottled install. Open to improvements if
anyone has them.
ClosesHomebrew/homebrew#38333.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Comparing PkgVersion and Version objects can produce nonsensical
results. For example, equality is not symmetric:
irb(main):002:0> PkgVersion.new("1.0", 0) == Version.new("1.0")
=> false
irb(main):003:0> Version.new("1.0") == PkgVersion.new("1.0", 0)
=> true
Rather than attempt to deal with subclass-superclass equality, let's use
composition and punt on the problem altogether.
test.pdf wasn't a valid PDF file:
>$ mutool info test.pdf
>test.pdf:
>error: cannot recognize xref format
>error: cannot read xref (ofs=406)
>error: cannot read xref at offset 406
>warning: trying to repair broken xref
Process it with `mutool clean` to fix errors, collapse newlines to reduce size
ClosesHomebrew/homebrew#38194.
Signed-off-by: Xu Cheng <xucheng@me.com>
Packages supporting CMake may install configuration files for use
with CMake's find_package command. A recommended location for these
is `<prefix>/lib/cmake` which is not unique across packages. This
may cause issues for Formula using this location when their Keg
is linked.
As with pkg-config, explicitly create the `lib/cmake` folder when
linking a Keg that has installed folders/files to this location.
Also add testcase.
ClosesHomebrew/homebrew#38005.
Signed-off-by: Xu Cheng <xucheng@me.com>
