809 Commits

Author SHA1 Message Date
Jack Nagel
6d949599b5 Compare pathnames directly 2014-03-01 18:42:47 -06:00
Jack Nagel
51bec382b0 Make conditional more obvious 2014-03-01 17:49:57 -06:00
Jack Nagel
26785dbe5d Use Formula.path 2014-02-28 16:51:15 -06:00
Jack Nagel
479f4bc7cd Remove deprecation notice from system "xcodebuild"
The new xcodebuild method calls system "xcodebuild" underneath, so this
notice would always be printed. Instead we will just rely on the audit
check.

Fixes Homebrew/homebrew#27092.
2014-02-28 11:04:40 -06:00
Jack Nagel
c72f9a469d Add an xcodebuild helper and deprecate system "xcodebuild"
In the future we can remove the ENV munging branch from Formula#system.

Closes Homebrew/homebrew#27081.
2014-02-27 21:53:21 -06:00
Adam Vandenberg
27365a568d add Formula[]
Closes Homebrew/homebrew#26930
2014-02-27 08:21:14 -08:00
Jack Nagel
d848a6c5fd Add nil check to partially address Homebrew/homebrew#26563 2014-02-24 23:26:11 -05:00
Adam Vandenberg
ed56bdd046 update doc 2014-02-23 15:53:26 -08:00
Adam Vandenberg
1f86923ec2 ignore skip_clean :all 2014-02-23 15:53:26 -08:00
Jack Nagel
85feea33c0 Hoist assignment to simplify a conditional 2014-02-22 21:39:38 -05:00
Jack Nagel
b96411052e Use reader method 2014-02-22 11:17:50 -05:00
Jack Nagel
a2372ad539 Use standard assignment since #initialize is only called once 2014-02-22 11:17:04 -05:00
Jack Nagel
e3e14a0cdf Eliminate nil check on path parameter 2014-02-21 20:07:41 -05:00
Jack Nagel
41a9ba8259 Move Formula.class_s to Formulary 2014-02-21 00:46:03 -05:00
Jack Nagel
fb350bad0f Remove downloader from Formula 2014-02-21 00:41:07 -05:00
Jack Nagel
129e25032b Move methods to a more logical place 2014-02-21 00:41:07 -05:00
Jack Nagel
ccb216c9c7 Delegate downloader to active_spec instead of storing it in an ivar 2014-02-20 13:45:13 -05:00
Jack Nagel
7591b79d7d Push expand_path call down into FromPathLoader 2014-02-19 16:53:18 -05:00
Jack Nagel
63629ab13b Formula#system: simplify xcodebuild special case 2014-02-15 17:47:24 -05:00
Jack Nagel
dca786176e Formula#system: remove unnecessary string casts 2014-02-15 17:47:24 -05:00
Adam Vandenberg
92203ceaca don't trigger VCS when patching
When patching read-only files, patch can try to check-out from
a VCS system when other conditions are met, such as environmental
variables being set.

Homebrew never wants to trigger this behavior, so pass --get=0.

Closes Homebrew/homebrew#26277.
2014-01-29 21:24:30 -08:00
Mike McQuaid
28143fb653 PythonDependency: massive refactoring.
Closes Homebrew/homebrew#24842.
2014-01-20 15:42:52 -08:00
Mike McQuaid
ea1ae32a13 formula: fix whitespace. 2014-01-04 13:19:20 +00:00
Jack Nagel
676f29d757 Drop unnecessary string conversion in skip_clean 2013-12-22 13:43:00 -06:00
Mike McQuaid
2afa1c3b86 tap: change core formula tap naming. 2013-12-14 23:10:20 +00:00
Mike McQuaid
4c2e7b1659 Update docs, comment mxcl/homebrew refs. 2013-12-14 18:18:35 +00:00
Jack Nagel
4f158f23b8 Set bottle version rather than re-parse it from the URL 2013-12-11 01:49:00 -06:00
Jack Nagel
bac0536730 keg_only_reason and cc_failures are not DSL methods 2013-12-09 15:15:53 -06:00
Jack Nagel
e1480953e6 Use accessors to silence uninitalized ivar warnings 2013-12-09 15:15:52 -06:00
Mike McQuaid
0f7ae17699 formula: don't print verify message, use resource.
See discussion:
81d420492c (commitcomment-4804596)
2013-12-08 21:58:03 +00:00
Mike McQuaid
a762f21e33 formula, resource: output when verifying checksum.
References Homebrew/homebrew#24566.
2013-12-08 21:37:40 +00:00
Misty De Meo
e2af1cbeeb Use BottleCollector in Bottle SoftwareSpec 2013-12-05 18:24:51 -08:00
Misty De Meo
5537abbe51 Adjust fails_with syntax for non-Apple compilers
The old version worked like this:

fails_with :gcc => '4.8.1'

That wasn't really flexible enough, and made it harder to distinguish
different releases in the same GCC series. Since no one was really
using it yet, this adjusts the syntax to be more similar to the
Apple compilers:

fails_with :gcc => '4.8' do
  release '4.8.1'
end

Like with Apple compilers, omitting `release` blacklists the entire
series.

This also unifies the `build` and `version` attributes and accessors,
and exposes them under both names.
2013-12-03 22:42:49 -08:00
Jack Nagel
bac8cce29f Flush stdout before leaving Formula#system 2013-11-29 21:05:28 -06:00
Jack Nagel
aec457bb7c Replace error-prone superenv debug ouput with a separate log file 2013-11-17 19:04:21 -06:00
Jack Nagel
a2d9271bda Remove intermediate exception in Formula#system
Now that ErrorDuringExecution is only raised in one place, we can just
raise the BuildError directly instead.
2013-11-02 22:52:24 -05:00
Xiyue Deng
917b94df98 Add cxxstdlib_check method to request changing C++ stdlib checking.
* In certain cases, a C++ software may result in linking to a different
  and incompatible C++ standard library than its dependencies and still
  works fine because it is by design. Examples include GCC, which will
  bootstrap itself and self-host after finish.

* Add a cxxstdlib_check method to formula to request changing the C++
  standard library checking. Currently using "cxxstdlib_check :skip"
  will let a formula skip such checking. This should only be used on
  rare occasions and be very careful.

Closes Homebrew/homebrew#23687.
2013-11-02 17:30:05 -07:00
Jack Nagel
d35e465671 fetch: clear partial downloads when --force is given
Fixes Homebrew/homebrew#23764.
2013-10-31 14:29:38 -05:00
Stefan
71f0ad069d Generate logs in verbose mode
Closes Homebrew/homebrew#23654.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-10-31 14:24:48 -05:00
Mike McQuaid
a28b57d3fb git-etc: remove all code.
I've given up on this; too many edge cases.
If someone else wants to pick it up then send me a message and I'll walk
you through the approach.
2013-10-30 16:15:31 -07:00
Mike McQuaid
d9d2443d5d Cleanup use of some global constants. 2013-10-30 13:20:48 -07:00
Mike McQuaid
4c0fd46329 Formula: add tap? method. 2013-10-30 11:20:02 -07:00
Mike McQuaid
202c6ef826 global: add more tap regexes. 2013-10-30 11:19:46 -07:00
Jack Nagel
83d4ac5092 Remove "double negative" condition 2013-10-22 13:31:14 -05:00
Jack Nagel
63e1c71c50 Eagerly initialize formula specs
Declarations of dependencies, options, and resources in the DSL only
apply to specs that have already been initialized. For example, given
this snippet:

  url ...
  sha1 ...

  depends_on 'foo'

  devel do
    url ...
    sha1 ...
  end

The dependency 'foo' will be recorded for the stable spec, but not the
devel spec, since it was not initialized prior to the call to
depends_on.

While it is considered best practice to declare all specs (stable,
devel, head, and bottle) prior to other declarations, there is nothing
that enforces this ordering, so when it happens it can be confusing and
hard to debug.

To prevent this, we can initialize all specs up front. This comes with
a performance penalty for commands that load all formulae into memory,
but that is probably outweighed by what we gain in correctness.

Fixes Homebrew/homebrew#23425.
2013-10-22 13:31:08 -05:00
Mike McQuaid
6551643127 HOMEBREW_GIT_ETC: fix nil etc bug. 2013-10-19 14:24:33 +01:00
Mike McQuaid
ee7869b056 formula: fix git_etc bash_completion handling. 2013-10-19 13:54:49 +01:00
Mike McQuaid
a6e2245732 git_etc: update based on bottle etc/var changes. 2013-10-10 16:46:47 +01:00
Mike McQuaid
af4247429b formula: add bottle_prefix method. 2013-10-10 16:46:47 +01:00
Mike McQuaid
caa2f87728 InstallRenamed: don't overwrite etc files; rename.
If an etc file exists on installation instead of overwriting it (or
requiring all the manual checks in formula) simply copy it with the
extension `.default` appended.
2013-10-10 16:46:47 +01:00