31881 Commits

Author SHA1 Message Date
Kevin
c44e053847
Merge pull request #17242 from Homebrew/fix-cask-source-file-path-loading-issues
Fix cask source file path loading issues
2024-05-08 18:28:04 -07:00
apainintheneck
3dcb26072b cli/named_args: address review feedback
- use `T.cast` to avoid unnecessary error handling with Sorbet
- avoid using dashes in terminal output to make piping easier
2024-05-08 18:13:35 -07:00
Darren Kavanagh
85cd2f075e
cmd/update.sh: check initial branch is not master
Check that the initial branch is not 'master' before doing a forced update on 'master'. Git will fail with fatal error otherwise.
2024-05-08 14:44:59 -07:00
Carlo Cabrera
21e130056a
Merge pull request #17257 from Homebrew/dependabot/bundler/Library/Homebrew/multi-df01635c99 2024-05-08 20:28:29 +01:00
BrewTestBot
0497d7abfb
brew vendor-gems: commit updates. 2024-05-08 18:34:24 +00:00
BrewTestBot
91ea590cfa
brew vendor-gems: commit updates. 2024-05-08 18:34:00 +00:00
dependabot[bot]
26248571b3
build(deps-dev): bump rspec-mocks in /Library/Homebrew
Bumps [rspec-mocks](https://github.com/rspec/rspec-mocks) from 3.13.0 to 3.13.1.
- [Release notes](https://github.com/rspec/rspec-mocks/releases)
- [Changelog](https://github.com/rspec/rspec-mocks/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-mocks/compare/v3.13.0...v3.13.1)

---
updated-dependencies:
- dependency-name: rspec-mocks
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-08 18:33:28 +00:00
dependabot[bot]
cc46ad4f58
build(deps): bump sorbet-runtime and sorbet-static-and-runtime
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11369 to 0.5.11370
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11369 to 0.5.11370
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-08 18:33:06 +00:00
Jason Karns
1f1a8b6c11
Add Brewfile documentation to tap-new readme template
It would be helpful for taps to document how they are to be used with `Brewfile`.

Adding documentation for formulae installation to the generated tap readme would help ensure that new taps have this helpful documentation in their repos from the start.
2024-05-08 14:20:51 -04:00
Mike McQuaid
9bf7734749
Merge pull request #17252 from bevanjkay/extract_plist_url
extract_plist: fix passing an alternative url
2024-05-08 12:23:15 +01:00
Bevan Kay
6c90e65f6f
livecheck/livecheck: fix passing an alternative url 2024-05-08 15:02:43 +10:00
apainintheneck
60149fb5de cli/named_args: improve message for casks/formulae without taps
This just improves the messaging in the `#to_formulae_and_casks_with_taps`
method so that users have a better idea of what to try next.

Ex.

```
Error: These formulae and casks are not in any locally installed taps!

- discord
- iterm2
- visual-studio-code
- zstd

You may need to run `brew tap` to install additional taps.
```
2024-05-07 21:22:58 -07:00
apainintheneck
5005916093 tap: update core tap --force messaging
Per this suggestion: https://github.com/Homebrew/brew/pull/17227#discussion_r1590630520
2024-05-07 20:07:27 -07:00
Carlo Cabrera
020d9947b0
Merge pull request #17249 from Homebrew/dependabot/bundler/Library/Homebrew/multi-083f53c1ae 2024-05-07 21:07:29 +01:00
BrewTestBot
fe24bf1579
Update RBI files for tapioca.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-05-07 18:59:27 +00:00
BrewTestBot
b53e117618
brew vendor-gems: commit updates. 2024-05-07 18:59:07 +00:00
BrewTestBot
eba59a608d
brew vendor-gems: commit updates. 2024-05-07 18:58:10 +00:00
dependabot[bot]
2124b9844e
build(deps-dev): bump tapioca from 0.13.3 to 0.14.0 in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.13.3...v0.14.0)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-07 18:58:00 +00:00
dependabot[bot]
fc55ea15e9
build(deps): bump sorbet-static-and-runtime and sorbet-runtime
Bumps [sorbet-static-and-runtime](https://github.com/sorbet/sorbet) and [sorbet-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-static-and-runtime` from 0.5.11368 to 0.5.11369
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-runtime` from 0.5.11368 to 0.5.11369
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-07 18:57:07 +00:00
Mike McQuaid
d3746d55f2
Merge pull request #17248 from Homebrew/remove_plist_startup
caveats_spec: remove outdated plist_startup reference.
2024-05-07 19:54:25 +01:00
Sean Molenaar
a43b7464c2 feat: add generated SPDX file on bottling 2024-05-07 20:33:22 +02:00
Mike McQuaid
46c6571bd6
caveats_spec: remove outdated plist_startup reference.
This was removed a long time ago.
2024-05-07 19:31:28 +01:00
Mike McQuaid
310c75fab1
Merge pull request #17233 from Homebrew/deprecate_disable_remove
Homebrew 4.3.0 deprecation/disable/removals.
2024-05-07 12:30:03 +01:00
Mike McQuaid
222fe8ef0b
Homebrew 4.3.0 deprecation/disable/removals.
The usual pass of deprecating/disabling/removing code for the next
minor Homebrew release.
2024-05-07 12:18:04 +01:00
Mike McQuaid
ab845ef22e
tap: allow/forbid installation of taps from environment variables.
Extend the allow/forbid of taps during formula installation to allow or
forbid the installation of taps themselves based on the values of the
`HOMEBREW_ALLOWED_TAPS` and `HOMEBREW_FORBIDDEN_TAPS` environment
variables.

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-05-07 10:52:19 +01:00
Mike McQuaid
d20cb9794d
Merge pull request #17244 from Homebrew/verbose_flag_fixes
brew.sh: shift `-v` to the end of the parameter list earlier.
2024-05-07 10:03:02 +01:00
Mike McQuaid
d77dbe8b89
Merge pull request #17241 from Homebrew/cask-audit-sourceforge
cask/audit: tune sourceforge.net URL regex
2024-05-07 09:06:50 +01:00
Mike McQuaid
7a61b03e72
brew.sh: shift -v to the end of the parameter list earlier.
Fixes #17240
2024-05-07 08:57:57 +01:00
Mike McQuaid
fc13eb83c8
Merge pull request #17213 from Homebrew/allowed-taps
env_config: add `HOMEBREW_ALLOWED_TAPS`
2024-05-07 08:47:57 +01:00
apainintheneck
ffc503f1d0 Fix cask source file path loading issues
There are two big changes here. Both have to do with how we want
to load casks in different scenarios. One also is related to formulae.

1. Prevent loading casks & formulae outside of taps for specific commands.

There are certain commands like `bump`, `bump-*-pr`, `livecheck` and `audit`
where it really makes no sense to try and run things if the specified formulae
or cask is not in a tap. A new `#to_formulae_and_casks_with_taps` method was
added to the `CLI::NamedArgs` class to allow us to easily grab and validate
formulae and casks from named arguments.

2. Always load the source file path when loading casks with the path loader.

There was an edge case where all JSON cask files were being loaded without
setting the source file path because most of the work was handed off to the
API loader where that normally would make more sense. Now we set that when
calling the API loader which solves the problem. This improves the user
experience of people using the `--cache` and `fetch` commands in certain
edge cases. Hopefully it makes the user experience a bit more consistent.

A regression test was added for this point.
2024-05-06 23:34:23 -07:00
Eric Knibbe
4932fb7fd0
rubocops/urls: remove dead link 2024-05-06 22:57:23 -04:00
Eric Knibbe
d1d0bfc0ba
cask/audit: tune sourceforge.net URL regex 2024-05-06 22:56:28 -04:00
BrewTestBot
f6ee965c4f
Update RBI files for rbi.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-05-06 16:48:38 +00:00
BrewTestBot
3a389c31d1
brew vendor-gems: commit updates. 2024-05-06 16:48:00 +00:00
dependabot[bot]
5987bc95dc
build(deps-dev): bump rbi from 0.1.12 to 0.1.13 in /Library/Homebrew
Bumps [rbi](https://github.com/Shopify/rbi) from 0.1.12 to 0.1.13.
- [Release notes](https://github.com/Shopify/rbi/releases)
- [Commits](https://github.com/Shopify/rbi/compare/v0.1.12...v0.1.13)

---
updated-dependencies:
- dependency-name: rbi
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-06 16:46:58 +00:00
Carlo Cabrera
be29afa5f7
Fix brew style 2024-05-06 15:26:29 +01:00
Carlo Cabrera
3b794fc6e8
formula_installer, cask/installer: add tests for HOMEBREW_ALLOWED_TAPS 2024-05-06 15:22:48 +01:00
Carlo Cabrera
078a328e8e
tap: avoid class vars
Avoiding them also allows us to write proper tests.
2024-05-06 15:05:06 +01:00
Mike McQuaid
82c2e743a5
Merge pull request #17228 from Homebrew/replace-formula-text-audits-with-rubocops
Replace `FormulaTextAuditor` usage
2024-05-06 08:46:28 +01:00
Mike McQuaid
80b35e8a55
Merge pull request #17223 from reitermarkus/resource-sig
Add `resource` signature.
2024-05-06 08:40:59 +01:00
Mike McQuaid
3d31594e39
Merge pull request #17220 from woodruffw-forks/ww/refine-gh-auth
attestations: improve authentication techniques
2024-05-06 08:38:07 +01:00
Carlo Cabrera
34387bfc8a
cask/installer: update to match formula_installer 2024-05-05 14:00:02 +01:00
Carlo Cabrera
3555d09c1d
formula_installer: fix failing test 2024-05-05 13:59:36 +01:00
Issy Long
9f915a6a62
Replace FormulaTextAuditor usage
- Only two audits were using this: `audit_keg_only_reason` and `audit_text`,
  and they weren't using any of its text processing methods, so there's little
  reason to keep it around.
- The "`keg_only_reason` shouldn't contain 'HOMEBREW_PREFIX'" audit can easily
  be replaced with a RuboCop since that's "just" text parsing.
- The "tests should invoke binaries with `bin/<command>`" audit had to stay as
  a FormulaAudit because it requires accessing attributes about the Formula
  like its name, aliases, which RuboCop can't get to, but it was easy to move the
  singular "read the text in the file" line from `FormulaTextAuditor`.
2024-05-04 22:14:55 +01:00
Kevin
7e0c137955
Merge pull request #17227 from Homebrew/tweak-core-tap-warning
tap: tweak core tap warning
2024-05-04 10:37:18 -07:00
apainintheneck
373b7d1dbb tap: tweak core tap warning
Most users don't need the core taps to be installed locally but the
current message doesn't communicate that they're sometimes necessary
for local development. This just tweaks the message to be more
informative.

```console
$ brew tap homebrew/cask
Error: Tapping homebrew/cask is no longer typically necessary.
Add --force if you are sure you need it for local development.
```
2024-05-04 09:59:47 -07:00
Eric Knibbe
3d985d082e
cmd/generate-cask-api: include cask renames 2024-05-03 19:16:32 -04:00
Markus Reiter
e39a421bb0
Add resource signature. 2024-05-03 22:29:50 +02:00
Carlo Cabrera
f92b2f21c0
github_runner_matrix: add -x86_64 to Intel runner names
See Homebrew/ci-orchestrator#15.

Needs Homebrew/ci-orchestrator#15.
2024-05-03 20:22:07 +01:00
William Woodruff
7e43e5aafe
attestation_spec: another auth case
Signed-off-by: William Woodruff <william@yossarian.net>
2024-05-03 13:17:31 -04:00