88 Commits

Author SHA1 Message Date
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
L. E. Segovia
e09d4336a9
Unzip Casks w/ extended attributes with ditto
Fixes Homebrew/homebrew-cask#61386
2019-04-08 22:54:33 +00:00
Mike McQuaid
20e4262fb9
unpack_strategy: prioritise extension instead.
Instead of only looking at the extension when invoked as part of
Homebrew's formulae' download strategies instead prioritise the
extension if it actually exists. When it does not, fall back to the
magic detection logic which is likely to be more reliable.

Fixes https://github.com/Homebrew/brew/issues/5895
2019-04-03 10:32:29 +01:00
JuPlutonic
e0bf31764e Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
update gnu_tar.rb

removed tab

update unpacking_strategy/tar.rb

to resolve conversations
But OFFENCE found, W: 31: 36: Unused method argument - basename (brew style)
Now I start to using rubocop inside Sublime_text3 where I see all right linting messages.

Rollback install.rb changes.

Conversation resolved, extra_args: "--owner=0", "--group=0" and "--no-same-owner" in extend/os/linux/gnu_tar.rb.

Conversation: file extend/os/linux/gnu_tar.rb moved to extend/os/linux/unpack_strategy/tar.rb. Module UnpackStrategy is parent for the GnuTar module.

Conversation: new file extent/unpack_strategy/tar.rb to require logic, unpack_strategy/tar.rb newline bef. require-line, require-line changed.

Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
2019-03-01 14:22:39 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter
edb8a2486b Remove -quiet flag when verbose. 2018-11-02 11:46:06 +01:00
Jonathan Chang
b30ab67ca6 unpack_strategy: fix extension for compress 2018-10-27 22:46:33 +11:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
81cbab846f Remove __MACOSX directory after unzipping. 2018-09-14 17:41:09 +02:00
Markus Reiter
06549c751b Fix extracting .pax archives. 2018-09-11 19:22:19 +02:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Markus Reiter
3e79e1b89e .tar.lz.tar.lzma 2018-08-21 15:46:24 +02:00
Markus Reiter
556e76b037 Use cp instead of FileUtils.copy_entry. 2018-08-20 19:06:55 +02:00
Markus Reiter
da34d85ddc Only use ditto to extract skipped volumes. 2018-08-06 22:59:02 +02:00
Markus Reiter
81939dc496 Pass verbose to unpack strategies. 2018-08-02 15:52:55 +02:00
Markus Reiter
9e025f5e44
Merge pull request #4587 from reitermarkus/ditto
Use `ditto` instead of `unzip`.
2018-08-02 05:45:24 +02:00
Markus Reiter
2e48373305 Use ditto instead of unzip. 2018-08-01 07:50:15 +02:00
Markus Reiter
4c80f827ad Only search by extension when unpacking formulae. 2018-08-01 04:16:27 +02:00
Markus Reiter
f8dc9eff58 Move .tar.xz logic from Xz to Tar. 2018-08-01 00:56:36 +02:00
Markus Reiter
281ead3096 Look for extension first, then fall back to magic number. 2018-08-01 00:56:36 +02:00
Markus Reiter
04e97e82db Use magic number for Adobe Air. 2018-08-01 00:56:36 +02:00
Markus Reiter
e8f7a88976 Only call hdiutil if it’s a bzip2 or zlib. 2018-08-01 00:56:36 +02:00
Markus Reiter
7cf8bb4f8c Add Diff unpack strategy. 2018-08-01 00:56:36 +02:00
Markus Reiter
b5548f9548
Merge pull request #4551 from ffeu/fix_svn_with_at_symbol
Adjusting SVN commands to consider the @ symbol
2018-07-30 20:01:46 +02:00
feu
43d53a67b7 just adjusting spaces 2018-07-29 20:54:13 -03:00
feu
ce3ac54e2c changing to use system_command .. chdir 2018-07-29 11:36:43 -03:00
Markus Reiter
8a24472e2e Don’t match MZ for Cab. 2018-07-27 00:54:31 +02:00
feu
a0f30934aa removing unnecessary .to_s 2018-07-25 19:46:35 -03:00
feu
9594a56879 removing svn_cached_location and using svn_escape(path) inside subversion.rb 2018-07-25 19:32:36 -03:00
feu
2f18fff999 adjusting svn commands to consider the @ symbol 2018-07-25 16:42:16 -03:00
Markus Reiter
d8624f5fe7 Remove MachO check for Executable. 2018-07-25 10:03:50 +02:00
Markus Reiter
83a1e8dd97 Refactor UnpackStrategy::Dmg. 2018-07-24 16:44:27 +02:00
Markus Reiter
eccd20e276 Merge Hbc::Container classes into UnpackStrategy. 2018-07-24 16:44:27 +02:00
Markus Reiter
b6e54a06e0 Refactor unpack strategies into separate files. 2018-07-23 20:59:28 +02:00