311 Commits

Author SHA1 Message Date
Issy Long
cb2a09e65e
Fix (auto-correct) more RSpec/BeNil offenses
- The `RSpec/BeEq` auto-corrections made more `RSpec/BeNil` offenses, so another go of `brew style --only=RSpec/BeNil --fix\` is needed.
2022-03-01 00:36:37 +00:00
Issy Long
72e48024f0
Fix (auto-correct) RuboCop Rspec/BeEq offenses 2022-03-01 00:10:14 +00:00
Issy Long
6b76fd012a
Fix (auto-correct) RuboCop RSpec/BeNil offenses 2022-03-01 00:10:10 +00:00
Niklas Higi
00f209e16e
Recommend interactive usage of fish_add_path
Since the `fish_add_path` command modifies a universal Fish variable
(which is automatically persisted to a file) it's unnecessary to run it
again every time a new shell is opened.
2022-02-05 16:29:09 +01:00
Carlo Cabrera
2b60a99d4a
Revert "shebang: raise error if no rewriting"
This is causing failures when attempting to rewrite shebangs during the
cleanup stage of `brew install`.

See, for example, Homebrew/homebrew-core#94323,
Homebrew/homebrew-core#94321.

This reverts commit 7e6be5eb4474ed9eaa4b8e9a5a45e3340186840c.
2022-02-02 20:44:03 +08:00
Branch Vincent
7e6be5eb44
shebang: raise error if no rewriting 2022-02-01 00:17:50 -05:00
Mike McQuaid
b09f421027
repology: always use Homebrew curl.
This seems to be required even with TLSv1.3 support now.

Also, while we're here, improve the error handling/output.
2022-01-03 13:17:12 +00:00
Steve Peters
d53dab62c9
bump-revision: add --remove-bottle-block option
This removes a bottle block for the specified formulae
while bumping the revision.
2021-12-26 03:42:39 -08:00
Rylan Polster
2e6b6ab3a2
Fix style 2021-12-24 21:15:21 -05:00
Rylan Polster
7656c09184
Only check for Rosetta on macOS 2021-12-05 13:03:38 -05:00
Nipunn Koorapati
30c4663066 Fix analytics string to test for CI 2021-12-04 12:29:31 -05:00
Rylan Polster
b58551cd67
Control for CPU type and Rosetta in os_arch_prefix_ci tests 2021-12-03 22:29:10 -05:00
Nipunn Koorapati
e2fc14b0b7 Fix analytics_spec.rb test to pass when run from M1 2021-12-03 20:14:17 -05:00
XuehaiPan
d1aac8857a tests/utils/git_spec: update tests for ensure_formula_installed! 2021-11-24 00:30:26 +08:00
Carlo Cabrera
105d1f9cfc
utils/github/actions: make file a mandatory argument
An annotation is pretty useless if you don't specify a file to place the
annotation on, so let's just require it.
2021-11-16 23:42:03 +08:00
EricFromCanada
c952ea7358
bump: fix tests 2021-10-25 15:55:11 -04:00
EricFromCanada
811d0fa0bd
bump: add option to retrieve a subset of results
Plus a few fixes for output.
2021-10-19 20:14:39 -04:00
Bo Anderson
30b24cf4ad
Use HOMEBREW_CURL universally, including formulae 2021-10-04 02:03:04 +01:00
Bo Anderson
b55498269f
Revamp APIs around bottle specifications 2021-09-20 15:02:05 +01:00
fn ⌃ ⌥
0c3e49092c upgrade: use topological sort to upgrade formulae 2021-09-09 13:41:50 -07:00
Sam Ford
d44979fa67
Curl#curl_args: Fix and refactor options 2021-09-07 14:13:17 -04:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix 2021-07-08 12:36:39 +05:30
Mike McQuaid
1680ddb267
utils/repology: temporarily disable functionality.
Doesn't work with system `curl` currently.
2021-06-30 09:20:56 +01:00
Michael Cho
d304c84f2a
test/utils/github_spec: fix artifact number 2021-06-25 11:36:13 -07:00
Alexander Bayandin
d55cbeac78
github_spec: Update PR number with unexpired artifacts 2021-06-24 13:29:44 +01:00
Sam Ford
0752d25125
OS::Mac: Move version methods into ::Version 2021-06-23 09:03:46 -04:00
Misty De Meo
c0a02442d9
Revert "language/java: use shortened brew paths"
This reverts commits 318175cfe2b23328f1b5f13812fd59cfd45fe1dc,
e7ab760392b9691a6c730b7e0d660b7874969e70 and
3b35af63f608438b1882756feca94a6ebdd0d6a3 (PR #11537).
2021-06-17 20:29:43 -07:00
Misty De Meo
3cf5c3239f
Merge pull request #11544 from mistydemeo/fix_tests
Fix a pair of tests on Apple silicon
2021-06-16 03:15:06 -07:00
Misty De Meo
93ea8b6350
Analytics spec: avoid ARM-specific strings 2021-06-15 20:35:21 -07:00
Caleb Xu
318175cfe2
Utils: add shortened_brew_path 2021-06-15 09:58:46 -04:00
Mike McQuaid
b914411ac8
Delete Bintray code
Remove all code related to Bintray. It no longer works so there's no
point keeping it around.

Some of this could arguably be deprecated/disabled first/instead but:
I'm not sure I see the sense in keeping stuff around that's known to be
broken.
2021-05-12 13:37:18 +01:00
David Xia
7920006020
fix: use recommended way of updating Fish shell $PATH
fixes https://github.com/Homebrew/brew/issues/8965

See Fish docs https://fishshell.com/docs/current/tutorial.html#path.

> A faster way is to use the `fish_add_path function`... The advantage is that
> you don't have to go mucking around in files: just run this once at the
> command line, and it will affect the current session and all future instances
> too.
>
> Or you can modify `$fish_user_paths` yourself, but you should be careful not
> to append to it unconditionally in config.fish, or it will grow longer and
> longer.
2021-05-08 21:19:19 -07:00
John Bampton
1691e615fe Fix spelling 2021-05-08 11:20:01 +10:00
Bo Anderson
20d86c0185
Refactor some tag handling into a Utils::Bottles::Tag class 2021-04-08 17:23:57 +01:00
hyuraku
178ae750b9 utils/github: set default args to search_code 2021-02-26 21:31:30 +09:00
Kenneth Chew
edead95768
utils/spdx: correctly detect non-deprecated licenses with plus 2021-02-23 16:28:24 -05:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording offenses
- For some of these I changed `context` to `describe` as it fit better
  rather than contriving a "when", "with" or "without", or massively
  restructuring the tests.
2021-02-19 23:30:41 +00:00
nandahkrishna
24bb6040a7
dev-cmd/bump: add cask support 2021-02-17 00:42:07 +05:30
Bo Anderson
f5c075d668 test/utils/git_spec: fix cherry pick test with older git 2021-02-10 17:36:46 +00:00
nandahkrishna
0474fe6093
dev-cmd/update-maintainers: add tests 2021-02-08 23:33:25 +05:30
Mike McQuaid
e65e310fd0
Fix brew style 2021-01-29 20:56:59 +00:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
nandahkrishna
e2ddf9894a
Refactor brew bump 2021-01-24 19:10:46 +05:30
Seeker
bd25e7da2a utils/git_repository: add ::git_branch and ::git_commit_message 2021-01-20 17:34:54 -08:00
Seeker
64c2b21c2f git_repository_spec: group together shared examples 2021-01-19 12:32:20 -08:00
Michka Popoff
3eea1434cc bottle: tag specific cellars 2021-01-19 10:14:25 +01:00
Seeker
9bf409111c git_repository: raise error instead of returning nil if safe 2021-01-17 09:01:04 -08:00
Seeker
4f02c1c8a8 utils/git_repository: use Pathname.pwd if no repo specified 2021-01-13 13:02:37 -08:00
Misty De Meo
847897fdac Popen spec: ensure Rubocop is happy
These were introduced in #10305 but only started going red
after that PR was merged.
2021-01-13 11:21:10 -08:00
Seeker
be6dd72c16
Merge pull request #10305 from SeekingMeaning/safe-popen-tests
utils/popen: add `safe` argument to `popen_read` and `popen_write`
2021-01-13 10:51:46 -08:00