446 Commits

Author SHA1 Message Date
Mike McQuaid
4add1d1cb3
Check binary URL resources with RuboCop
- Migrate the existing binary URL audit to a RuboCop.
- Check resources as well as main URLs
- Also check for "macos" and "osx" in URLs
- Add whitelists for URLs and formulae
2019-09-02 10:50:49 +01:00
Izaak Beekman
75bc30bfff
Limit veclibfort & lapack cop to core & add tests 2019-06-06 18:09:44 -04:00
Izaak Beekman
65fbcc86d0
Add test for MPI choice cop's autocorrect 2019-06-06 16:46:17 -04:00
Izaak Beekman
ffe30058ab
Add MPICH cop and test
- Split off from PR Homebrew/brew#6209
 - Create stand alone class for cop w/ auto-correct
2019-06-06 16:28:54 -04:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Mike McQuaid
75257886f2
Cleanup some RSpec tests
Fix some Rubocop RSpec checks, update some values and improve
documentation.
2019-03-28 19:16:56 +00:00
Mike McQuaid
fd4e45c688
lines_spec: fix a typo. 2019-01-30 21:59:55 +00:00
Mike McQuaid
1aa8ad09e2
Deprecate macOS versions below Mavericks
And remove all dead/unneeded code.
2019-01-27 12:27:47 +00:00
Mike McQuaid
db7fd7b7a2
Tweak audits
- Ensure that new formulae problems aren't duplicated
- Now that homebrew/core will imminently not have options adjust the
  various audits so they make more sense (and exclude taps)
- Exclude taps from more preferential audits
2019-01-22 13:30:24 +00:00
Mike McQuaid
170c5493a4
Update deprecations
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
2019-01-08 19:13:46 +00:00
Mike McQuaid
b917cccf19
rubocops: remove scons audit.
This will be deprecated in #5477.
2019-01-06 14:41:37 +00:00
Claudia
5be80a78f6
Use Homebrew-controlled domain for Cask dummy URLs
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com. As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.

While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh, whose
domain and TLS certificate are both controlled by Homebrew.
2018-11-28 20:51:55 +01:00
Mike McQuaid
491ceb6c4c
Import rubocop-cask (with clean brew style) 2018-11-08 15:54:46 +00:00
Mike McQuaid
376eac2b8d
rubocops: rename files for consistency.
Make the filenames consistent with the class names.
2018-11-08 14:42:55 +00:00
Mike McQuaid
549b02f20a
Manual brew style fixes. 2018-11-02 17:29:26 +00:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
commitay
cbae07cd0f options_cop: make audits non-strict 2018-10-27 22:20:17 +10:00
Viktor Szakats
44578adfdb audit: use debian canonical mirror 2018-10-23 15:52:00 +00:00
commitay
6053b6dc5b make dependency_order_cop a regular audit 2018-09-09 08:30:57 +10:00
Markus Reiter
eca488a966 Add $LOAD_PATH for RuboCop cops. 2018-09-06 01:10:47 +02:00
Mike McQuaid
3b91c5f1ae
Merge pull request #4797 from MikeMcQuaid/rubocop-tweaks
.rubocop: tweak rules.
2018-09-02 21:13:23 +01:00
Mike McQuaid
0aa9dce03c
Revert "Add $LOAD_PATH for RuboCop cops." 2018-09-02 20:49:25 +01:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
commitay
e4049b3005
Merge pull request #4775 from commitay/cargo-install
text_cop: update `cargo build` cop
2018-08-30 08:03:42 +10:00
commitay
0ce583964e text_cop: update cargo build cop 2018-08-29 23:06:53 +10:00
Markus Reiter
444e3d2a78 Add $LOAD_PATH for RuboCop cops. 2018-08-29 01:44:47 +02:00
Jonathan Chang
ca59377a90 audit: add autocorrect and tests for test checks 2018-08-16 12:43:50 -04:00
Jonathan Chang
5f981a8722 tests: add test for test calls audit cop 2018-08-16 12:43:13 -04:00
Dominyk Tiller
f1779248de
Merge pull request #4625 from DomT4/please_stop_evading_the_audit
class_cop: tighten test audit
2018-08-08 16:32:28 +01:00
Dominyk Tiller
7d5f0df71d
class_cop_spec: add tests for tighter test audit 2018-08-07 03:46:37 +01:00
Markus Reiter
0b80aea75d Use https:// URLs. 2018-08-06 23:39:12 +02:00
Dominyk Tiller
525300b9cd
formula_desc_cop_spec: add whitespace tests 2018-08-06 19:31:30 +01:00
Dominyk Tiller
9d7f872ad6
formula_desc_cop_spec: tweak for new whitespace check 2018-08-06 19:15:31 +01:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
commitay
44873fd4c8 bottle_block_cop: remove 2018-07-04 21:25:43 +10:00
commitay
4dba9fddf1 components_redundancy: audit stable do without a head or devel spec 2018-07-03 11:56:31 +10:00
Markus Reiter
fdb2406b20 Add failing spec for DependencyOrder cop. 2018-06-11 04:21:06 +02:00
commitay
3329a9f6d8 text_cop: require cargo to use install instead of build 2018-06-10 16:42:19 +10:00
commitay
490dc9118e text_cop: require dep ensure to use -vendor-only 2018-06-08 00:42:57 +10:00
commitay
1a4340161c options_cop: formula -> formulae 2018-06-02 16:56:55 +10:00
commitay
9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Gautham Goli
efec2fa0c5 lines_cop: Add deprected options audit for depends_on 2018-05-06 15:42:51 +05:30
ilovezfs
ae6ae30857
Merge pull request #4110 from commitay/desc_cop
formula_desc_cop desclength: make non-strict
2018-04-25 06:01:42 -07:00
Mike McQuaid
9089ea4df3
Merge pull request #4109 from commitay/components_redundancy_cop
components_redundancy_cop: make non-strict
2018-04-25 08:32:35 +01:00
Mike McQuaid
56124f2918
Merge pull request #4108 from commitay/urls_cop_pypi
urls_cop pypiurls: make non-strict
2018-04-25 08:32:30 +01:00
commitay
156451bd4b formula_desc_cop desclength: make non-strict 2018-04-25 16:38:40 +10:00
commitay
1b7e6f7eb2 urls_cop pypiurls: make non-strict 2018-04-25 12:18:22 +10:00