Rylan Polster
5f57601fd8
style: re-enable bottle order cop
2021-02-04 17:18:20 -05:00
Carlo Cabrera
2de172e050
rubocops/bottle: disable bottle order check
...
This is causing CI failures at homebrew/core [1], so let's disable this
for now.
[1] 01b6830646
2021-02-04 11:18:09 +00:00
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order
...
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2021-02-03 20:46:20 -05:00
Rylan Polster
d5d7b6c3db
style: remove RSpec/MultipleDescribes violations
...
Co-authored-by: Nanda H Krishna <nanda.harishankar@gmail.com>
2021-02-01 20:30:51 -05:00
Rylan Polster
3e00b3ea28
style: remove RSpec/ExampleLength violations
2021-02-01 20:30:51 -05:00
Michka Popoff
38ae6e0c0d
style: re-enable sha256 checks for bottle blocks
...
Follow up PR to #10450
2021-01-28 20:35:31 +01:00
EricFromCanada
a427de5bee
capitalization fixes
...
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
Seeker
48e44870e6
Merge pull request #10334 from SeekingMeaning/rubocop-spec-descriptions
...
rubocops/*: improve test descriptions
2021-01-17 19:57:54 -08:00
Seeker
32ba87d254
Merge pull request #10332 from SeekingMeaning/text_spec-descriptions
...
rubocops/text: improve test descriptions
2021-01-17 19:57:23 -08:00
Seeker
8fa263bcb9
rubocops/text: add "in homebrew/core" to applicable tests
2021-01-15 08:41:47 -08:00
Seeker
7e75d8342b
rubocops/urls: rename formulae to offense_list
2021-01-15 08:26:50 -08:00
Seeker
1d8372cbc8
rubocops/*: improve test descriptions
2021-01-14 19:06:37 -08:00
Seeker
3893cb312e
rubocops/text: improve test descriptions
2021-01-14 18:08:05 -08:00
Seeker
33edb9f901
rubocops: point to offending OS-specific block in resource blocks
2021-01-13 23:18:32 -08:00
Jonathan Chang
641afdd2de
rubocops: permit mirror in OS-specific resources
2021-01-14 17:04:40 +11:00
Jonathan Chang
ac8eb00443
rubocops/cask/*: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
0366e2f7f7
rubocops/options: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
23b8d0ccb8
rubocops/desc: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
929e481dce
rubocops/keg_only: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
df8e030174
rubocops/patches: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
bb497ebfe0
rubocops/caveats: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
c3f797d9ac
rubocops/components_order: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
f57c96465c
rubocops/conflicts: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
92e07f5c0b
rubocops/homepage: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
63bebf542f
rubocops/dependency_order: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
098ade1319
rubocops/urls: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
a778dc3bdb
rubocops/class: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
3bda457478
rubocops/text: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
c18ffa84ca
rubocops/deprecate_disable: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
9046d778e0
rubocops/checksum: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
b8fb568021
rubocops/lines: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Seeker
2a80427755
unless_multiple_conditions: add autocorrect
2021-01-08 10:33:56 -08:00
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
souleater7
98e7538679
Fix style test in lines_spec.rb
2021-01-05 15:22:26 -08:00
souleater7
e50e3e4b22
Delete references to devel
2021-01-01 10:16:31 -08:00
Seeker
174645fb95
test/rubocops: improve test descriptions
2020-12-24 09:42:03 -08:00
Rylan Polster
b5cc723d33
tests/rubocops/components_order: fix test descriptions
2020-12-23 21:05:50 -05:00
Seeker
4924b7633c
components_order: allow if-else statements inside on_os blocks
...
Co-Authored-By: Rylan Polster <rslpolster@gmail.com>
2020-12-23 19:28:11 -05:00
Rylan Polster
27ce5754c9
style: fix on_macos/on_linux resource block checks
2020-12-23 17:04:24 -05:00
Mike McQuaid
87dd13aea6
Deprecate cask requirements.
...
This probably has to wait until 2.7.0 now and will require a bunch of
formula changes/deprecations but we should probably start moving in this
direction given we're not installing any of these on our CI any more.
2020-12-15 14:19:45 +00:00
Seeker
c4da302303
on_macos/on_linux block: improve rubocop message
...
Co-authored-by: Markus Reiter <me@reitermark.us>
2020-12-10 11:47:25 -08:00
Rylan Polster
01cf98e526
Remove style exceptions for ProvidedByMacos and UsesFromMacos
2020-12-03 14:30:34 -05:00
Rylan Polster
78060765b2
rubcops/provided_by_macos: fix wording for core formulae
2020-12-02 21:19:17 -05:00
Rylan Polster
f450bfbf5e
style: migrate some lists back to Homebrew/brew
2020-12-02 20:56:07 -05:00
Rylan Polster
77b4275f81
Merge pull request #9326 from Rylan12/migrate-style-exceptions
...
Migrate style exceptions to homebrew/core
2020-12-01 12:19:45 -05:00
linzichao
058a1c3645
add verified parameter in url
2020-12-01 01:17:21 +01:00
Rylan Polster
0c41d374c9
style: add tests for provided_by_macos and style_exceptions
2020-11-30 18:18:51 -05:00
Rylan Polster
44bfbd0112
Migrate uses_from_macos style lists
2020-11-30 18:18:50 -05:00
Rylan Polster
7a8dd36003
Migrate BINARY_BOOTSTRAP_FORMULA_URLS_ALLOWLIST
2020-11-30 18:18:50 -05:00
Rylan Polster
1dbbcfd1d6
Migrate COMPONENTS_ORDER_EXCEPTIONS
2020-11-30 18:18:50 -05:00
