Mike McQuaid
97ad3567d1
Optimise more command handling/speed
...
- in `brew.sh` split the `case` into those cases that take a single or
no arguments and those that take multiple arguments or handle
multiple commands. This considerably speeds up the
`brew shellenv bash` case that wasn't being handled here before.
- add `setup-ruby` to the list of commands that can be called quickly
by `brew.sh` without additional setup. This speeds up the
`brew setup-ruby` no-op case by ~10x.
- add a parameter to `setup-ruby` to avoid running Bundler if the
command doesn't need it. This makes many more cases for
`brew setup-ruby` to be no-op cases.
- Remove the (now) unused `HOMEBREW_RUBY3` check in `setup-ruby`.
- Improve argument handling in `command_path.sh` to allow it to be
used as a function in `setup-ruby.sh`.
- Add a new RuboCop to check usage of `install_bundler_gems!` is only
inside `dev-cmd` (or a few other acceptable places).
- Use new `processed_source.file_path` API in `formula_cop.rb`
2024-04-30 12:48:29 +01:00
Markus Reiter
0f0055ede4
Make documentation @api private
by default.
2024-04-26 19:04:20 +02:00
Douglas Eichelberger
caf8259ae6
Code review changes
2023-12-27 15:29:33 -08:00
Douglas Eichelberger
3abbf4447e
Some minor regexp match perf improvements
2023-12-27 13:16:36 -08:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop
2023-12-14 05:47:12 +00:00
Mike McQuaid
d30fee25e4
formula_cop: fix style_exceptions_dir
handling.
...
This needed to be adjusted to handle a sharded homebrew/core and
repositories with formulae in the root.
2023-08-09 15:20:57 +01:00
Markus Reiter
8274920217
Rename OS::Mac::Version
to MacOSVersion
.
2023-05-09 05:08:38 +02:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
Douglas Eichelberger
cc5b013cb9
Remove compatibility layer
2023-03-14 14:49:34 -07:00
Douglas Eichelberger
bd5a7f6a14
Update formula_cop.rb
2023-02-21 09:52:20 -08:00
Douglas Eichelberger
387d2f859f
Use exclude_from_registry instead
2023-02-20 18:14:47 -08:00
Douglas Eichelberger
d9db5e8825
Refactor FormulaCop as a mixin
2023-02-20 18:14:47 -08:00
Douglas Eichelberger
a57764e4d6
Disable FormulaCop
2023-02-16 15:51:20 -08:00
Douglas Eichelberger
6c93f6fe91
Enable typing in rubocops
2023-02-16 15:51:20 -08:00
Douglas Eichelberger
e98e668a34
remove redundant string extension
2023-01-28 08:26:11 -08:00
Bo Anderson
6ede5d2dd5
rubocops: handle empty formula body in various cops
2022-11-05 04:40:16 +00:00
fn ⌃ ⌥
d5f949e60b
Check dependency order in on_system methods
2022-08-03 06:33:30 -07:00
Bo Anderson
629dbb7c59
rubocops/urls: allow plain HTTP mirrors
2021-10-01 13:42:05 +01:00
Bo Anderson
3e4cb206bb
rubocops: silence parser warning
2021-09-23 03:45:15 +01:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Michka Popoff
38ae6e0c0d
style: re-enable sha256 checks for bottle blocks
...
Follow up PR to #10450
2021-01-28 20:35:31 +01:00
Seeker
5c3dec6476
rubocops: move some methods from FormulaCop to HelperFunctions
2021-01-15 10:15:11 -08:00
Jonathan Chang
f81e89193e
rubocops: update helpers for rubocop v1 API
2021-01-12 19:11:42 +11:00
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Rylan Polster
11a5e522ea
rubocop: don't rely on ActiveSupport
2020-11-30 18:18:50 -05:00
Rylan Polster
44bfbd0112
Migrate uses_from_macos style lists
2020-11-30 18:18:50 -05:00
Rylan Polster
80a46edee4
tap: add style_exceptions configuration
2020-11-30 18:18:49 -05:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
EricFromCanada
4f7719ac2e
apidoc: update examples' syntax
2020-11-05 23:50:55 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
b4e8bfe716
Fix RuboCop offenses.
2020-10-09 11:17:55 +02:00
Markus Reiter
7e2e5bf388
Document FormulaCop
.
2020-08-26 03:13:59 +02:00
Waldir Pimenta
fc6813f094
Extract formula desc auditing code to a separate module
...
The extracted module will be used for Cask descs as well.
Co-authored-by: Markus Reiter <me@reitermark.us>
2020-08-08 23:02:39 +01:00
Rylan Polster
1a703a1234
regex_match_group: handle non UTF-8 encoded strings
2020-07-10 11:17:37 -04:00
Rylan Polster
cb187f6846
RuboCop string_content keep string interpolation
2020-06-25 09:05:43 -04:00
Mike McQuaid
12bdb38663
rubocop: brew style --fix autocorrections.
2020-05-12 08:32:27 +01:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes.
2020-03-13 21:16:18 +00:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
EricFromCanada
89f0fcedbe
whitespace fixes
2019-04-13 21:32:04 -04:00
EricFromCanada
fa6404e0f5
grammar fixes
2019-04-13 21:29:32 -04:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier.
2019-02-21 12:55:49 +00:00
Mike McQuaid
376eac2b8d
rubocops: rename files for consistency.
...
Make the filenames consistent with the class names.
2018-11-08 14:42:55 +00:00
EricFromCanada
20167e5f1b
Adjust comments to tidy API docs output.
2018-10-18 21:42:43 -04:00
Markus Reiter
e9b9ea49a1
Update to RuboCop 0.59.1.
2018-09-17 03:45:59 +02:00
Markus Reiter
eca488a966
Add $LOAD_PATH
for RuboCop cops.
2018-09-06 01:10:47 +02:00
Mike McQuaid
0aa9dce03c
Revert "Add $LOAD_PATH
for RuboCop cops."
2018-09-02 20:49:25 +01:00
Markus Reiter
444e3d2a78
Add $LOAD_PATH
for RuboCop cops.
2018-08-29 01:44:47 +02:00
Markus Reiter
44f56a0773
Refactor join("")
to join
.
2018-06-15 13:56:08 +02:00
Markus Reiter
a0ca601a1a
Silence Parser
compatibility warning.
2018-05-26 16:24:48 +02:00
Gautham Goli
efec2fa0c5
lines_cop: Add deprected options audit for depends_on
2018-05-06 15:42:51 +05:30