Mike McQuaid
d08a4accfb
Merge pull request #4083 from MikeMcQuaid/remove-xcode-installed-guards
...
Remove Xcode.installed? guards.
2018-04-17 11:16:43 +01:00
Mike McQuaid
85edbd28b1
Remove Xcode.installed? guards.
...
It's safe since 600d58f4ca3d85894c66a38802965fd94d4ea469 when
MacOS::Xcode.version started returning `Version::NULL` where
appropriate.
2018-04-17 10:58:51 +01:00
Mike McQuaid
0a00312b71
Autocorrect new RuboCop 0.55.0 style violations.
2018-04-17 10:54:58 +01:00
Mike McQuaid
cffa5a9864
Disable/delete/add more deprecations
...
Move various `odeprecated` to `odisabled` and delete uses of
`odisabled`.
2018-04-08 14:57:17 -07:00
Mike McQuaid
9fca172d03
Fix HOMEBREW_RUBY_WARNINGS="-w"
...
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Alyssa Ross
264acb22f4
Restore Formula#declared_runtime_dependencies
...
This got lost in a merge.
2018-04-07 12:16:10 +01:00
Alyssa Ross
6bbc56c3a9
Merge branch 'master' into undeclared_runtime_dependencies
2018-03-30 12:39:13 +01:00
Markus Reiter
94f2098c36
Only use HOMEBREW_TAP_PATH_REGEX
once inside Tap
class.
2018-03-29 22:05:02 +02:00
Mike McQuaid
42a39b16bf
formula: use runtime_dependencies from tab.
...
Don't do so in `linkage_checker` or `tab` which to avoid recursive loops
and want the actual values specified in the formula itself.
2018-03-27 14:52:47 +01:00
Mike McQuaid
6fec707059
Formula#missing_dependencies: use runtime_dependencies.
2018-03-27 14:52:47 +01:00
Mike McQuaid
0a73b0b423
formula: require tab.
2018-03-27 14:52:47 +01:00
Mike McQuaid
eb31392b48
Formula#to_hash: cleanup method.
...
Use some newer Ruby functionality and avoid calling `deps` multiple
times when not necessary.
Additionally, remove the unneeded `rubocop:disable`.
2018-03-21 12:38:47 +00:00
Alyssa Ross
6cd195723f
Merge branch 'master' into undeclared_runtime_dependencies
2018-03-12 09:22:39 +00:00
Alyssa Ross
0a2f0ab456
Fix formula/linkage_checker infinite recursion
2018-03-12 09:20:24 +00:00
Mike McQuaid
70253f0009
Adjust docs and more internal code for Python 3.
...
Now we have `python` for Python 3 and `python@2` for Python 2 some more
adjustments need to be made.
2018-03-03 09:42:25 +00:00
Alyssa Ross
af682d2d63
Merge branch 'master' into undeclared_runtime_dependencies
2018-03-01 17:39:49 +00:00
Alyssa Ross
51b27039be
Revert "Only check undeclared dependencies on macOS"
...
This reverts commit fa5245f7adf38833b03e92e42aa5217ac5157773.
2018-03-01 17:30:42 +00:00
Alyssa Ross
fa5245f7ad
Only check undeclared dependencies on macOS
...
We don't currently have a LinkageChecker on Linux, so can't do this.
2018-03-01 17:30:37 +00:00
Mike McQuaid
f2ce6489b2
Use more docs.brew.sh short links
...
These are nicer on the eyes.
2018-02-22 19:46:58 +00:00
Alyssa Ross
10ec789660
Don't include declared dependencies in undeclared
...
oops
2018-02-11 16:30:58 +00:00
Alyssa Ross
40ca03e975
Add undeclared dependencies to Tab when installing
...
An installed formula doesn't get optlinked until _after_ it's installed,
meaning that we can't rely on `opt_prefix` to get the right keg.
So, if not optlinked, fall back to the formula's prefix, which will be
that of the current installation.
2018-02-11 16:23:22 +00:00
Alyssa Ross
8386e6a8c1
Undeclared dependencies in runtime_dependencies
...
Fixes https://github.com/Homebrew/brew/issues/2173 .
2018-02-11 13:44:20 +00:00
ilovezfs
f818f0e681
formula: reject dot dirs as racks
...
Dot directories are not racks because formulae names do not start with
"." so avoid attempting to descend into dot directories, which may not
always be possible (e.g. .Trashes).
2018-01-19 15:07:04 -08:00
Mike McQuaid
8a45467ad9
Merge pull request #3661 from MikeMcQuaid/deprecate-default-formula
...
Deprecate default_formula Requirement DSL
2018-01-18 15:30:56 +00:00
Mike McQuaid
e5c82dd3d9
Deprecate requirements harder
...
Remove more Requirement logic to enable future removal of default
formula logic. Also, output deprecations, convert symbol requirement
usage to deps and simplify the compatibility code for the direct
Requirement usage.
2018-01-18 08:31:20 +00:00
Mike McQuaid
b70b5429d0
Deprecate default_formula Requirement DSL
...
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Mike McQuaid
e903a5f655
formula: tweak more depends_on examples.
2018-01-11 13:33:54 +00:00
Michihito Shigemura
f5e8b2680e
docs: Fix depends_on examples in Formula page
...
example:
Error: depends_on :mysql
Correct: depends_on "mysql"
2018-01-11 21:05:14 +09:00
Mike McQuaid
faf2182495
gpg: move to compat.
2017-12-30 20:56:54 +00:00
Mike McQuaid
51114139e1
formula: require gpg and make it a module.
2017-12-29 16:19:09 +00:00
Mike McQuaid
65e719db25
post_install: use HOMEBREW_PATH.
...
Do this instead of appending the `HOMEBREW_PREFIX` as it's more
reliable at finding e.g. keg-only and requirement PATH additions. It's
not ideal as it overrides some environment filtering but the only real
alternative is recreate the entire build environment by shelling out to
`build.rb` in `formula_installer`.
2017-12-15 10:05:43 +00:00
Mike McQuaid
b085da91c3
postinstall: add HOMEBREW_PREFIX/{,s}bin to PATH.
...
This avoids the need for workarounds such as:
https://github.com/Homebrew/homebrew-core/pull/21688
2017-12-14 09:20:07 +00:00
Markus Reiter
36c0dbfe13
Simplify PATH
usage in Formula
.
2017-12-02 00:12:21 +01:00
ilovezfs
3769bcc523
formula: fix safe navigation bug
...
Safe navigation needs to be chained to preserve equivalence.
Fixes a bug introduced by 01e9ec9a in #3183 .
2017-11-02 07:26:00 -07:00
Mike McQuaid
ca189437e4
Tweak use of with_env
...
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29 14:44:43 +00:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml
.
2017-10-08 16:10:37 +02:00
Mike McQuaid
cf5fdeef1d
Rubocop: manual rule fixes.
2017-09-24 21:23:59 +01:00
Mike McQuaid
01e9ec9a9f
Rubocop: automatic rule fixes.
2017-09-24 21:23:59 +01:00
Dominyk Tiller
db1054be7b
formula: manipulate Java's home usage by default
2017-08-31 21:03:42 +01:00
Bob W. Hogg
06ecad2950
formula: Remove reference to homebrew/x11
...
That tap is now defunct.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-05 12:54:39 -07:00
Markus Reiter
c26c9204fa
Merge pull request #2965 from reitermarkus/cask-tap
...
Detect `Tap` in `CaskLoader`.
2017-08-05 16:54:26 +02:00
Bob W. Hogg
732e0aa689
formula: Remove reference to Homebrew/Homebrew
...
That repo is now defunct. Reference homebrew-core instead.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-07-31 19:24:33 -07:00
Mike McQuaid
896f41f7ed
Merge pull request #2899 from MikeMcQuaid/enable-deprecations
...
Enable more deprecations.
2017-07-30 16:32:34 +01:00
Mike McQuaid
e8c4989efb
Merge pull request #2923 from MikeMcQuaid/alias-fixes
...
keg: correctly cleanup old aliases.
2017-07-30 16:02:49 +01:00
Markus Reiter
6d6ce7cf0a
Detect Tap
in CaskLoader
.
2017-07-30 14:22:05 +02:00
Mike McQuaid
baa61f5a6e
Use https for all docs.brew.sh links.
...
May as well use the more secure link when possible.
2017-07-27 15:59:37 +01:00
Mike McQuaid
43c8223dcc
formula: ensure aliases don’t include full names.
...
Aliases that include `/`s end up creating directories and this is bad.
2017-07-21 17:20:12 +01:00
Mike McQuaid
2d18ba586b
Enable more deprecations.
...
It's been long enough that these have been commented out so let's
enable them globally.
2017-07-21 10:50:07 +01:00
Misty De Meo
32b7e32856
formula: use env helper
2017-07-15 17:41:17 -07:00