Mike McQuaid
932d2cf3b7
Merge pull request #14548 from Homebrew/revert-14382-deprecate-disable-remove
...
Revert "Add deprecations and disables"
2023-02-07 19:11:26 +01:00
Mike McQuaid
6882ac17e7
Revert "Add deprecations and disables"
2023-02-07 15:13:19 +01:00
hyuraku
8daca925f1
remove #TODO
2023-02-07 22:56:04 +09:00
hyuraku
c066e940c4
apply extend/os to Cask::cmd::install#install_casks
2023-02-07 22:54:06 +09:00
Mike McQuaid
1a0f62c5dc
Merge pull request #14522 from Rylan12/api-load-booleans
...
Properly load booleans from the API
2023-02-06 16:06:15 +01:00
Rylan Polster
48f4769155
Properly load booleans from the API
2023-02-06 15:07:28 +01:00
apainintheneck
36ca7c95e5
Adds logging to cask loader
...
- extend Context to get `debug?` method
- create FromDefaultTapPathLoader to handle
expected loading option
- log cask loader used when --debug
2023-02-05 13:36:26 -08:00
Mike McQuaid
c1b96e7199
Merge pull request #14382 from MikeMcQuaid/deprecate-disable-remove
...
Add deprecations and disables
2023-02-05 17:56:58 +01:00
Rylan Polster
cfde9b82ac
Merge pull request #14509 from Rylan12/missing-caskfile
...
Add error message with instructions for the missing cask file
2023-02-05 16:35:10 +01:00
Rylan Polster
dde44ed37c
Clarify cause of the bug in messaging
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-05 16:10:22 +01:00
Rylan Polster
0229196ac5
Merge pull request #14503 from Rylan12/artifact-json-fix
...
Don't convert boolean and blank values to strings in cask artifacts API
2023-02-05 15:40:14 +01:00
Rylan Polster
0fd1be9a8e
Add error message with instructions for the missing cask file
2023-02-05 15:35:11 +01:00
Rylan Polster
7b550ad8c6
Improve style
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-05 13:06:05 +01:00
Rylan Polster
7dbc33a0df
Cleanup case handling
...
Co-authored-by: Kevin <apainintheneck@gmail.com>
2023-02-05 12:42:31 +01:00
Rylan Polster
5ab7f14d2b
Fix cask not found error when upgrading certain casks
2023-02-05 12:26:22 +01:00
Rylan Polster
a166be9541
Don't convert boolean and blank values to strings in cask artifacts API
2023-02-05 02:58:03 +01:00
Mike McQuaid
59c03cb2a6
Add deprecations and disables
...
Do the usual dance:
- commented `odeprecated` to `odeprecated`
- `odeprecated` to `odisabled`
- `odisabled` removed
2023-02-03 10:48:43 +00:00
Rylan Polster
af9ba41cb0
Merge pull request #14456 from Rylan12/api-language-support
...
Support `languages` when installing from the API
2023-02-03 05:23:55 -05:00
Mike McQuaid
9d6713d023
Merge branch 'master' into api-language-support
2023-02-03 08:36:23 +00:00
apainintheneck
15c1930804
Remove redundant FromAPILoader attempt
...
After 32a0877 this logic has been changed so it's now
always covered by `FromAPILoader.can_load?`.
2023-02-02 18:43:53 -08:00
apainintheneck
2d93cbe13f
Handle merge conflict
2023-02-02 18:40:13 -08:00
apainintheneck
e0ad960025
Load cask from API with fullname
...
This allows homebrew/cask/caskname
to work with the FromAPILoader.
Also, creates new constant to hold the
regex to validate main tap casks.
2023-01-31 19:39:10 -08:00
Mike McQuaid
90b154fdb5
Merge branch 'master' into cask_source_tweaks
2023-01-31 10:50:34 +00:00
Rylan Polster
32a0877cad
Remove CaskSource
API
2023-01-28 02:15:00 -06:00
Rylan Polster
c1fdcbdd0e
Support languages
when installing from the API
2023-01-28 01:42:19 -06:00
Rylan Polster
0f79b24203
Add languages
to cask API
2023-01-28 01:05:54 -06:00
Mike McQuaid
fd18c7b0ac
Tweak cask-source API handling
...
- Use raw.githubusercontent.com to download cask source rather than
formulae.brew.sh. This allows us to remove these files
- output the tap's current `HEAD` for both formulae and cask JSON
- use this `HEAD` for the cask-source API to get the exact file on
raw.githubusercontent.com rather than just whatever is newest (which
is what the previous API did)
- set the `Tap` correctly when creating a `Cask` from the API
- if the `formula.json` file exists: print its modified time include
`brew config`
- memoize `tap.git_head` as we'll be calling it a lot in the same
process with the same value
2023-01-26 17:36:40 +00:00
Mike McQuaid
61d6f7c4ca
cask/artifact/stage_only: allow string argument.
...
This is what's passed from the JSON API.
2023-01-26 11:22:18 +00:00
Mike McQuaid
b4510401bd
Merge pull request #14423 from MikeMcQuaid/cask_loader_api_gsubs
...
cask_loader: fixup artifacts/caveats from JSON API.
2023-01-25 15:41:56 +00:00
Mike McQuaid
ab1fbb7fa9
cask_loader: fixup artifacts/caveats from JSON API.
...
These are mapped to generic versions in `cask/cask.rb` so we need to map
them back for them to be correct.
2023-01-25 15:07:44 +00:00
Luca Ongaro
1fc1c82aed
Fix code style and add tests
2023-01-25 00:08:15 +01:00
Luca Ongaro
f5765a73da
Avoid mutating the script argument in place
...
Mutating the argument in place, and in particular deleting the
`:executable` entry, leads to a bug when the same code path leading to
read_script_arguments is invoked twice, like in
https://github.com/Homebrew/homebrew-cask/pull/139749
This commit makes a shallow copy of the argument, so that it can be
safely mutated in the rest of the method.
2023-01-24 23:34:47 +01:00
Alexander Regueiro
b2b7072fbe
Permit multiple uninstall
stanzas in casks (temp)
...
Longer-term solution is described [here](https://github.com/Homebrew/brew/issues/14365#issuecomment-1398214354 ).
2023-01-21 18:45:58 +00:00
Mike McQuaid
1588f6cc56
Merge pull request #13356 from SMillerDev/feature/influx_analytics
...
analytics: optionally duplicate to InfluxDB
2023-01-20 15:19:44 +00:00
Mike McQuaid
1adc2c096b
Merge pull request #14370 from Kentzo/fix-cask-lowpriv-sudo
...
cask: don't assume that sudo has write access to the caskroom
2023-01-20 10:57:35 +00:00
Sean Molenaar
59ebdab2b7
analytics: switch to InfluxDB for logging
2023-01-19 18:15:27 +01:00
Mike McQuaid
344d32bf7f
Merge pull request #14368 from Kentzo/fix-cask-backup
...
cask: fix writability check backing up an artifact
2023-01-19 09:58:03 +00:00
Ilya Kulakov
618700a95c
cask: don't assume that sudo has write access to the caskroom
2023-01-13 18:10:21 -08:00
Ilya Kulakov
085bd8ddd1
cask: don't attempt to make a directory that already exists.
2023-01-13 16:15:31 -08:00
Ilya Kulakov
3d16112b14
cask: fix writability check backing up an artifact
2023-01-13 15:30:14 -08:00
Mike McQuaid
9dbd76fced
Merge pull request #14350 from Rylan12/fix-depends-on-arch
...
Fix `depends_on arch:` when loading casks from API
2023-01-11 19:24:55 +00:00
Rylan Polster
4c8c547027
Add clarifying comment
2023-01-11 13:16:34 -05:00
Douglas Eichelberger
9958ab3ecf
Make Cask::DSL::Container#pairs a derived property
2023-01-11 09:04:09 -08:00
Rylan Polster
6468897458
Fix depends_on arch:
when loading casks from API
2023-01-10 12:35:39 -05:00
Rylan Polster
3c4f60c604
Create metadata subdirectory when needed
2023-01-08 02:45:56 -05:00
Mike McQuaid
20a200bdb7
cask/installer: ensure config_path exists.
...
I encountered this when installing `microsoft-edge`.
Perhaps `HOMEBREW_INSTALL_FROM_API` related.
2023-01-07 19:44:44 +00:00
Rylan Polster
ec8adb617e
Use cask-source API when needed
2023-01-06 02:46:22 -05:00
Rylan Polster
ffc74a51fb
Load *flight
blocks from API
2023-01-06 02:46:22 -05:00
Rylan Polster
374b61584b
Load casks from the JSON API with HOMEBREW_INSTALL_FROM_API
2023-01-06 02:46:21 -05:00
Mike McQuaid
37be5bea52
dev-cmd/edit: handle editing with install_from_api
.
...
Before this change, this would fail every time, even when available on
disk (which was not the case for formulae).
With this change, it will attempt to find it from a tap on disk and only
fail if it cannot be found in any.
2023-01-04 13:51:21 +00:00