2100 Commits

Author SHA1 Message Date
Josh Hagins
4ed51d8240 hbc/auditor: refactor and fix bug
Use instance methods to DRY things up, and fix a bug discovered in
caskroom/homebrew-cask#26067 where Casks with language blocks would
always fail audit.
2016-10-24 04:27:21 -04:00
Josh Hagins
b481ed73a0 Merge pull request #1252 from niw/fix_cask_command_changes_entire_directory_ownership
FIX: cask changes /usr/local ownership recursively
2016-10-24 01:21:08 -04:00
Josh Hagins
606a762344 Merge pull request #1248 from Git-Jiro/add_reinstall_cmd_to_cask
add cask reinstall command
2016-10-24 01:11:48 -04:00
Josh Hagins
44f1354d63 hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants
2016-10-23 21:48:11 -04:00
Josh Hagins
512a0c950e Merge pull request #1355 from reitermarkus/fix-depends-on-test
Fix locally failing `depends_on` test.
2016-10-23 21:42:48 -04:00
Josh Hagins
5d1412aba1 Merge pull request #1357 from reitermarkus/refactor-accessibility-test
Refactor accessibility test.
2016-10-23 21:41:35 -04:00
Josh Hagins
fcaa042736 Merge pull request #1358 from reitermarkus/refactor-audit-test
Refactor Audit test.
2016-10-23 21:40:54 -04:00
Josh Hagins
b59eade6c5 Merge pull request #1359 from reitermarkus/refactor-dsl-test
Refactor DSL test.
2016-10-23 21:40:06 -04:00
Josh Hagins
49155cce4d Merge pull request #1360 from reitermarkus/refactor-installer-test
Refactor Installer test.
2016-10-23 21:38:39 -04:00
Markus Reiter
4a9b48e9a6 Refactor Installer test. 2016-10-24 00:13:48 +02:00
Markus Reiter
7395c049dd Refactor Audit test. 2016-10-23 23:52:42 +02:00
Markus Reiter
bbc601c3fd Refactor DSL test. 2016-10-23 23:52:14 +02:00
Markus Reiter
b8ec62bf25 Refactor accessibility test. 2016-10-23 23:45:10 +02:00
Markus Reiter
1bcaad6f3f Update Gemfile dependencies. 2016-10-23 23:22:39 +02:00
Markus Reiter
c7a535de22 Refactor Hbc::UrlChecker test. 2016-10-23 22:58:01 +02:00
Markus Reiter
7cae29d3d7 Fix locally failing depends_on test. 2016-10-23 21:22:38 +02:00
Martin Schimandl
95d4a25891 Fix linting errors 2016-10-23 20:39:53 +02:00
Markus Reiter
ddcab26a35 Use proper path to caskroom/cask tap in test_helper. 2016-10-23 19:07:45 +02:00
Eitot
0b176f9cc8 Add dictionary artifact 2016-10-23 17:43:06 +02:00
Markus Reiter
cb8af6d751 Fix failing test caused by repo_info. 2016-10-23 17:07:29 +02:00
Markus Reiter
8d15bddedb Auto-correct block delimiters. 2016-10-23 14:44:14 +02:00
Markus Reiter
827b48912a Avoid empty rescue. 2016-10-23 14:32:46 +02:00
Markus Reiter
8c488de3f6 Remove unnecessary string interpolation. 2016-10-23 14:32:34 +02:00
Markus Reiter
15b858ccc4 Use double quotes. 2016-10-23 14:32:27 +02:00
Markus Reiter
783dbcc937 Use short-style lambdas. 2016-10-23 14:32:15 +02:00
Markus Reiter
ceec5a82c1 Use guard clauses. 2016-10-23 14:32:04 +02:00
Markus Reiter
9f513cc60c Remove redundant selfs. 2016-10-23 14:32:04 +02:00
Markus Reiter
ad8ae33c1f Fix spacing and indentation. 2016-10-23 14:32:04 +02:00
Markus Reiter
2b7e6c1dcb Don’t use %i literal. 2016-10-23 14:32:04 +02:00
Markus Reiter
ae7b944238 Align end with beginning of line where if/unless is. 2016-10-23 14:32:03 +02:00
Markus Reiter
8e9eae695a Use () as delimiters for %Q and %q literals. 2016-10-23 14:32:03 +02:00
Markus Reiter
1a0f8b8a02 Use slash-delimited regular expressions. 2016-10-23 14:32:03 +02:00
Markus Reiter
40b7e36746 Use 0-only prefix for octal numbers. 2016-10-23 14:13:16 +02:00
Markus Reiter
13e3272e37 Remove Cask’s RuboCop configuration. 2016-10-23 14:13:16 +02:00
Markus Reiter
364adff35c Bring spec_helper in line with test_helper. 2016-10-23 14:13:16 +02:00
Markus Reiter
e51accecfd Remove test_cask, fake_fetcher, and fake_response_for methods. 2016-10-23 14:13:16 +02:00
Markus Reiter
622cac47ae Use test/lib/config for tests. 2016-10-23 14:13:16 +02:00
Martin Schimandl
31fb996800 Remove unncessary semicolon 2016-10-23 09:57:28 +02:00
Josh Hagins
5b421b93c9 Merge pull request #1329 from jawshooah/cask/cleanup-tests
cask/test: DRY up tests and remove redundant helper
2016-10-20 14:56:11 -04:00
Martin Schimandl
8f8606b8c8 Fix code coverage issue by introducing shutup blocks 2016-10-20 19:45:18 +02:00
Markus Reiter
2b049006fa Merge pull request #1330 from reitermarkus/spec-helper
Refactor `spec_helper`.
2016-10-20 09:07:03 +02:00
Josh Hagins
fab6cc5b07 cask/test: remove compliance_test 2016-10-19 22:15:18 -04:00
Josh Hagins
cba0d069cc cask/test: DRY up tests and remove redundant helper 2016-10-19 22:15:18 -04:00
Josh Hagins
3bc2c2d087 hbc/cli/list: don't print empty line if nothing to list 2016-10-19 22:15:03 -04:00
Josh Hagins
32f2231cdf hbc/cli/list: don't require Caskroom to be initialized 2016-10-19 22:15:03 -04:00
Josh Hagins
f79cb2ba30 Merge pull request #1325 from vin047/numbered-usernames
fix 'cask info' for external repos with numbers
2016-10-19 20:44:55 -04:00
Markus Reiter
95c93263e6 Refactor spec_helper. 2016-10-20 00:01:39 +02:00
Markus Reiter
f04a1b59aa Require spec_helper globally. 2016-10-19 22:27:14 +02:00
Markus Reiter
fb29a31c72 Merge pull request #1320 from reitermarkus/which-lsar
Also use `which` to find `lsar` in PATH.
2016-10-19 22:01:06 +02:00
Yoshimasa Niwa
60c4328a17 Use Ruby 2.x style for named arguments. 2016-10-19 11:14:30 -07:00