13759 Commits

Author SHA1 Message Date
Mike McQuaid
2d18ba586b Enable more deprecations.
It's been long enough that these have been commented out so let's
enable them globally.
2017-07-21 10:50:07 +01:00
Mike McQuaid
e0560ff363 Merge pull request #2919 from baughj/add-check-for-build-from-source
Add check for build from source
2017-07-21 09:06:50 +01:00
Mike McQuaid
bd06a7926c diagnostic: use ENV[] 2017-07-20 20:02:34 +01:00
Justin Baugh
2899132e52 Update FAQ to indicate HOMEBREW_BUILD_FROM_SOURCE can still be set 2017-07-20 14:46:35 -04:00
Justin Baugh
0a9de6b8a6 Update source check to match style 2017-07-20 14:44:20 -04:00
Justin Baugh
e077bfe655 Address rubocop issues 2017-07-20 11:57:43 -04:00
Justin Baugh
dd334a8357 Add updated diagnostic test for build from source check. 2017-07-20 11:18:16 -04:00
Justin Baugh
7504d830cb Add warning to doctor if HOMEBREW_BUILD_FROM_SOURCE is set. 2017-07-20 11:08:53 -04:00
ilovezfs
997260da54 Merge pull request #2917 from ilovezfs/python-libexec-bin
python_requirement: prefer Homebrew's Python
2017-07-20 04:26:20 -07:00
ilovezfs
4fb7626ce5 python_requirement: prefer Homebrew's Python
This avoids linkage to both system Python and Homebrew's python.
2017-07-20 02:54:04 -07:00
Mike McQuaid
e715649354 Merge pull request #2913 from jonchang/patch-1
docs: fix fallback fonts
2017-07-20 09:01:04 +01:00
Jonathan Chang
7a8c674ceb docs: fix fallback fonts 2017-07-19 18:53:17 -07:00
Mike McQuaid
f2c2964cf7 Merge pull request #2912 from jonchang/python-shadowing-docs
docs: update for unshadowed system Python
2017-07-19 07:55:46 +01:00
Jonathan Chang
fceb788b98 docs: update for unshadowed system Python 2017-07-18 15:40:07 -07:00
Misty De Meo
f8300b2cb7 Merge pull request #2883 from mistydemeo/allow_passing_hash_to_system
Allow passing hash to system
2017-07-18 12:53:54 -07:00
Gautham Goli
086e540231 Add a rubocop config file to control cops' execution in audit and style 2017-07-18 20:23:03 +05:30
Mike McQuaid
c6f8887deb New-Maintainer-Checklist: use new mailing list. 2017-07-18 11:35:14 +01:00
Mike McQuaid
27cd396d2e travis.yml: remove vendor/bundle cache.
To match https://github.com/Homebrew/homebrew-test-bot/pull/112.
2017-07-16 17:30:56 +01:00
Misty De Meo
32b7e32856
formula: use env helper 2017-07-15 17:41:17 -07:00
Misty De Meo
8e645dfbec
build: use with_env helper 2017-07-15 17:40:55 -07:00
Misty De Meo
610af15f0e
run_as_not_developer: use with_env helper 2017-07-15 17:40:35 -07:00
Misty De Meo
890788af65
FileUtils.make: don't bypass superenv 2017-07-15 17:40:21 -07:00
Misty De Meo
30adcab6cf
Add with_env helper to set temporary ENV vars 2017-07-15 17:39:55 -07:00
Gautham Goli
5b3231ea0a style: disable NewFormulaAudit cops' execution by default unless specified 2017-07-15 22:40:26 +05:30
Mike McQuaid
fb90154589 Merge pull request #2897 from MikeMcQuaid/python@2
python_requirement: add libexec/bin to PATH.
2017-07-15 17:27:47 +01:00
Mike McQuaid
207ffd6d4f rubocop: disable NewFormulaAudit/Options.
This is activated on every formula otherwise.
2017-07-15 17:09:35 +01:00
Mike McQuaid
9378e2105d Merge pull request #2895 from zmwangx/docs-mention-homebrew-npm-noob
docs/Node: mention homebrew-npm-noob
2017-07-15 14:08:36 +01:00
Mike McQuaid
ce1b26d58d Merge pull request #2905 from GauthamGoli/audit_option_rubocop_3
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 13:40:45 +01:00
Mike McQuaid
f5cc8daa39 Merge pull request #2900 from MikeMcQuaid/improve-docs
Documentation improvements
2017-07-15 13:39:32 +01:00
Gautham Goli
a8f1b02be9 audit: Port audit_options rules for new formulae to rubocop and add test 2017-07-15 17:35:10 +05:30
Mike McQuaid
4fd8aea015 Documentation improvements
- Document ilovezfs as the official lead maintainer of
 Homebrew/homebrew-core. This is a role he's been doing unofficially
 (and brilliantly) for a while and explicit documentation of power
 structures makes it easier for non-Homebrew-maintainers to understand.
- Document the contents of some of Homebrew's subdirectories for people
  clicking around in the GitHub UI looking to contribute.
- Remove update bug mention from README. Enough time has passed that we
  can remove this disappointment.
2017-07-15 12:57:34 +01:00
JCount
83f61830f6 Merge pull request #2901 from GauthamGoli/audit_option_rubocop_2
audit: Port audit_options strict rules to rubocop and add tests
2017-07-14 23:26:33 -04:00
Gautham Goli
f3923f23ef audit: Port audit_options strict rules to rubocop and add tests 2017-07-14 21:43:16 +05:30
Mike McQuaid
fb310c57b1 sandbox: sandbox all taps by default.
We've been doing this in `brew test-bot`, for our CI and for
homebrew/core long enough that this is a reasonable default that
provides more protection to our users of non-homebrew/core taps.
2017-07-14 17:00:07 +01:00
Mike McQuaid
f08b518481 python_requirement: add libexec/bin to PATH.
This avoids having to fix formulae that use `python` to make them use
`python2`.
2017-07-14 16:58:14 +01:00
Mike McQuaid
20db5470e3 Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-14 15:32:52 +01:00
Zhiming Wang
dfc4c2d462
docs/Node: mention homebrew-npm-noob
homebrew-npm-noob is a formula generator for npm packages.
2017-07-13 20:56:53 -04:00
Mike McQuaid
4ca2efb12d Merge pull request #2876 from VonUniGE/patch-1
Update documentation of brew install syntax to match its actual behav…
2017-07-13 21:22:55 +01:00
Mike McQuaid
7d443e6bfe Merge pull request #2894 from MikeMcQuaid/integration-test-debugging
integration_test: try tests on Gem load failure.
2017-07-13 21:07:36 +01:00
Mike McQuaid
f7c254dc33 Merge pull request #2893 from MikeMcQuaid/unpin-bundler
tests: unpin bundler.
2017-07-13 17:54:00 +01:00
Mike McQuaid
8b63214c2e integration_test: try tests on Gem load failure.
This should help with debugging `Gem::LoadError`s (e.g. for
https://github.com/Homebrew/homebrew-test-bot/pull/111).
2017-07-13 17:25:34 +01:00
Mike McQuaid
ec574c0e7f tests: unpin bundler.
These issues were fixed by https://github.com/Homebrew/brew/pull/2872
and https://github.com/Homebrew/brew/pull/2823.
2017-07-13 17:15:03 +01:00
Mike McQuaid
7c26dfee55 Merge pull request #2892 from MikeMcQuaid/homebrew-version-consistency
brew.sh: always use 7 chars for HOMEBREW_VERSION.
2017-07-13 10:41:03 +01:00
Mathieu Vonlanthen
73c7bc70d1 Run brew man 2017-07-13 11:15:22 +02:00
Mike McQuaid
5709002138 brew.sh: always use 7 chars for HOMEBREW_VERSION.
This avoids inconsistency based on Git versions.
2017-07-13 10:06:30 +01:00
Gautham Goli
222af82401 Read rubocop offenses as const from corresponding class in tests 2017-07-13 12:43:08 +05:30
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
JCount
bff6af772f Merge pull request #2887 from JCount/python_virtualenv_constants-15.1.0-update
python_virtualenv_constants: update virtualenv to 15.1.0
2017-07-12 21:57:24 -04:00
Mike McQuaid
8d7f66e520 Merge pull request #2890 from Homebrew/revert-2877-fix_fileutils_make
Revert "FileUtils.make: don't bypass superenv"
2017-07-12 11:36:10 +01:00
ilovezfs
0d03eef655 Revert "FileUtils.make: don't bypass superenv" 2017-07-12 02:58:01 -07:00