13759 Commits

Author SHA1 Message Date
Reto Kromer
a173b5beea [trifle] missing space 2017-04-22 11:55:11 +02:00
Mike McQuaid
e41f0bf8c8 formula_installer: remove feature flags.
We've been testing the recursive dependency check and allowing unlinked
dependencies in CI for a while with no adverse consequences so enable
them globally now for all users.
2017-04-21 18:27:44 +01:00
Mike McQuaid
69c7a20896 Fix brew edit with environment filtering.
For many people `brew edit` makes use of the `EDITOR` variable to pick a
sensible editor. With environment filtering enabled unless this editor
is found in the default system PATH it'll fall back to e.g. `vim`.

Instead, ensure that we export the original, pre-filtering `PATH` as
`HOMEBREW_PATH` and use that internally to locate the editor. In future
this same approach will likely be used for requirements to be able to
find tools, too, and for other variables which we want to expose to
Homebrew itself but not other build tools.

Note that `HOMEBREW_PATH` is the same as `PATH` when build filtering
hasn't been enabled.
2017-04-21 18:26:12 +01:00
Mike McQuaid
3011cbac34 audit: ensure dependencies don't use options.
Option dependencies are nasty as they cause unnecessary builds from
source.
2017-04-21 18:24:10 +01:00
Mike McQuaid
1775c32210 audit: new formulae should not require patches.
We may under some circumstances accept these anyway but it's better to
nudge people into the right behaviours on local `audit`s.
2017-04-21 18:23:55 +01:00
Mike McQuaid
6e1faf5b88 Merge pull request #2513 from Sharpie/nostalgia
README: Add Charlie to former maintainers.
2017-04-21 18:11:51 +01:00
Markus Reiter
75ceed39e6 Merge pull request #2520 from reitermarkus/pkgutil-plist
Partly revert “Fix `uninstall :pkgutil` leaving empty `.app` directories.”.
2017-04-21 17:37:42 +02:00
Markus Reiter
80e09c8dec Partly revert “Fix uninstall :pkgutil leaving empty .app directories.”. 2017-04-21 16:46:39 +02:00
Markus Reiter
cd110b467d Merge pull request #2512 from commitay/cask-binary
Replace `FileUtils.chmod` with `/bin/chmod` for cask binaries.
2017-04-21 15:24:07 +02:00
Markus Reiter
5c51c4e23b Fix test for chmod +x on binaries. 2017-04-21 14:52:35 +02:00
commitay
13c33f561e Update binary.rb 2017-04-21 14:52:35 +02:00
commitay
7d9513130b Replace FileUtils.chmod with /bin/chmod for cask binaries. [WIP]
Update binary.rb
Update binary.rb
Update binary.rb
2017-04-21 14:52:35 +02:00
Vítor Galvão
cc7376246e Merge pull request #2517 from reitermarkus/fix-select-blocking
Fix `IO#select` blocking.
2017-04-21 13:43:20 +01:00
Markus Reiter
12fe895749 Merge pull request #2516 from Arcank/extraneous-brace
Remove extraneous }
2017-04-21 14:13:09 +02:00
Markus Reiter
cc634b2d50 Set timeout to 10 seconds instead of retrying. 2017-04-21 14:12:16 +02:00
Markus Reiter
1e06d1318e Validate container :type. 2017-04-21 14:07:34 +02:00
Markus Reiter
9e089a7d12 Fix IO#select blocking. 2017-04-21 07:18:46 +02:00
Markus Reiter
1cd125e7e7 Refactor cask metadata directory methods. 2017-04-21 01:28:21 +02:00
Louis Romero
a27a82c196 Remove extraneous } 2017-04-21 00:24:09 +02:00
Mike McQuaid
2be7999878 Merge pull request #2274 from rwhogg/fuse-requirement
Port OsxfuseRequirement to Linux
2017-04-20 17:14:42 +01:00
Charlie Sharpsteen
824462c5c0 README: Add Charlie to former maintainers. 2017-04-20 08:00:14 -07:00
Markus Reiter
67a0a89b10 Merge pull request #2511 from reitermarkus/fix-plist-parser
Fix `plist` parser failing when encoded with ASCII.
2017-04-20 11:57:15 +02:00
Mike McQuaid
29d750df71 Merge pull request #2509 from scpeters/audit_message_swap
audit: fix swapped audit messages
2017-04-20 08:24:38 +01:00
Markus Reiter
a264590201 Merge pull request #2254 from reitermarkus/lowercase-caskroom
Lowercase `caskroom` and add missing Taps.
2017-04-20 05:50:52 +02:00
Markus Reiter
6ce84c4fb8 Add OFFICIAL_CASK_TAPS in official_taps.rb. 2017-04-20 05:22:34 +02:00
Markus Reiter
3c017a7405 Lowercase Caskroom in search. 2017-04-20 05:22:34 +02:00
Markus Reiter
62cc258ba7 Merge pull request #2510 from bfontaine/be-be-be-be
Acceptable-Formulae: reword 'niche stuff'
2017-04-20 05:08:59 +02:00
JCount
7e0eddd5b0 Merge pull request #2508 from JCount/xcode-8.3.2
xcode: 8.3.2 is latest version
2017-04-19 23:07:12 -04:00
Markus Reiter
d251be1eeb Ensure readline_nonblock returns an UTF-8 string. 2017-04-20 04:47:03 +02:00
Markus Reiter
625a950b46 Fix plist parser failing when encoded with ASCII. 2017-04-20 02:41:41 +02:00
JCount
19ed38df24 xcode: 8.3.2 is latest version 2017-04-19 19:06:24 -04:00
Baptiste Fontaine
ca4ccce6ea Acceptable-Formulae: reword 'niche stuff' 2017-04-19 22:27:49 +02:00
Steven Peters
3982d24d8b audit: fix swapped audit messages 2017-04-19 10:59:11 -07:00
Mike McQuaid
b6b98f486e Merge pull request #2502 from MikeMcQuaid/install-no-search-unreadable
install: don't search when formula is unreadable.
2017-04-19 10:39:08 +01:00
Reto Kromer
7e76740172 move before dash version style 2017-04-18 11:41:55 +02:00
Reto Kromer
1e1ae204c2 move before lame-398-1 2017-04-18 11:11:37 +02:00
Joshua McKinney
cb28ab640e Refactor uninstall existing cask 2017-04-18 01:49:54 -07:00
Mike McQuaid
55c02ae774 Merge pull request #2478 from MikeMcQuaid/audit-skip-methods
audit: allow skipping audit methods.
2017-04-18 09:18:55 +01:00
Mike McQuaid
20ad7f9cf6 README: point security to HackerOne. 2017-04-18 09:16:57 +01:00
Mike McQuaid
85af8c71c7 Merge pull request #2481 from MikeMcQuaid/create-github-metadata
create: use GitHub metadata where available.
2017-04-18 08:46:11 +01:00
Mike McQuaid
1330b74416 install: don't search when formula is unreadable.
These formulae are detected as missing but exist in an unreadable form.

Fixes #2485
2017-04-18 08:43:39 +01:00
Mike McQuaid
43253ede65 create: use GitHub metadata where available.
GitHub provides a description and homepage field so let `brew create`
use them where possible. Also, detect GitHub repositories based on
`releases` as well as `archive`s.
2017-04-18 08:22:41 +01:00
Mike McQuaid
3f8722c971 audit: allow skipping audit methods.
Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.
2017-04-18 08:17:26 +01:00
Reto Kromer
0dc6871d22 add test 2017-04-17 18:11:11 +02:00
Mike McQuaid
417f49dd32 Merge pull request #2477 from MikeMcQuaid/audit-more-universal
audit: check for more universal usage.
2017-04-17 15:50:21 +01:00
Mike McQuaid
d90398692c Merge pull request #2475 from MikeMcQuaid/uses-deleted
uses: allow checking deleted formulae.
2017-04-17 15:49:43 +01:00
Mike McQuaid
226c24aea0 Merge pull request #2498 from zmwangx/do-not-search-taps-for-missing-qualified-formula
install: do not search taps when a qualified formula is missing
2017-04-17 15:48:52 +01:00
Mike McQuaid
5a2c91dbc2 uses: allow checking deleted formulae.
This is useful for seeing when formulae are deleted if they are going to
leave behind any formulae that depend on them.

As a result, if there are any formulae returned return a non-zero/failed
exit status.
2017-04-17 15:06:48 +01:00
Mike McQuaid
3b14aa2e90 install: use include instead of regex. 2017-04-17 14:56:04 +01:00
Mike McQuaid
d950573f79 Merge pull request #2501 from MikeMcQuaid/travis-keep-taps
travis.yml: keep taps.
2017-04-17 14:40:02 +01:00