14757 Commits

Author SHA1 Message Date
L. E. Segovia
ed6f2829b1
Cask: check support of quarantine's tools
- In some cases (usually old CLT versions) Swift is available but needs an
extra guard to use the quarantine API.
- xattr's native filesystem recursion is an Apple extension which is
not available in Mojave; so let's use xargs.
- Insert a quarantine support check in brew cask doctor.

Fixes Homebrew/homebrew-cask#51554, and fixes Homebrew/homebrew-cask#51538.
2018-09-04 21:11:29 +00:00
William Woodruff
367629d289
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid
6db4b72200
tap: fix GitHub naming. 2018-09-04 09:58:58 +01:00
Mike McQuaid
9d28502625
Homebrew Cask isn't an independent project. 2018-09-04 09:58:43 +01:00
Mike McQuaid
1ae2326984
Rename Cask::CLI to Cask::Cmd. 2018-09-04 09:56:58 +01:00
Mike McQuaid
1d86d7a7c7
cask: move cask/cli to cask/cmd. 2018-09-04 09:56:57 +01:00
Mike McQuaid
e06f8a8beb
Rename Homebrew-Cask to Homebrew Cask. 2018-09-04 09:56:57 +01:00
Mike McQuaid
90b3a13909
cask: move cask/lib/hbc/* to cask/*.
Fix the load path, requires and some filenames accordingly.
2018-09-04 09:56:57 +01:00
Mike McQuaid
088730c6f1
Revert "Use JSON to marshal errors from children" 2018-09-04 08:37:08 +01:00
Mike McQuaid
9777b2788e
Merge pull request #4810 from MikeMcQuaid/mojave-mmacosx-version-min
super/cc: fix -mmacosx-version-min on Mojave.
2018-09-04 07:57:36 +01:00
Markus Reiter
32ad22395b Remove some #popen_reads. 2018-09-04 05:16:59 +02:00
commitay
11a6413fd0 cleanup: remove cargo_cache 2018-09-04 12:00:57 +10:00
commitay
a5af6e8ef4 formula: set CARGO_HOME to enable cache 2018-09-04 12:00:38 +10:00
William Woodruff
1eec585afe
Merge pull request #4752 from woodruffw/error-pipe
Use JSON to marshal errors from children
2018-09-03 18:59:40 -04:00
William Woodruff
86b9647450
utils: Use JSON to marshal child errors
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.

Additionally, adds tests for the new behavior.
2018-09-03 18:42:59 -04:00
Mike McQuaid
2086e3c9c4
super/cc: fix -mmacosx-version-min on Mojave.
It fails to accept any version < 10.6.
2018-09-03 20:49:01 +01:00
Markus Reiter
89dd608766 Deprecate gpg stanza. 2018-09-03 20:47:52 +02:00
Mike McQuaid
61ace27006
Merge pull request #4805 from Homebrew/dependabot/bundler/Library/Homebrew/test/parallel_tests-2.22.1
Bump parallel_tests from 2.22.0 to 2.22.1 in /Library/Homebrew/test
2018-09-03 17:21:10 +01:00
Mike McQuaid
56453bc8f8
os/mac: note installation docs need bumped too.
I noticed these contain a reference to our supported versions so should
be bumped whenever this version is bumped.
2018-09-03 17:00:02 +01:00
dependabot[bot]
64869a6368
Bump parallel_tests from 2.22.0 to 2.22.1 in /Library/Homebrew/test
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.22.0 to 2.22.1.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.22.0...v2.22.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-03 15:56:52 +00:00
Mike McQuaid
9cd637ac20
formulary: NameError makes formulae unreadable.
And `NoMethodError` is a type of `NameError`.
2018-09-03 15:40:07 +01:00
Mike McQuaid
3b91c5f1ae
Merge pull request #4797 from MikeMcQuaid/rubocop-tweaks
.rubocop: tweak rules.
2018-09-02 21:13:23 +01:00
Mike McQuaid
0aa9dce03c
Revert "Add $LOAD_PATH for RuboCop cops." 2018-09-02 20:49:25 +01:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
0dc2c72693
Merge pull request #4795 from MikeMcQuaid/tests-leaks-prompt
tests: handle file leaks and SVN test prompt.
2018-09-02 18:31:44 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Mike McQuaid
ec9e45a8f0
tests: handle file leaks and SVN test prompt.
- Ignore files that are generated by `brew tests`
- Make the SVN tests work without prompting for GitHub's SSL certificate
2018-09-02 13:43:58 +01:00
Mike McQuaid
c46cecf277
tests: set HOME.
This is the only way to override the user's Git configuration which can
break tests when e.g. `gpg` cannot be found but signing is requested.
2018-09-02 12:56:31 +01:00
Dominyk Tiller
9102c120bb
cleanup: fix go_cache cleanup 2018-09-02 04:27:22 +01:00
Markus Reiter
e377bdb6fe Fix CurlApacheMirrorDownloadStrategy URL resolution. 2018-09-02 03:30:37 +02:00
Markus Reiter
b54682f709 Avoid network call in #initialize. 2018-09-01 16:20:10 +02:00
Markus Reiter
f66ce9ce5d
Merge pull request #4788 from reitermarkus/no-cache-no-migration
Skip migration if cache is empty or doesn’t exist.
2018-09-01 16:17:54 +02:00
Markus Reiter
b954391214 Skip migration if cache is empty or doesn’t exist. 2018-09-01 15:29:17 +02:00
Vítor Galvão
ad66d54143
Merge pull request #4782 from amyspark/fix-quarantine-broken-symlinks
quarantine: do not automatically follow symlinks
2018-09-01 10:41:47 +01:00
Markus Reiter
3d15c7cb75 Only migrate cache files containing --. 2018-09-01 11:04:51 +02:00
Markus Reiter
ae18bdf161 Skip mtime for non-existent symlink. 2018-09-01 06:42:54 +02:00
L. E. Segovia
4c47a4b76d
quarantine: do not automatically follow symlinks
This prevents failure when Casks have broken framework symlinks.
2018-08-31 15:31:00 +00:00
Markus Reiter
f287214699 Just use resolved_path.file?. 2018-08-31 16:51:23 +02:00
Markus Reiter
9b50fd81d7 Move everything into one file. 2018-08-31 16:51:23 +02:00
Markus Reiter
443111896e Share common logic. 2018-08-31 16:51:23 +02:00
Markus Reiter
ccf396887a Add comment about refinement scope. 2018-08-31 16:51:23 +02:00
Markus Reiter
2773ce6156 Don’t clean up symlink target. 2018-08-31 16:51:23 +02:00
Markus Reiter
b63ac557bc Update symlink even if cached_location already exists. 2018-08-31 16:51:23 +02:00
Markus Reiter
9edc355052 Don’t glob for .incomplete downloads. 2018-08-31 16:51:23 +02:00
Markus Reiter
b7847e4657 Don’t migrate symlinks. 2018-08-31 16:51:23 +02:00
Markus Reiter
3988458919 Use real basename for output. 2018-08-31 16:51:23 +02:00
Markus Reiter
516a39f5a4 Move migrations into UpdateMigrator module. 2018-08-31 16:51:23 +02:00
Markus Reiter
fbcaa8c85a Resolve URL to get real file extension. 2018-08-31 16:51:23 +02:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Michka Popoff
6e31c662f5
Merge pull request #4773 from iMichka/o2flag
superenv: Use 02 optimization flag for Linux builds
2018-08-30 11:09:50 +02:00