admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
4,367 Commits 15 Branches 471 Tags
Commit Graph

4367 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike McQuaid
b072da141f audit: don't complain about bottle versions. 
`brew bottle` already complains and this is a niche case.

References Homebrew/homebrew#21374.
 2013-07-28 16:26:16 -07:00
Jack Nagel
325db99a3c RbConfig::CONFIG['bindir'] is already a string 2013-07-28 16:43:22 -05:00
Jack Nagel
366cb87aec search: silence JSON decode errors 
Closes Homebrew/homebrew#21506.
Closes Homebrew/homebrew#21508.
 2013-07-28 15:38:46 -05:00
Jack Nagel
bac6533d5c Set close-on-exec on lock file descriptors 
The formula locks used by the installer and commands like link and
unlink are backed by open files and flock(). The open file descriptors
are thus leaked to any subprocesses. This can result in weird behavior
in programs spawned from formula that do not expect to inherit these
descriptors.

Fix this by setting close-on-exec on the lock file descriptors.

Fixes Homebrew/homebrew#21486.
 2013-07-27 23:57:35 -05:00
Misty De Meo
6242a6d7fa MacOS.locate: search HOMEBREW_PREFIX before xcrun 
Since xcrun doesn't work on CLT-only systems. Querying HOMEBREW_PREFIX
first before xcrun is much faster for that case.
 2013-07-26 23:22:22 -07:00
Jack Nagel
613546a994 Fix expansion of deps with --build-bottle 2013-07-26 15:05:42 -05:00
Jack Nagel
023aff10c7 Adjust logic to properly sort erlang versions 
Fixes Homebrew/homebrew#21417.
 2013-07-24 19:48:21 -05:00
Mike McQuaid
4a2817d826 SUPPORTERS: Add £15, cleanup. 2013-07-23 18:41:00 -07:00
Adam Vandenberg
9608c2bfae audit: add TODO 2013-07-23 10:51:07 -07:00
Jack Nagel
387200cea5 audit: use !~ instead of "not ... =~" 2013-07-23 11:22:16 -05:00
Jack Nagel
be984215c9 audit: fix dep name escaping 2013-07-23 11:22:15 -05:00
Jack Nagel
a3863394c0 audit: escape dep before regexp interpolation 2013-07-22 22:53:43 -05:00
Jack Nagel
3afa9c2ceb audit: fix indentation 2013-07-22 22:53:22 -05:00
Jack Nagel
dd9b317e24 audit: fix broken condition 2013-07-22 22:53:11 -05:00
Jack Nagel
c05275e362 Update comment 2013-07-22 21:49:14 -05:00
Jack Nagel
93af660c7f Handle optional build-time deps correctly 2013-07-22 21:36:11 -05:00
Jack Nagel
fcfc53df33 Check deps of satisfied deps 2013-07-22 21:36:11 -05:00
Jack Nagel
1fb4cd501b Pathname#write: don't check ARGV.force? 
Closes Homebrew/homebrew#21390.
 2013-07-22 21:26:42 -05:00
Phil Smith
9942bcc21e typo 
Closes Homebrew/homebrew#21385.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2013-07-22 11:24:40 -07:00
Jack Nagel
6090b9b2bf Silence warnings 2013-07-22 11:41:47 -05:00
Jack Nagel
e33cdb2f8b Fix python dependency hash equality 
eql? should not depend on the hash value as hash values of uneql objects
can collide, but eql values may only collide for objects that are
actually eql.

Further, python dependencies are uniquely identified by the combination
of the name and imports attributes, so there is no reason to involved
the expensive binary computation for simple equality checks.

Fixes Homebrew/homebrew#20840.
 2013-07-22 11:41:46 -05:00
Jack Nagel
b0138b9c9b Remove redundant reader method 2013-07-22 11:41:46 -05:00
Jack Nagel
9b30fc4afa Map pkginfo versions to actual XQuartz versions 2013-07-22 11:25:12 -05:00
Jack Nagel
34623b4ef1 Fall back on pkgutil when mdls cannot determine XQuartz version 2013-07-22 11:25:11 -05:00
Jack Nagel
d355227036 Separate version detection from accessor 2013-07-22 11:25:11 -05:00
Jack Nagel
1a54e6a449 Extract version_from_pkgutil 2013-07-22 11:25:11 -05:00
Jack Nagel
c325520316 Extract version_from_mdls 2013-07-22 11:25:11 -05:00
Jack Nagel
0b5551ee5b Extract guess_system_version 2013-07-22 11:25:10 -05:00
Jack Nagel
df0d4aa853 Extract bundle_path from XQuartz.version 2013-07-22 11:25:10 -05:00
Jack Nagel
d6ed7fea4a Cache pkgutil results at the source 2013-07-21 20:09:55 -05:00
Jack Nagel
a1e7d7177f Eliminate nested conditional 2013-07-21 16:41:51 -05:00
Jack Nagel
9f2f5c81e9 Extract bundle_path method from Xcode#prefix 2013-07-21 16:41:51 -05:00
Jack Nagel
3807bd220a Existence of directory is implied by existence of executables 2013-07-21 16:41:51 -05:00
Jack Nagel
4adf8f047a Pull another unwieldy condition into a method 2013-07-21 16:41:50 -05:00
Jack Nagel
d9b9b77fa6 Update comment about CLT 
This was worded in a confusing way, and made an assumption about future
OS X versions that we don't know to be true.

Also, it's probably wrong to state that the CLT location is dependent on
the OS X version; surely there will be a newer CLT for 10.8 that gets
installed in the same location as on 10.9. But we don't know any better
yet.
 2013-07-21 16:41:50 -05:00
Jack Nagel
aa2554640d Split up unreadable conditional 2013-07-21 16:41:50 -05:00
Jack Nagel
13df53166a These should be integers 2013-07-21 07:56:30 -05:00
Jack Nagel
5acaa3374b Remove unnecessary use of globals in compiler version methods 2013-07-20 22:40:23 -05:00
Jack Nagel
e23a3492f4 Don't report llvm-gcc if it's actually clang 2013-07-20 22:40:22 -05:00
Jack Nagel
8e0158b4d7 Add String#end_with? 
I'm tired of not remembering if start_with?/end_with? are portable, so
just add them both if they're not defined.
 2013-07-19 22:32:57 -05:00
Jack Nagel
b1e5f5ee81 Fix String#start_with? implementation 
It is supposed to accept a variable number of prefixes, and also to
check if they are convertible to strings. This matches behavior
documented in RubySpec.
 2013-07-19 22:31:07 -05:00
Misty De Meo
988316a16d Enable superenv on Snow Leopard 
This has been tested with several dozen formulae without any
superenv-related issues.
 2013-07-19 14:13:11 -07:00
Samuel John
3fd7da0d80 SUPPORTERS.md fixed some missing http:// 
some links like example.com were not clickable
in some markdown viewers.
 2013-07-19 13:38:01 +02:00
Adam Coffman
753adbb0ce upgrade: put exit statements in both conditional branches 
This check was only occurring in one branch of the conditional.
As a result, if you ran `brew upgrade` with no args and there were no packages to upgrade,
the nonsensical message

"==> Upgrading 0 outdated package, with result:"

would be printed.

Closes Homebrew/homebrew#21316.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-07-18 15:35:17 -05:00
Mike McQuaid
e33d3e1e5c brew-test-bot: only install bottle if created OK. 2013-07-18 09:56:55 -07:00
Mike McQuaid
1a4bea3a55 brew-test-bot: only force fetch with --cleanup. 2013-07-18 09:56:55 -07:00
Mike McQuaid
f3821364a7 Warn more about failing bottle version detection. 
This is needed for local bottle installation and also possible when
detecting bottle versions from URLs.
 2013-07-18 09:56:55 -07:00
Mike McQuaid
4f2725cde3 Move getting formula names from bottles to method. 2013-07-18 09:56:55 -07:00
Mike McQuaid
e3a7260c1a Formula: temporarily set PYTHONPATH. 
Needs a less hacky fix but at least this will stop failing tests.
 2013-07-18 09:56:55 -07:00
Mike McQuaid
810005156e brew-test-bot: add devel/HEAD install options. 2013-07-18 09:56:54 -07:00