admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
32,623 Commits 15 Branches 471 Tags
Commit Graph

337 Commits

Author SHA1 Message Date
Max Eisner
2946752083
extend tests 2022-09-06 14:42:03 +02:00
Max Eisner
7380f58173
extend tests 2022-09-06 14:42:03 +02:00
Max Eisner
3db65e7ee5
move tests to own specs file 2022-09-06 14:42:02 +02:00
Max Eisner
cf84800939
fix style 2022-09-06 14:42:01 +02:00
Max Eisner
4e286ee36d
fix test 2022-09-06 14:42:01 +02:00
Max Eisner
45d1c70559
add test 2022-09-06 14:42:01 +02:00
Rylan Polster
1c54e915b6
Update cask rubocops to use on_arch blocks and sha256 arm:, intel: 2022-08-25 00:49:28 -04:00
Rylan Polster
af99dfba00
Refactor on_system rubocops for use in casks 2022-08-14 17:31:07 -04:00
Rylan Polster
ad7e5ccc44
Add additional test 2022-08-11 19:14:21 -04:00
Rylan Polster
ec132ff851
Add and adjust cask rubocops to handle variables 2022-08-10 17:45:43 -04:00
fn ⌃ ⌥
b5a6f90cd8 Add tests 2022-08-03 06:33:30 -07:00
Rylan Polster
2c3926ae1e
Check nesting for blocks with one child 2022-07-24 23:37:36 +02:00
Rylan Polster
d5d6456b24
Add checks for on_system method 2022-07-24 23:01:56 +02:00
Rylan Polster
7b24ed3b4d
Update OnSystem cop to check other on_{system} methods 2022-07-24 23:01:56 +02:00
Rylan Polster
9b49561066
Update components_order cop to check other on_{system} methods 2022-07-01 10:52:41 -04:00
Mike McQuaid
22d6af1258
Manual brew style fixes. 2022-06-30 08:56:21 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix 2022-06-30 08:56:21 +01:00
Bo Anderson
d0e4af8fb5
test/rubocops/patches: silence CodeQL alert 2022-05-20 01:44:05 +01:00
Carlo Cabrera
f05e57f414
Merge pull request #12823 from carlocab/setuptools-audit 
rubocops/text: remove `setuptools` audit
 2022-02-01 16:57:57 +08:00
Carlo Cabrera
bc67c05528
rubocops/text: remove setuptools audit 
This currently no longer applies, because we might sometimes need an
older `setuptools` than the one shipped with a Python formula.

This is needed for Homebrew/homebrew-core#93964.
 2022-02-01 15:26:50 +08:00
Roland Crosby
d8df9c2ee9 Allow cargo build --lib 
When building Rust packages that provide libraries but no executable
binaries, `cargo install` doesn't do anything; you need to use `cargo
build` and install any libraries manually. See e.g.
rust-lang/cargo#8294.

Unfortunately, Homebrew's Rubocop "use cargo install *std_cargo_args"
rule, as currently written, blocks all invocations of `cargo build`.
This commit changes that rule to exclude invocations of `cargo build`
that use the `--lib` argument (`--lib` specifies to Cargo that a
package's library targets should be built). This will enable library
packages to be built while retaining the "use cargo install
*std_cargo_args" message for the more common case when a Rust package
provides executable binaries.
 2022-01-31 21:11:22 -05:00
Bevan Kay
d371547d5a
fix tests 2022-01-12 10:39:38 +11:00
Bevan Kay
6f62b0e029
add tests 2022-01-11 13:18:06 +11:00
Mike McQuaid
a6e4e195c1
rubocops/lines: recommend on_os/OS.os? based on context. 
Recommend the use of `on_macos` and `on_linux` unless we're in
`def install`, `def post_install` or `test do` in which case recommend
`OS.mac?` and `OS.linux?` instead.
 2021-09-08 13:18:07 +01:00
Mike McQuaid
227a96fd7f
rubocops/lines: remove OS.mac?/OS.linux? check. 
This will be reimplemented in https://github.com/Homebrew/brew/pull/11955
but this allows us to merge the homebrew-core changes before that PR is
merged.

Closes https://github.com/Homebrew/brew/pull/11946
 2021-09-02 13:50:23 +01:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix 2021-07-08 12:36:39 +05:30
Mike McQuaid
321c165bd3
Merge pull request #11350 from Gcenx/audit-fix-xcode-build-check 
audit: Remove SYMROOT
 2021-05-13 13:50:40 +01:00
Dean M Greer
ceeb5ea9ec audit: Remove SYMROOT 
SYMROOT is only a valid argument when -project is used.

xcodebuild has other uses than building Xcode projects.
 2021-05-13 08:07:06 -04:00
Bo Anderson
e5285b5ed8
Add cop for IO.read usage 2021-05-12 13:07:24 +01:00
Bo Anderson
6e2f194e09
rubocops/shell_commands: add cop for shell metacharacters in exec 2021-05-10 16:30:00 +01:00
Rylan Polster
ae89577b26
style: re-enable GitLab patch URL check 2021-04-19 11:19:35 -04:00
Rylan Polster
b5dec5fdbd
style: temporarily disable GitLab patch URL check 2021-04-19 09:13:06 -04:00
Jonathan Chang
ef1e07b88b
rubocops/patches: GitLab patches should use .diff 
Only `.diff` URLs return output comparable to the diffs from
`git diff --full-index`. While the extra metadata from `.patch` is
nice, the instability of the patch contents is undesirable.

Co-Authored-By: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
 2021-04-19 09:08:14 -04:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop 2021-03-17 20:45:41 +00:00
Mike McQuaid
61427d6682
Merge pull request #10770 from SeekingMeaning/unless_logical_operators 
rubocops: use `Style/UnlessLogicalOperators`
 2021-03-05 11:45:42 +00:00
nandahkrishna
d68452f232
rubocops/patches: autocorrect some offenses 2021-03-04 12:36:18 +05:30
Seeker
7e7274aaeb rubocops: use Style/UnlessLogicalOperators 
Replaces `Style/UnlessMultipleConditions`
 2021-03-03 01:39:11 -08:00
Issy Long
e143dfdad6
Merge pull request #10658 from issyl0/rubocop-enable-rspec-context-wording 
rubocop: Enable RSpec/ContextWording cop & fix offenses
 2021-02-23 00:14:02 +00:00
Issy Long
38a427bf0d
test/option_declaration_spec: Align test description with contents 2021-02-20 00:04:05 +00:00
Issy Long
f194b5e983
test/bottle_format_spec: Align test description with contents 2021-02-20 00:03:47 +00:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording offenses 
- For some of these I changed `context` to `describe` as it fit better
  rather than contriving a "when", "with" or "without", or massively
  restructuring the tests.
 2021-02-19 23:30:41 +00:00
Rylan Polster
5f57601fd8
style: re-enable bottle order cop 2021-02-04 17:18:20 -05:00
Carlo Cabrera
2de172e050
rubocops/bottle: disable bottle order check 
This is causing CI failures at homebrew/core [1], so let's disable this
for now.

[1] 01b6830646
 2021-02-04 11:18:09 +00:00
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order 
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
 2021-02-03 20:46:20 -05:00
Rylan Polster
d5d7b6c3db
style: remove RSpec/MultipleDescribes violations 
Co-authored-by: Nanda H Krishna <nanda.harishankar@gmail.com>
 2021-02-01 20:30:51 -05:00
Rylan Polster
3e00b3ea28
style: remove RSpec/ExampleLength violations 2021-02-01 20:30:51 -05:00
Michka Popoff
38ae6e0c0d style: re-enable sha256 checks for bottle blocks 
Follow up PR to #10450
 2021-01-28 20:35:31 +01:00
EricFromCanada
a427de5bee capitalization fixes 
"curl" is the binary, while "cURL" is the umbrella project.
 2021-01-26 15:36:44 -05:00
Seeker
48e44870e6
Merge pull request #10334 from SeekingMeaning/rubocop-spec-descriptions 
rubocops/*: improve test descriptions
 2021-01-17 19:57:54 -08:00
Seeker
32ba87d254
Merge pull request #10332 from SeekingMeaning/text_spec-descriptions 
rubocops/text: improve test descriptions
 2021-01-17 19:57:23 -08:00