Patrick Linnane
4513a43d53
Fix RuboCop failures.
...
Co-authored-by: Patrick Linnane <patrick@linnane.io>
Co-authored-by: Carlo Cabrera <github@carlo.cab>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2025-07-14 19:12:38 +01:00
Issy Long
990c1efc16
bundle: Rename "brews" to "formulae" for consistency
...
- Homebrew Bundle referred to formulae as "brews". But it referred to
casks as "casks" and taps as "taps".
- Let's use the same terminology everywhere.
- (I know that `brew "hello"` is the formula syntax in the Brewfile, so
I'm not changing that (though would be up for it, in a backwards
compatible manner), just making the code more consistent.)
2025-07-04 21:08:37 +01:00
Rylan Polster
f238d3b494
Merge pull request #20151 from Homebrew/fix-doctor-linux
...
Fix `brew doctor` cask handling on Linux
2025-06-22 10:10:28 +00:00
Rylan Polster
431d8f1ff7
Consistently use ClassMethods sub-module for prepending class methods
2025-06-21 21:40:57 -04:00
Rylan Polster
267afac198
Remove more monkey-patching in extend/os
2025-06-21 21:34:20 -04:00
Rylan Polster
508c8b606c
Fix DevelopmentTools::ld64_version on macOS
2025-06-21 21:13:38 -04:00
Rylan Polster
ff79015373
Fix Hardware::CPU::features on macOS
2025-06-21 21:01:44 -04:00
Rylan Polster
e1873d30d4
Run deprecated cask tap check on all systems
2025-06-21 13:59:58 -04:00
Rylan Polster
031160936f
Split out os-specific cask software version checks
2025-06-21 13:59:57 -04:00
Mike McQuaid
9ac306e464
Remove alias generic_* definitions in favour of using super
...
This is the pattern we've been adopting for a while and it's a bit
cleaner. Let's remove all of the existing usage of the existing pattern
to avoid confusion when adopting the new one.
2025-06-16 08:10:08 +00:00
Mike McQuaid
f234423913
dev-cmd/tests: fix require ordering.
...
This needs to happen after `setup_environment!` so that
`HOMEBREW_TEST_GENERIC_OS` is set and `OS.linux?` and `OS.mac?` both
`return false`.
2025-06-12 16:43:50 +01:00
Rylan Polster
ce72e34b19
Filter brew tests spec files appropriately for each OS
2025-06-11 15:59:21 -04:00
Mike McQuaid
dc71b7c8f6
Cleanup extend/ directory usage.
...
- move some things out of `extend` that don't really fit there e.g.
`Module`s that are included but not doing any
overriding/monkeypatching
- move some code into `extend/os` to fix all remaining
`rubocop:todo Homebrew/MoveToExtendOS`s
- remove some unneeded `bundle` skipper code that doesn't really make
sense given our current bottling strategy
- extract some `Pathname` extensions to `extend/pathname` for separate
files
- move a `ENV` `Kernel` extension into `kernel.rb`
- `odeprecate` a seemingly unused backwards compatibility method
- move `readline_nonblock` from a monkeypatch to a
`ReadlineNonblock.read` method as its only used in one place
- fix up a link in documentation
2025-06-09 19:06:16 +01:00
Rylan Polster
73b64390b3
Use existing Utils::Bottles::Collector#specification_for method
2025-06-05 12:38:15 -04:00
Patrick Linnane
2c9b094bea
os/mac/diagnostic: set OCLP Support Tiers
...
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2025-04-12 17:03:54 -07:00
Mike McQuaid
d899f00c4b
Link to Support Tiers in diagnostic/error messages
...
Now that we have this nice URL let's reference it to allow our other
messages to be a bit shorter/kinder.
2025-04-01 11:35:27 +01:00
Douglas Eichelberger
39843b5d40
Resolve violations
2025-03-13 12:16:11 -07:00
Sean Molenaar
ab2b18f78c
feat: add os_version for casks
2025-03-05 20:12:18 +01:00
botantony
68f8798821
zig std args: apply -fno-rosetta on macs with arm
2025-02-21 19:10:41 +01:00
botantony
c5d78f3347
zig std args: use symbols for compilation options
2025-02-21 17:07:29 +01:00
botantony
bfdfdc9489
-fno-rosetta flag
2025-02-21 16:49:11 +01:00
Douglas Eichelberger
8763fb6d29
Resolve rubocop violations
2025-02-17 18:56:31 -08:00
Sean Molenaar
27a2d94c48
feat: allow zap on linux
2025-02-17 14:30:44 +01:00
Sean Molenaar
975fe8a83f
feat: allow cask binaries on linux
2025-02-17 14:30:43 +01:00
Sean Molenaar
c34b71655c
feat: allow font install on linux
...
Apply suggestions from code review
Co-authored-by: Douglas Eichelberger <697964+dduugg@users.noreply.github.com>
feat: add linux appdir
Apply suggestions from code review
Co-authored-by: Douglas Eichelberger <697964+dduugg@users.noreply.github.com>
2025-01-19 11:14:24 +01:00
Issy Long
6ada9a9665
Add clarifying comments to rubocop:disables
...
- Needed for PR 18842 that adds a `DisableComment` RuboCop to ensure that all RuboCop disables have comments.
2025-01-12 16:59:07 +00:00
Ruoyu Zhong
64edbe6b79
os/mac/hardware/cpu: add M4 Pro/Max
...
Sources:
- https://github.com/AsahiLinux/docs/wiki/Codenames
- MacOSX15.2.sdk from Xcode 15.2 RC
2024-12-06 16:06:09 +08:00
Kiracus
c7b49d5cad
cpu.rb: add Apple M4
2024-11-16 09:28:44 -08:00
Eric Knibbe
e52943d8d6
os/mac/diagnostic: fix case of OpenCore check
2024-11-13 12:23:34 -05:00
Ruoyu Zhong
d0418add45
os/mac/diagnostic: improve OpenCore check
...
This is based on [1].
[1]: https://github.com/Homebrew/brew/pull/18765#issuecomment-2474056438
2024-11-14 00:55:49 +08:00
Ruoyu Zhong
a525ce0ad8
Apply suggestions from code review
...
Co-authored-by: Eric Knibbe <enk3@outlook.com>
2024-11-13 23:43:24 +08:00
Ruoyu Zhong
13265ca170
os/mac/diagnostic: skip OpenCore check in CI
2024-11-13 23:11:16 +08:00
Ruoyu Zhong
dee399c27d
os/mac/diagnostic: display OpenCore version
2024-11-13 23:01:29 +08:00
Ruoyu Zhong
854fc16889
os/mac/diagnostic: fix OpenCore check
...
Fixes #18763 .
2024-11-13 22:48:51 +08:00
Carlo Cabrera
2c20e3b8de
os/mac/diagnostic: check for OpenCore
...
This configuration is not supported. Let's make `brew doctor` complain
about it.
2024-11-13 09:43:16 +08:00
Bo Anderson
b34e6ee20e
Merge pull request #18638 from Homebrew/keg_relocate-type-fix
...
keg_relocate: fix error when dylib_id doesn't need changing
2024-10-26 06:45:57 +01:00
Bo Anderson
28f19878e3
keg_relocate: fix error when dylib_id doesn't need changing
2024-10-26 06:31:05 +01:00
Bo Anderson
529eadd6cc
os/mac/keg_relocate: don't change Swift stdlib dylib IDs
2024-10-25 20:55:21 +01:00
Douglas Eichelberger
ed4129b580
Remove removable constants
2024-10-07 19:45:48 -07:00
Douglas Eichelberger
8033fcf4a6
Fix brew style docs
2024-10-07 18:59:27 -07:00
Douglas Eichelberger
2d16333bbc
Replace removable constants with overridable methods
2024-10-07 18:33:03 -07:00
Douglas Eichelberger
d3d25beb35
Use requires_ancestor consistently
2024-10-06 09:25:57 -07:00
Douglas Eichelberger
0855d7c9e0
Revert ENV changes
2024-10-05 12:35:28 -07:00
Douglas Eichelberger
f4a6dce64a
Fix ENV
2024-10-05 12:18:29 -07:00
Douglas Eichelberger
0d5b56aa6a
Fix tests
2024-10-05 12:18:29 -07:00
Douglas Eichelberger
eed660e784
Move remaining OS extensions to prepend
2024-10-05 12:18:29 -07:00
Bo Anderson
567f5eb4be
Allow sockets to use longer paths on macOS
2024-09-27 04:37:03 +01:00
Mike McQuaid
eab322946a
formula: fix alias/generic/prepend std_cmake_args issue.
...
Seen in:
https://github.com/Homebrew/homebrew-core/pull/191090#issuecomment-2363215204
There's a missing signature issue here due to the `generic_*` aliasing
we're doing. With prepend, though: this is no longer needed and we can
use `super` instead which is more idiomatic and nicer overall.
This pattern should probably be applied in other places but: let's try
this targetting fix for here first.
2024-09-20 13:01:42 +01:00
Douglas Eichelberger
125ced9cf8
Fix formatting
2024-09-19 10:58:53 -07:00
Douglas Eichelberger
61985bc7f3
Use top-level OS instead
2024-09-19 10:58:53 -07:00
