admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
20,687 Commits 15 Branches 471 Tags
Commit Graph

20687 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike McQuaid
0caa0718f5
Merge pull request #7331 from Bo98/pc-cflags 
os/mac/pkgconfig: delete most cflags on 10.14+
 2020-04-12 13:18:12 +01:00
Mike McQuaid
7f32e23a65
cmd/link: don't link shadowed macOS software. 2020-04-12 13:12:03 +01:00
Mike McQuaid
373650d00d
KegOnlyReason: add reason helpers, rename valid. 2020-04-12 13:12:02 +01:00
hyuraku
5578845e3f repair regex condition 2020-04-12 20:23:43 +09:00
Issy Long
c8867e5352
Merge pull request #7327 from issyl0/pull-deprecate-bottle 
pull: Deprecate `--bottle` flag
 2020-04-12 11:41:37 +01:00
Issy Long
3e2f183c60
pull: Remove --bottle flag 
- Muscle memory is a thing, as is relying heavily on one's shell
  history. Now that the Jenkins runners are gone, `brew pull --bottle`
  no longer works. This removes the option. If maintainers are confused,
  they should [look at recent changes to the
  docs](https://docs.brew.sh/Brew-Test-Bot-For-Core-Contributors#bottling),
  or ask in Slack.
- An earlier iteration of this showed a deprecation warning and a link
  to the docs, but when an option no longer physically works it's a bit
  late for deprecation *warnings*.
- This also fixes a `brew style` warning from futher up in the file.

pull: Appease RuboCop
 2020-04-12 11:24:22 +01:00
Dawid Dziurla
08309749d4
pr-*: only unique named args 
also tweak usage to show that the commands accept multiple arguments
 2020-04-12 12:13:53 +02:00
Jonathan Chang
56090cc03a
Merge pull request #7311 from jonchang/tap-shallow 
tap: permit creating shallow taps
 2020-04-12 15:20:13 +10:00
Bo Anderson
d8b1c4ff1f os/mac/pkgconfig: delete most cflags on 10.14+ 2020-04-12 00:42:18 +01:00
Markus Reiter
850a84ea1c
Merge pull request #7296 from reitermarkus/cask-commands 
Refactor cask command parsing logic.
 2020-04-11 17:21:58 +02:00
Gautham G
2bdbca1280 Revert "Merge pull request #7289 from Homebrew/revert-7279-argv-cleanup-18" 
This reverts commit 64fd839c955b3c32855067d26fed7daf65183877, reversing
changes made to 6f50801b37b7d829afc37da76d2ef0a1ac1c9f5f.
 2020-04-11 18:50:24 +05:30
Jonathan Chang
bec303de86
tap: update shallowing logic 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2020-04-11 22:41:04 +10:00
Jonathan Chang
c45116ebbc
Merge pull request #7326 from jonchang/pr-pull-dont-try-to-fetch-artifacts-when-not-needed 
pr-pull: don't try to fetch artifacts for a pull request when the changed formulae don't use bottles
 2020-04-11 22:40:24 +10:00
Jonathan Chang
cdd609357f
Merge pull request #7325 from jonchang/new-pr-pull-docs 
docs: Update for new pr-* workflows
 2020-04-11 22:31:54 +10:00
Mike McQuaid
0eff14db55
Merge pull request #7323 from Bo98/std-pc 
Revert "ENV/std: withdraw support for Homebrew supplied *.pc files"
 2020-04-11 13:12:58 +01:00
Mike McQuaid
73df5891ef
Merge pull request #7283 from claui/fix-make-tmpfile 
Ensure TMPDIR is set for Xcode’s `make`
 2020-04-11 13:11:30 +01:00
Jonathan Chang
e2507968da docs: remove old Jenkins assets 2020-04-11 20:06:32 +10:00
Jonathan Chang
cf63925005 docs: Update for new pr-* workflows 2020-04-11 20:06:31 +10:00
Jonathan Chang
f575eecabc pr-pull: don't try to fetch unneeded artifacts 2020-04-11 19:37:43 +10:00
Jonathan Chang
e974dce16e pr-pull: don't pass dry_run everywhere 2020-04-11 19:26:32 +10:00
Claudia
29538c89cd
Set TMPDIR for Xcode’s make 
This fixes an issue where at least in Xcode 11.0, `make` uses
`/var/tmp` as a fallback for temporary files unless `TMPDIR` is set:

```
$ strings "$(xcrun -f make)" | grep -B 3 fopen
TMPDIR
/var/tmp/
GmXXXXXX
fopen (temporary file)
```

Given that Homebrew filtered `TMPDIR`, and the `/var/tmp` directory may
not be writable for non-root users, this would cause Homebrew’s
build environment to error out:

```
$ brew ruby -e 'puts ENV["TMPDIR"]; puts `: | make -f -`'
```

```
Ignoring bigdecimal-2.0.0 because its extensions are not built. Try: gem pristine bigdecimal --version 2.0.0
[…]
Ignoring zlib-1.1.0 because its extensions are not built. Try: gem pristine zlib --version 1.1.0
make: *** fopen (temporary file): Permission denied.  Stop.
```

In practice, this would break `brew audit`, `brew style`, and other
commands, which would run `make` to build native gem extensions.

This commit sets `TMPDIR` to `${HOMEBREW_TEMP}` in the gem environment, which
mirrors the behaviour we already have in other places.
We choose `HOMEBREW_TEMP` because that’s user-controlled but also falls
back to `/tmp` in case `TMPDIR` is not set in the user’s environment.

Thanks to Bo Anderson for helping find the bug.

CC: Bo Anderson <mail@boanderson.me>
 2020-04-11 08:01:05 +02:00
Jonathan Chang
945fb11d51 tap: default to --shallow on CI 2020-04-11 13:12:09 +10:00
Markus Reiter
30c313b7b9 Refactor cask command parsing logic. 2020-04-11 01:29:44 +02:00
Bo Anderson
8900e852d6 Revert "ENV/std: withdraw support for Homebrew supplied *.pc files" 
This reverts commit fa3591681800f9da06cd2d0179a5ef9e63b10729.
 2020-04-10 21:47:54 +01:00
Markus Reiter
5b775afedd
Merge pull request #7322 from reitermarkus/spec-helper 
Improve spec helper.
 2020-04-10 20:44:06 +02:00
Bo Anderson
2c7908a979
Merge pull request #7321 from Bo98/pkg_config 
ENV/super: don't set PKG_CONFIG
 2020-04-10 19:26:03 +01:00
Markus Reiter
a6be0e62af Improve spec helper. 2020-04-10 19:39:43 +02:00
Bo Anderson
e8e6592701 ENV/super: don't set PKG_CONFIG 2020-04-10 18:36:18 +01:00
Jonathan Chang
740e0242fa
Merge pull request #7312 from jonchang/environment-working 
env_config: standardize wording, fix some typos
 2020-04-10 01:52:00 +10:00
Alexander Bayandin
7a4c1cc8ac bump-revision: fix handling formula with stable block 2020-04-09 16:12:14 +01:00
Mike McQuaid
f6348f59a1
Merge pull request #7313 from MikeMcQuaid/xcode-clt-latest 
os/mac/xcode: better document upgrade.
 2020-04-09 15:00:16 +01:00
Mike McQuaid
c3dc8862c1
os/mac/xcode: better document upgrade. 
Explain when these various versions should (and should not) be bumped
and provide a method to avoid people having to schlep through the Apple
Developer site unless they really want to.

Also, while we're here, DRY things up and reorder to "newest first".
 2020-04-09 14:27:39 +01:00
Jonathan Chang
bf66c8800e manpages: update for environment changes 2020-04-09 22:45:43 +10:00
Jonathan Chang
620dae3680 env_config: standardize and correct wording 2020-04-09 22:45:43 +10:00
Mike McQuaid
c382dbc94f
Merge pull request #7310 from Homebrew/revert-7275-github_token 
Revert "Set HOMEBREW_GITHUB_API_TOKEN from GITHUB_TOKEN."
 2020-04-09 09:59:36 +01:00
Jonathan Chang
2acb4771fe tap: permit creating shallow taps for CI 2020-04-09 18:46:47 +10:00
Mike McQuaid
147294b1ed
Revert "Set HOMEBREW_GITHUB_API_TOKEN from GITHUB_TOKEN." 2020-04-09 09:29:50 +01:00
Mike McQuaid
3146258b60
Merge pull request #7307 from Bo98/make_jobs 
ENV/std: restore original make_jobs return type
 2020-04-09 08:45:41 +01:00
Dawid Dziurla
2a424ff982
Merge pull request #7308 from Bo98/pr-publish 
dev-cmd/pr-publish: fix undefined method error on invalid input
 2020-04-09 07:12:05 +02:00
Bo Anderson
7787dde7b7 dev-cmd/pr-publish: fix undefined method error on invalid input 2020-04-09 01:36:49 +01:00
Bo Anderson
757cc24f7e ENV/std: restore original make_jobs return type 2020-04-08 20:31:04 +01:00
Mike McQuaid
105aae4d04
Merge pull request #7306 from Homebrew/SMillerDev-patch-1 
Audit: allow make check for nettle
 2020-04-08 19:19:51 +01:00
Sean Molenaar
84181f2068
Audit: allow make check for nettle 2020-04-08 19:08:15 +02:00
Mike McQuaid
ddda67bba2
Merge pull request #7304 from Moisan/bottle_unneeded_doc 
docs/Formula-Cookbook.md: mention the use of 'bottle :unneeded'
 2020-04-08 16:07:20 +01:00
Mike McQuaid
ba63e93b9a
Merge pull request #7303 from Bo98/xcrun 
shims/mac/super/xcrun: unset rather than emptying DEVELOPER_DIR
 2020-04-08 14:46:46 +01:00
Thierry Moisan
967a2d2687
Update docs/Formula-Cookbook.md 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2020-04-08 09:21:38 -04:00
Thierry Moisan
a245eea674
docs/Formula-Cookbook.md: mention the use of 'bottle :unneeded' 2020-04-08 09:14:45 -04:00
Bo Anderson
8f12a34ce0 shims/mac/super/xcrun: unset rather than emptying DEVELOPER_DIR 2020-04-08 09:32:29 +01:00
Bo Anderson
2ae26808a6
Merge pull request #7301 from Bo98/cmake-sdkroot 
formula: make CMake SDK root choice consistent with superenv (+ SDK root refactoring)
2.2.12 		2020-04-07 19:22:04 +01:00
Bo Anderson
811b177cf8 formula: make CMake SDK root choice consistent with superenv 2020-04-07 17:22:16 +01:00