6622 Commits

Author SHA1 Message Date
Jack Nagel
a6c514024b Flesh out linking tests 2014-07-01 09:01:06 -05:00
Jack Nagel
c2228c0d0f Remove default argument from make_relative_symlink
All callers of this method now pass a mode object.
2014-06-30 22:14:18 -05:00
Jack Nagel
4ea3997d9c Pass the mode through the optlink method 2014-06-30 22:14:09 -05:00
Jack Nagel
548d66be59 Simplify optlink method
delete/unlink on a directory is the same operation as rmdir.
2014-06-30 22:14:07 -05:00
Jack Nagel
c0baad7e68 Add tests around opt links 2014-06-30 22:14:06 -05:00
Jack Nagel
a3958c6d8b Use formula opt shortcuts 2014-06-30 20:31:14 -05:00
Jack Nagel
d792b64655 Add methods for manipulating the opt record 2014-06-30 20:31:13 -05:00
Jack Nagel
0744ed9410 Store the opt record so we don't have to keep reconstructing it 2014-06-30 20:30:50 -05:00
Jack Nagel
30e273c2d1 Group methods that operate on the linked keg record 2014-06-30 20:30:02 -05:00
Jack Nagel
4c05d411f3 Add a method for getting the repo HEAD 2014-06-30 19:18:28 -05:00
Jack Nagel
c904c71792 Fix tab tests 2014-06-30 08:54:47 -05:00
Jack Nagel
a60ea13c64 Use 1.8 has syntax
Fixes Homebrew/homebrew#30558.
2014-06-30 01:03:11 -05:00
Jack Nagel
d083efdbda Don't mutate the tab object 2014-06-29 23:18:09 -05:00
Jack Nagel
ac687d3b5f Remove explicit self 2014-06-29 22:26:15 -05:00
Jack Nagel
07171f5527 Test that the tab round-trips through JSON 2014-06-29 22:18:44 -05:00
Jack Nagel
cd91709120 Fix typo in tab test setup
This is one of the many problems with using OpenStruct.
2014-06-29 22:18:44 -05:00
Jack Nagel
391bc4c981 Normalize paths before calling Tab.from_file 2014-06-29 21:50:08 -05:00
Jack Nagel
4d11def53c Add tests documenting install receipt loading behavior 2014-06-29 21:49:34 -05:00
Jack Nagel
34db1bd1ef Remove test that is now covered by tab tests 2014-06-29 19:27:28 -05:00
Jack Nagel
b0cffe4a7c explicitly initialize stdlib 2014-06-29 00:56:29 -05:00
Jack Nagel
e2e5839a9a Get the Tab class under test 2014-06-29 00:55:56 -05:00
Jack Nagel
fde884e319 Use TEST_SHA1 constant in checksum tests 2014-06-28 23:46:23 -05:00
Jack Nagel
58e5ac6835 Implement directory? on keg
Fixes Homebrew/homebrew#30484.
2014-06-28 19:43:52 -05:00
Jack Nagel
e60709e3c2 gist-logs: 1.8 compat 2014-06-28 17:38:11 -05:00
Jack Nagel
6b5c53b03f gist-logs: fix up encoding before passing the response body to OkJson
Fixes Homebrew/homebrew#30519.
2014-06-28 17:35:58 -05:00
Jack Nagel
7cd31377a4 Convert update report to use composition 2014-06-27 21:58:15 -05:00
Jack Nagel
346fa5098f Simplify valid_formula_location? method 2014-06-27 21:58:15 -05:00
Jack Nagel
982a165e52 Use the keg object to manipulate the linked keg record 2014-06-27 16:20:17 -05:00
Jack Nagel
2de2d64907 Give more detailed information about link errors at install-time 2014-06-27 16:10:42 -05:00
Jack Nagel
35267d7c22 Disable "ignore" and "irb" debugger options unless we have a continuation
Fixes Homebrew/homebrew#30472.
2014-06-27 15:19:30 -05:00
Jack Nagel
c5fcdb1f21 Convert to pathname before calling relative_path_from
Fixes Homebrew/homebrew#30494.
2014-06-27 14:45:20 -05:00
Jack Nagel
70f22fc31e Use canonical_name in the exception message 2014-06-26 22:59:45 -05:00
Jack Nagel
cfd02fd415 Use canonical_name when checking LinkedKegs and opt
name is the user-provided string and may be an alias, path, or URL.
2014-06-26 22:57:49 -05:00
Jack Nagel
401bc1c6c7 The rack variable is only used inside the block now 2014-06-26 22:36:49 -05:00
Jack Nagel
301f1b20e6 Remove a dead branch from ARGV.kegs
rack cannot be nil at the point where FormulaUnavailableError is raised,
so we don't need a branch to deal with that.
2014-06-26 22:28:00 -05:00
Jack Nagel
dce7b04ea5 Simplify NoSuchKegError condition
dirs will be empty if the rack directory does not exist.
2014-06-26 22:26:13 -05:00
Jack Nagel
de81350b42 Keg no longer inherits from Pathname 2014-06-26 20:07:11 -05:00
Jack Nagel
62b29e7686 Give Keg#link_dir parameter a more descriptive name 2014-06-26 18:49:08 -05:00
Jack Nagel
64d5aef0bc Fix keg method visibility
Only link_dir needs to be protected
2014-06-26 18:45:34 -05:00
Jack Nagel
001b2ee471 Reuse existing keg object 2014-06-26 17:21:10 -05:00
Jack Nagel
3e35aacbbb Remove dead code 2014-06-26 17:20:00 -05:00
Jack Nagel
2f2f9f185f Deprecate Keg#fname 2014-06-26 16:10:15 -05:00
Jack Nagel
85b6953816 Pass strings, not keg objects, to exec 2014-06-26 14:15:58 -05:00
Mike McQuaid
7673c40f25 brew.rb: handle single usage flag case. 2014-06-26 09:27:22 +01:00
Mike McQuaid
f61633a076 brew: guard --help with nil cmd. 2014-06-26 09:24:07 +01:00
Mike McQuaid
7ecffd2771 brew.rb: handle -—help for internal/external cmds.
Only display —-help for internal commands and not for external ones;
they can handle the flag themselves.

Closes Homebrew/homebrew#26675.
References Homebrew/homebrew#26755.
Closes Homebrew/homebrew#30300.
2014-06-26 08:37:25 +01:00
Jack Nagel
51326e0b63 Extend with a module instead of aliasing on the singleton class 2014-06-25 11:19:00 -05:00
Mike McQuaid
e24c5a750a tap_migrations: apple-gcc42 moved to dupes. 2014-06-25 15:13:30 +01:00
Mike McQuaid
49658cd46b brew-versions: move to Contributions.
Eventually we'll move Contributions to a tap too.

Closes Homebrew/homebrew#30298.
2014-06-25 09:35:37 +01:00
Jack Nagel
2daabe9863 Fix uninitialized constant error in GitHub.open
The error handling depends on side effects of `require "net/https"`,
so it should be wrapped in an explicit begin block.

cf. Homebrew/homebrew#30407.
2014-06-24 21:01:04 -05:00