Rylan Polster
57b2660cae
Revert "Merge pull request #10864 from reitermarkus/command-timeout"
...
This reverts commit d55bdd3ddbe7ff2b1f106a41bd994dc117ca5142, reversing
changes made to 3c3bf1c74d1d7ef1d2c792719574623b6c3c4d25.
2021-03-24 01:22:18 -04:00
Rylan Polster
0b8a9bc1a1
Revert "Merge pull request #10898 from reitermarkus/audit-timeout"
...
This reverts commit 6eaeba184bee5ad42269819c362ab18e9c70b3fa, reversing
changes made to 28b176567992f8d323d73a0a1367d8239e34e8a4.
2021-03-24 01:22:03 -04:00
Rylan Polster
2d3aca706d
Merge pull request #10895 from Rylan12/fix-tap-custom-remote-handling
...
utils/github: handle non-standard tap remotes
2021-03-22 22:28:20 -04:00
Markus Reiter
169d8aca4c
Only raise Timeout::Error if timeout is specified.
2021-03-22 04:15:06 +01:00
Markus Reiter
7ad85116ef
Ignore timeout when checking for HTTPS availability.
2021-03-22 03:34:35 +01:00
Rylan Polster
4e61f61a20
utils/github: handle non-standard tap remotes
2021-03-21 12:35:45 -04:00
Bo Anderson
dab04e3321
utils/popen: redirect stderr to /dev/null rather than close
2021-03-19 17:14:59 +00:00
Bo Anderson
1b61d5a563
Merge pull request #10873 from Bo98/shell_commands_cop
...
Promote shell commands audit to global cop
2021-03-18 20:34:15 +00:00
Bo Anderson
20ff68a425
Fix brew style.
2021-03-17 20:45:44 +00:00
Markus Reiter
712a95fdd0
Allow specifying timeouts for commands and downloads.
2021-03-16 18:15:21 +01:00
Rylan Polster
7a19eed48d
update-python-resources: include wheel in resources
2021-03-14 13:41:36 -04:00
Jonathan Chang
cd280ee52a
github/api: update personal access token format.
...
https://github.blog/changelog/2021-03-04-authentication-token-format-updates/
2021-03-14 18:25:38 +11:00
nandahkrishna
7b0352f167
utils/github/api: simplify pagination
2021-03-11 14:50:19 +05:30
Bo Anderson
769a6cd1f5
Don't touch PATH, GEM_HOME and GEM_PATH when testing formula
2021-03-10 17:08:57 +00:00
Bo Anderson
30ce9b92e8
utils/gems: add installed gems to $LOAD_PATH
2021-02-28 01:28:51 +00:00
Bo Anderson
a5b12a33c2
utils/gems: use Gem API rather than ENV to set paths
2021-02-27 16:23:28 +00:00
Bo Anderson
1fba9b9b53
Prevent loading all non-Bundler gems
2021-02-26 18:23:48 +00:00
hyuraku
178ae750b9
utils/github: set default args to search_code
2021-02-26 21:31:30 +09:00
Mike McQuaid
bde83586ce
Merge pull request #10706 from MikeMcQuaid/bootsnap_tweaks
...
Improve Bootsnap behaviour
2021-02-26 10:48:38 +00:00
Bo Anderson
06381deef4
Merge pull request #10686 from Bo98/safe_fork-status
...
utils/fork: handle termsig in safe_fork
2021-02-26 04:25:54 +00:00
Mike McQuaid
60876eed88
Improve Bootsnap behaviour
...
- further refactor nested conditional to make it clearer
- allow running on Linux while still excluding Apple Silicon
- only warn on `bundle install` failures
2021-02-25 15:59:17 +00:00
Bo Anderson
f079373d8c
utils/fork: handle termsig in safe_fork
2021-02-25 13:42:44 +00:00
Mike McQuaid
f14ed4987f
Merge pull request #10679 from Bo98/unbottled
...
dev-cmd/unbottled: various improvements
2021-02-24 13:56:52 +00:00
Kenneth Chew
edead95768
utils/spdx: correctly detect non-deprecated licenses with plus
2021-02-23 16:28:24 -05:00
Bo Anderson
fb8b247db3
dev-cmd/unbottled: various improvements
...
* Ignore bottles for older macOS versions
* Ignore disabled formulae
* Ignore formulae which can't build on the chosen macOS
* Improve/fix sort description
2021-02-23 16:27:58 +00:00
Nanda H Krishna
53d840c969
Merge pull request #10635 from nandahkrishna/bump-cask-support
...
dev-cmd/bump: add cask support
2021-02-18 02:35:34 +05:30
Nanda H Krishna
7dc8025934
Merge pull request #10626 from nandahkrishna/refactor-github-api
...
utils/github: split GitHub module
2021-02-18 01:20:01 +05:30
nandahkrishna
f7c8810214
utils/github/api: remove 'api' from method names
2021-02-17 23:47:05 +05:30
nandahkrishna
6d948bf6ab
utils/github: add wrapper for GitHub API method
2021-02-17 23:04:15 +05:30
nandahkrishna
bf60e2da3d
utils/repology: add constants for repository names
2021-02-17 02:12:18 +05:30
nandahkrishna
24bb6040a7
dev-cmd/bump: add cask support
2021-02-17 00:42:07 +05:30
Mike McQuaid
c13d7e6723
Fix brew style
2021-02-16 09:25:34 +00:00
nandahkrishna
56e0c3d9e8
Update GitHub API usage
2021-02-15 22:38:27 +05:30
nandahkrishna
9d8a5827a3
utils/github: split module
2021-02-15 21:08:10 +05:30
Nanda H Krishna
b9cbeb3019
Merge pull request #10608 from nandahkrishna/assignment-condition-parentheses
...
style: use parentheses for assignment in conditions
2021-02-15 18:43:54 +05:30
Rylan Polster
79e93f54e2
Ignore more parser warnings
2021-02-14 11:58:05 -05:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Rylan Polster
945d757450
utils/rubocop: don't recreate Regexp into new Regexp
2021-02-11 08:41:32 -05:00
Rylan Polster
98e40d1638
Define ignored warnings as Regexp
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-02-11 07:56:27 -05:00
Rylan Polster
3595ac1f7f
style: call rubocop directly
2021-02-10 22:36:42 -05:00
nandahkrishna
15f936a22a
dev-cmd/update-maintainers: implement suggestions from code review
2021-02-08 23:33:26 +05:30
nandahkrishna
6026c7c74d
brew update-maintainers: dev-cmd to update maintainers in README
2021-02-08 23:33:25 +05:30
Marcus Maxwell
f1ef1afd21
Add workflow scope to github.rb
2021-02-08 12:30:19 +00:00
Issy Long
f71ea65ee0
utils/github: Say "macOS keychain" in MissingAuthenticationError
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-02-05 13:52:32 +00:00
Issy Long
9394fe2b52
utils/github: Use constant everywhere for "create a PAT" message
...
- This way if we ever change this messaging, we only have to do so once.
2021-02-05 12:45:11 +00:00
Issy Long
ccb6d5e834
utils/github: Handle users not having any GitHub credentials
...
- When running `brew request-bottle`, users who don't have credentials
in the macOS keychain (ie, Linux users) or `HOMEBREW_GITHUB_API_TOKEN`
receive "Error: Not Found" from the GitHub API returning a 404.
- This is cryptic and confusing for newcomers to Linux maintenance, and
potentially confusing to other folks using `open_api` where
credentials are expected yet unset.
- This adds a new `MissingAuthenticationError` to handle the case where
the GitHub API returns 404 and there are no creds yet API scopes are
required.
Before:
```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: Not Found
```
After:
```
issyl0@sky:/home/linuxbrew/.linuxbrew/Homebrew$ brew request-bottle hello
==> Dispatching request to Homebrew/linuxbrew-core for hello
Error: No GitHub credentials found in Keychain or environment.
Create a GitHub personal access token:
https://github.com/settings/tokens/new?scopes=gist,public_repo&description=Homebrew
echo 'export HOMEBREW_GITHUB_API_TOKEN=your_token_here' >> ~/.profile
```
2021-02-05 12:44:46 +00:00
Mike McQuaid
8eeb838440
Merge pull request #10490 from nandahkrishna/fix-api-credentials-error
...
utils/github: fix false positive API credential error
2021-02-03 08:58:33 +00:00
Mike McQuaid
c5c151d2b3
Merge pull request #10494 from hyuraku/utils/curl_refactor-curl_with_workarounds
...
utils/curl: refactor curl_with_workarounds
2021-02-03 08:55:34 +00:00
hyuraku
16f8638236
utils/curl: refactor curl_with_workarounds
2021-02-03 09:54:09 +09:00
nandahkrishna
f15681ccd9
utils/github: fix false positive API credential error
2021-02-03 01:37:57 +05:30
