Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Markus Reiter
a24da6b072
Remove FromDefaultNameLoader to avoid warning twice.
2024-03-06 23:14:28 +01:00
Douglas Eichelberger
c4db19232d
git grep -lE '\(\&[A-Za-z._]+method\(:' | xargs gsed -i -E 's|\(\&([A-Za-z._]+)method\(:([a-z?_]+)\)\)| { \1\2(_1) }|g'
2024-03-03 18:55:56 -08:00
Markus Reiter
9cfc7ef9bd
Clear all tap caches before each test.
2024-02-22 17:56:47 +01:00
Douglas Eichelberger
d7ebf97467
Turn on disable_monkey_patching
2024-02-19 13:57:28 +00:00
Douglas Eichelberger
ab8f5702ac
git grep -l '^shared_examples' | xargs gsed -i 's|^shared_examples|RSpec.shared_examples|g'
2024-02-19 13:57:28 +00:00
Douglas Eichelberger
26eda5a303
git grep -l '^describe' | xargs gsed -i 's|^describe|RSpec.describe|g'
2024-02-19 13:57:27 +00:00
Douglas Eichelberger
2255b9d43d
Enable verify_partial_doubles
2024-02-19 13:57:27 +00:00
Markus Reiter
adbd11a0db
Fix flaky tests.
2024-02-16 10:49:32 +01:00
Markus Reiter
18150d9629
Demonstrate flaky tests.
2024-02-16 10:39:21 +01:00
Markus Reiter
c8058a3859
Add tests for cask migrations to default tap.
2024-02-13 21:27:36 +01:00
Mike McQuaid
0b04a7bdfc
test/cask/upgrade_spec: remove flaky specs.
...
BuildPulse (and my interactions with CI on this repository) have shown
this tests to be very flaky. Flaky tests are not useful tests so let's
just delete them and they can be re-added if fixed in future.
2024-02-13 09:38:04 +00:00
Douglas Eichelberger
12d32cc69e
Manual fixes
2024-02-11 20:13:24 -08:00
Douglas Eichelberger
2be13eb715
brew style --fix
2024-02-11 14:35:42 -08:00
Kevin
6797edf425
Merge pull request #16632 from reitermarkus/simplify-tests
...
Simplify tests.
2024-02-10 10:29:31 -08:00
Markus Reiter
d42f419217
Don't use slashes when loading casks in tests.
2024-02-09 23:17:25 +01:00
Markus Reiter
d9263196a2
Never link outdated cask fixtures.
2024-02-09 22:04:26 +01:00
Markus Reiter
55b4db3f43
Use before instead of let!.
2024-02-09 22:03:13 +01:00
Markus Reiter
a04dd7b547
Deduplicate before blocks.
2024-02-09 22:03:05 +01:00
Markus Reiter
4d8b3784db
Remove unnecessary to_s.
2024-02-09 22:02:00 +01:00
Markus Reiter
889854b0b3
Merge FromTapPathLoader into FromPathLoader.
2024-02-08 16:20:32 +01:00
Markus Reiter
889c3c38ed
Refactor CaskLoader::for.
2024-02-07 02:02:02 +01:00
Markus Reiter
e5a6f765da
Revert "Merge pull request #16608 from bevanjkay/revert-16596-cask-rename-migrations"
...
This reverts commit 5799e8541567385c4d729cc3f0062b45e55b9936, reversing
changes made to 677517132782b276ba1c4ba77456adf7540d99ba.
2024-02-07 02:02:02 +01:00
Bevan Kay
f0b8845ad6
Revert "Handle tap migrations in CaskLoader."
2024-02-06 20:16:03 +00:00
Markus Reiter
0fa503b827
Test CaskLoader::for with both short and full tokens.
2024-02-06 20:20:39 +01:00
Markus Reiter
094761dcd9
Add tests for CaskLoader::for.
2024-02-06 19:56:09 +01:00
Bevan Kay
bd6ab1d2b8
cask/uninstall: skip quit and signal directives when upgrading or reinstalling
2024-01-19 23:30:25 +11:00
Patrick Linnane
50b0940c72
various: fix future tense in tests
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-01-08 18:41:30 +00:00
Douglas Eichelberger
caf8259ae6
Code review changes
2023-12-27 15:29:33 -08:00
Douglas Eichelberger
3abbf4447e
Some minor regexp match perf improvements
2023-12-27 13:16:36 -08:00
Rylan Polster
254fcf7c1f
Update livecheck test fixtures to use deprecate! and disable!
2023-12-17 16:31:04 -05:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop
2023-12-14 05:47:12 +00:00
Mike McQuaid
79a6091d08
Cask#full_name: properly output Homebrew org names
...
This was not returning the full name correctly for e.g. anything in
Homebrew/homebrew-fonts.
While we're here, fix up a few other places where `tap.core_cask_tap?`
can be used more appropriately.
2023-12-13 13:17:12 +00:00
Mike McQuaid
22553cd34a
Fix cask sharding issues
...
- Fix cask info output being incorrect
- Improve some code referring to casks as formulae
- Move livecheck cask fixtures to not shadow existing names
- Adjust the cask tap symlinking logic to make handling outdated
shadowed casks significantly easier
- Fix various flaky tests caused by casks sharding logic
- Prefer longer paths when there's multiple formulae or casks in a tap
with the same name rather than always using the first
2023-08-10 16:08:47 +01:00
apainintheneck
c9dea04bd4
cmd/install: upgrade already installed casks
...
Previously, the behavior was to warn users that a cask was already
installed and then skip modifying the installed version. This is
different to how we handled things with formulas. For them we would
upgrade any already installed formulas. This just brings casks in line
with what we already do with formulas.
Changes:
- cmd/install: Upgrade already installed casks if HOMEBREW_NO_INSTALL_UPGRADE
is not set
- env_config: Update wording of HOMEBREW_NO_INSTALL_UPGRADE to include casks
- remove error that was only used to alert about already installed casks
Note:
- The upgrade command for casks defaults to --greedy when you pass named casks
to the command which means that this will always default to that behavior
since you must specify the name of the cask when installing.
2023-07-23 18:50:39 -07:00
Bo Anderson
ba02c669e1
Introduce CoreCaskTap class
2023-07-13 20:33:26 +01:00
Mike McQuaid
7da934f7e2
Deprecate/disable/delete code.
...
The next release after this is merged will be 4.1.0.
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-07-06 16:56:20 +01:00
hyuraku
de7152b7a3
rename Cask::outdated_versions
2023-06-19 22:09:01 +09:00
JBYoshi
97b9b61061
Change permission failure from fatal to warning.
2023-05-26 11:13:23 -05:00
JBYoshi
40352cb2da
Make Homebrew check for App Management permissions before updating apps.
2023-05-24 22:11:16 -05:00
Markus Reiter
d2231086bd
Merge pull request #15420 from reitermarkus/simulate-system-with
...
Add `SimulateSystem::with`.
2023-05-14 21:41:20 +02:00
Mike McQuaid
3dabf504bd
Merge pull request #15176 from reitermarkus/cask-renames
...
Implement cask renames.
2023-05-14 19:46:56 +01:00
Markus Reiter
0d56b97b07
Add SimulateSystem::with.
2023-05-14 01:45:04 +02:00
Markus Reiter
d7a0e260e8
Improve Cask::Utils.gain_permissions_remove for symlinks.
2023-05-13 03:54:48 +02:00
Markus Reiter
4e483c9a0e
Add test for Cask::Utils::gain_permissions_mkpath.
2023-05-13 03:42:00 +02:00
Markus Reiter
a3231a03fa
Implement cask renames.
2023-05-12 21:17:30 +02:00
JBYoshi
b1c7f12fbb
Clean up allow and expect.
2023-05-12 09:57:12 -05:00
JBYoshi
4a3b8923f2
More test cleanup.
2023-05-12 09:52:57 -05:00
JBYoshi
5e23a0563a
Switch base case expect() to allow().
2023-05-11 17:10:41 -05:00
JBYoshi
7a108d3db0
Merge and_call_original instruction into expect() calls.
2023-05-11 17:09:27 -05:00
