admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
46,483 Commits 15 Branches 471 Tags
Commit Graph

129 Commits

Author SHA1 Message Date
Xuehai Pan
2466353415 style: use short flags for patch command for compatibility 2022-01-03 22:13:32 +08:00
Xuehai Pan
62a63063bb Apply suggestions from code review 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Signed-off-by: XuehaiPan <XuehaiPan@pku.edu.cn>
 2021-11-24 01:06:27 +08:00
XuehaiPan
9ef52080e3 utils: extract common word "for" in reason 2021-11-23 23:59:09 +08:00
XuehaiPan
d749173adc utils: mark reason as keyword argument in ensure_formula_installed! 2021-11-23 23:31:22 +08:00
XuehaiPan
3376479e95 utils: add method ensure_formula_installed! 2021-11-23 22:48:39 +08:00
Mike McQuaid
e38e25dfd1
Merge pull request #12397 from XuehaiPan/shellcheckrc 
.shellcheckrc: disable unneeded check SC2310-SC2312 globally
 2021-11-08 16:15:21 +00:00
XuehaiPan
d78c11361a .shellcheckrc: disable unneeded check SC2310-SC2312 globally 2021-11-08 23:50:54 +08:00
Xuehai Pan
c1d2f8a2c6
style: catch failures while applying patches 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2021-11-08 22:50:20 +08:00
XuehaiPan
b86fdfeb09 style: use long options for patch command 2021-11-08 22:34:49 +08:00
XuehaiPan
67c619d4f2 style: use popen_write to apply patches 2021-11-08 20:10:30 +08:00
Xuehai Pan
a56ab26e88
Merge branch 'master' into shellcheck-autofix 2021-11-08 12:02:54 +08:00
Bo Anderson
98c082ca94
style: ignore SC2310-2312 for now 2021-11-08 03:11:39 +00:00
XuehaiPan
fa85d00b95 style: implement shellcheck autofix in brew style --fix 2021-11-07 21:12:03 +08:00
Mike McQuaid
bc687314af
style: better handle HOMEBREW_REPOSITORY. 
If you do `brew style --fix .` in `HOMEBREW_REPOSITORY` it behaves
very weirdly and uses the incorrect rules. If this is passed, assume
that people want the same behaviour as `brew style --fix`.

While we're here, do some argument naming and code cleanup.
 2021-09-30 11:06:09 +01:00
XuehaiPan
966189d07d style: add shfmt exit status to brew style 2021-09-17 00:05:37 +08:00
XuehaiPan
03017a84b4 style: move inplace flag to the front of argument list 2021-09-16 21:20:56 +08:00
XuehaiPan
2688e7e56b style: apply suggestions from code review 2021-09-16 19:54:07 +08:00
XuehaiPan
03c7a142be style: add keyward argument inplace to run_shfmt 2021-09-16 00:08:29 +08:00
XuehaiPan
9efde249c1 style: add shfmt implementation 2021-09-15 22:12:01 +08:00
XuehaiPan
2855ae18df style: brew style always use latest brewed shellcheck 2021-09-15 15:00:23 +08:00
XuehaiPan
bc0663baba style: brew style check Dockerfile as shell script 2021-09-15 15:00:23 +08:00
hyuraku
fcdeaf7eca chnage condition for shellcheck 2021-09-07 20:47:48 +09:00
Bo Anderson
a06d136d2c
Move Sorbet gems into an optional group 2021-06-11 08:10:30 +01:00
Gautham Goli
cf733a3c4f Enable shellcheck warnings in brew style 2021-05-18 17:10:44 +05:30
Mike McQuaid
7af68d0f8e
Fix shellcheck failures 
A new version of `shellcheck` (I think?) brought us so new warnings and
errors.

To fix:
- pass `--source-path` so we don't need to stop `shellcheck` trying to
  read sourced files every time
- disable some more warnings/errors we don't care about fixing
 2021-04-22 13:18:44 +01:00
Gautham Goli
7abfb11a0b Use shellcheck on Bash completion file 2021-04-11 19:02:25 +05:30
Markus Reiter
c2c93d1cc9
Run shellcheck on cask utils and shim scripts. 2021-04-02 03:03:54 +02:00
Rylan Polster
79e93f54e2
Ignore more parser warnings 2021-02-14 11:58:05 -05:00
Rylan Polster
3595ac1f7f
style: call rubocop directly 2021-02-10 22:36:42 -05:00
Mike McQuaid
eea27d9a60
style: remove HOMEBREW_RUBY_WARNINGS 
This is hiding legitimate errors which can cause CI failures.
 2021-01-29 20:56:59 +00:00
Rylan Polster
bcac46bccb style: use Homebrew shellcheck if installed 2021-01-01 03:26:08 -05:00
Mike McQuaid
d4461a2728
style: fix autocorrect. 
For some reason this doesn't seem to work without `-A`.
 2020-12-31 13:30:24 +00:00
Mike McQuaid
b889a6bda1
style: output warnings on debug/verbose. 
Otherwise this will hide actual errors.
 2020-12-31 13:30:23 +00:00
Markus Reiter
bdfa7a757d Hide parser warning. 2020-12-18 19:37:29 +01:00
Rylan Polster
c181c9995e style: add --reset-cache option 2020-11-30 18:18:50 -05:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
EricFromCanada
3768b7a6e9 apidoc: update comment wording, punctuation, formatting 2020-11-06 00:21:02 -05:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Markus Reiter
1c04ba7e4d
Merge pull request #8684 from reitermarkus/audit-annotations 
Output annotations for `brew audit`.
 2020-09-13 02:39:55 +02:00
Mike McQuaid
fb4d08a49a Fix brew style 2020-09-11 10:29:22 +01:00
Markus Reiter
23aced68d4 Output annotations for brew audit. 2020-09-10 22:23:03 +02:00
Markus Reiter
c942aafc4c
Merge pull request #8636 from reitermarkus/brew-style-casks 
Support passing casks in `brew style`.
 2020-09-10 02:10:51 +02:00
Markus Reiter
2a63ba4060 Support passing casks in brew style. 2020-09-09 22:15:10 +02:00
Markus Reiter
769fa066e2 Output annotations for brew cask audit. 2020-09-09 21:50:32 +02:00
Markus Reiter
ebd4ce467c Output GitHub Actions annotations for brew style. 2020-09-02 16:44:16 +02:00
Markus Reiter
9d57bfc9ba Adjust RuboCop formatter on CI. 2020-09-02 02:02:01 +02:00
Markus Reiter
776faf651d Always use default RuboCop formatter for nicer output. 2020-09-01 18:34:26 +02:00
Markus Reiter
b4d14c193f Use Homebrew::Style for brew cask style. 2020-09-01 18:34:26 +02:00
Markus Reiter
c0f64882f1 Split check_style_impl into run_rubocop and run_shellcheck. 2020-08-31 02:44:05 +02:00
Markus Reiter
6bd3dbe001 Document Style. 2020-08-26 03:13:59 +02:00