admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
46,483 Commits 15 Branches 471 Tags
Commit Graph

851 Commits

Author SHA1 Message Date
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list. 
Also, provide details on how to update this in future and split it into
two.

Fixes #7396
 2020-04-20 10:36:42 +01:00
Mike McQuaid
8eed72cd8b
Move file mode audit to RuboCop. 2020-04-18 15:44:24 +01:00
Jonathan Chang
d6cf14fd1e audit: add libiconv to uses_from_macos whitelist 
This lives at /usr/lib/libiconv.dylib
 2020-04-18 21:39:39 +10:00
Mike McQuaid
604434566f
rubocops/text: whitelist goose. 2020-04-14 11:59:56 +01:00
Mike McQuaid
3b9a8cb8c1
rubocops/lines: fix rule. 
This stops stuff like `clang=1` from being matched incorrectly.
 2020-04-14 11:59:41 +01:00
Mike McQuaid
d52e870b07
rubocop: remove NewFormulaAudit. 
This is no longer used anywhere.
 2020-04-13 16:01:26 +01:00
Mike McQuaid
44c22dd7e3
rubocops/text: re-add strict cop. 2020-04-13 16:01:26 +01:00
Mike McQuaid
632813d969
rubocops/patches: reduce required revision length. 2020-04-13 16:01:26 +01:00
Mike McQuaid
ea77fce409
rubocops/lines: move strict cop. 2020-04-13 16:01:25 +01:00
Mike McQuaid
9b5a0767cb
rubocops/formula_desc: merge cops, slim whitelist. 2020-04-13 16:01:25 +01:00
Mike McQuaid
476a61f51c
rubocops/class: rename, move cops, readd strict. 2020-04-13 16:01:25 +01:00
Mike McQuaid
b75733f1bd
rubocops: downgrade strict cops (passing in core). 2020-04-12 14:17:06 +01:00
Mike McQuaid
45908d8ff2
uses_from_macos: update openssl in whitelist. 2020-04-12 14:17:05 +01:00
Mike McQuaid
fbeeae96ef
rubocops/text: check openssl and openssl@1.1. 2020-04-12 14:17:05 +01:00
Mike McQuaid
3ded55aec2
rubocops/options: refactor unless ==. 2020-04-12 14:17:05 +01:00
Mike McQuaid
20998ed6e3
rubocop/lines: extract whitelist to constant. 2020-04-12 14:17:05 +01:00
Mike McQuaid
2e74e50f82
rubocop/conflicts: use full name in whitelist. 2020-04-12 14:17:05 +01:00
Mike McQuaid
c5b8983da4
rubocops/class: refactor unless && 2020-04-12 14:17:04 +01:00
Sean Molenaar
84181f2068
Audit: allow make check for nettle 2020-04-08 19:08:15 +02:00
Alexander Bayandin
1b18a01779
Library/Homebrew/rubocops/uses_from_macos: add ssh-copy-id 2020-04-07 15:04:23 +01:00
Mike McQuaid
bd082011c2
Merge pull request #7280 from issyl0/audit-uses-from-macos 
audit: Check if `uses_from_macos` usage is correct
 2020-04-07 12:47:30 +01:00
Mike McQuaid
4dd70048d6
rubocops/uses_from_macos: tweak whitelist. 2020-04-07 12:16:17 +01:00
Dario Vladovic
3a21ca8956
Implement mdimporter cask stanza 2020-04-06 15:24:14 +02:00
Issy Long
857393ccfb
Audit correct uses_from_macos usage with RuboCop 
- This builds on @jonchang's work that started in #6265.
- We now use `uses_from_macos` to declare dependencies that are implicit
  on macOS because they ship with macOS, but they're needed on Linux. We
  have to be sure that the dependencies people specify as
  `uses_from_macos` are actually shipped with macOS. So, we maintain a
  safelist of those dependencies and check against it.
- Also add more legitimate `uses_from_macos` dependencies to the list.
- This is runnable with `brew audit --only-cops=FormulaAudit/UsesFromMacos`.
- It produces different number of failures on macOS vs. Linux, because
  apparently we've not synced Homebrew/linuxbrew-core upstream thoroughly
  enough yet.
- Originally this was designed as a `--strict` audit, but we flipped it
  to be a normal audit because - to quote Mike - this is "sufficiently
  robust" now.
 2020-04-06 13:42:27 +01:00
Mike McQuaid
37a79498a0
rubocops/urls: whitelist cspice. 
As explained in https://github.com/Homebrew/brew/pull/7256#issuecomment-607787949
 2020-04-03 13:53:03 +01:00
Mike McQuaid
ddaf467741
rubocops/urls: reorder for quicker scanning. 2020-04-03 13:52:44 +01:00
Mike McQuaid
9da6c9b521
rubocops/urls: stricter binary URL requirements. 
Don't rely on x86_64 detection but instead whitelist the few projects
that fun afoul of these regex.
 2020-04-02 09:54:14 +01:00
Alexander Bayandin
b37c3e9cb2 rubocops/patches: suggest url with full_index=1 2020-03-15 11:24:38 +00:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Issy Long
9f80a7bce2
rubocops/patches: Make more GitHub patch locations enforce revisions 
- We recently deleted a load of old Homebrew/formula-patches patches for
  non-existent core formulae
  (https://github.com/Homebrew/formula-patches/pull/283). This is a good
  action to take. Users should always be able to retrieve the patch once
  it's been deleted from the repo, if the formula they continue to use
  specifies a git revision to pull from, not just `master`.
- The code to detect `master` formulae was already here, so this adds
  another GitHub host to the detection: `raw.githubusercontent.com` as
  that's what the current patches that use `master`
  (https://github.com/Homebrew/homebrew-core/pull/51329) link to.
- Fixes https://github.com/Homebrew/homebrew-core/issues/51313.
 2020-03-08 20:21:43 +00:00
Bo Anderson
79811537fb rubocop/urls: add go@1.13 to binary URLs whitelist 2020-02-26 09:26:49 +00:00
EricFromCanada
29006396dd audit: check apache.org URLs 2020-02-24 13:07:46 -05:00
Mike McQuaid
ba52e7f932
rubocop/urls: remove deleted ghc@8.2. 2020-02-24 11:40:46 +00:00
Seeker
f60e2a0c4a
Add ghc@8.6 to binary formula URLs whitelist 2020-02-23 11:09:02 -08:00
Sam Ford
486a557cf5
rubocop/lines: add protobuf to whitelist 2020-02-16 09:34:09 -05:00
Michka Popoff
f96342713b rubocop: remove BINARY_URLS_WHITELIST and rust nightly 
This url is not used anymore, we replaced it with a new stable version
of rust.
 2020-02-01 13:17:25 +01:00
Mike McQuaid
6bc72cf18a
rubocop/lines: add whitelist. 
Let's only allow cryto or libraries.
 2020-01-29 12:17:21 +00:00
Jonathan Chang
abf2b83b35 audit: add uses_from_macos dependency ordering 2020-01-12 11:12:27 -08:00
Jonathan Chang
cf66c05d87 audit: avoid build-time checks in core 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2020-01-11 09:48:54 -08:00
Jonathan Chang
9634041f82 audit: unnecessary comments from external taps 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2020-01-11 09:44:20 -08:00
Jonathan Chang
7239b3099a audit: check for build.with? in core 
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
 2020-01-11 09:37:10 -08:00
Jonathan Chang
779304df68 audit: add "homebrew/core" for relevant checks 2020-01-08 15:38:48 -05:00
Dawid Dziurla
a6b08ecaed
rubocops: add go@1.12 to BINARY_FORMULA_URLS_WHITELIST 2019-11-01 20:54:38 +01:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Markus Reiter
6cff8aff90 Fix cop for interpolated strings. 2019-10-16 19:06:39 +02:00
Markus Reiter
3d0fae4621 Fix #match? on nil. 2019-10-16 18:37:28 +02:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere 
- Only try to call `.match?` on strings that aren't nil.
 2019-10-13 23:22:51 +01:00
Issy Long
3570cb6e77
Auto-fix Style/NegatedUnless offenses 2019-10-13 16:04:36 +01:00
Issy Long
37fee928b5
Auto-fix Style/NegatedIf offenses 2019-10-13 16:04:35 +01:00