Mike McQuaid
03e583e746
cask: read bundle version from Info.plist
when sensible.
...
If you're trying to use `brew info --json=v2` to get an installed
version and figure out if it is outdated: you're going to have a bad
time with `auto_updates` casks because `installed_version` alone is not
enough to get the actually currently installed version of the app.
Instead, in these cases, try to read from `Info.plist` if there is one
and use that version.
While we're here, add a `blank?` method to `Version` so we can use it
for `present?` checks (making a `null?` `Version` object `blank?`).
Co-authored-by: Markus Reiter <me@reitermark.us>
2024-03-06 15:52:16 +00:00
Markus Reiter
a851bb86ef
Add type signature for Tap::fetch
.
2024-03-06 14:30:17 +01:00
Mike McQuaid
c5e7282985
Merge pull request #16807 from dduugg/numbered-params
...
Prefer numbered block params over proc conversion
2024-03-04 16:38:14 +00:00
Douglas Eichelberger
c4db19232d
git grep -lE '\(\&[A-Za-z._]+method\(:' | xargs gsed -i -E 's|\(\&([A-Za-z._]+)method\(:([a-z?_]+)\)\)| { \1\2(_1) }|g'
2024-03-03 18:55:56 -08:00
Douglas Eichelberger
90996e1997
git grep -lE '\(\&[A-Za-z._]+method\(:' | xargs gsed -i -E 's|\(\&([A-Za-z._]+)public_method\(:([a-z?_]+)\)\)| { \1\2(_1) }|g'
2024-03-03 18:55:32 -08:00
Bo Anderson
2d929b8a9f
cask/quarantine: avoid xcrun when executing Swift
2024-03-02 19:31:38 +00:00
Markus Reiter
c3c5437c4f
Rename Tap#reverse_cask_renames
to Tap#cask_reverse_renames
.
2024-03-01 12:57:37 +01:00
Mike McQuaid
f1eea64523
Merge pull request #16779 from reitermarkus/fix-load-from-path
...
Fix loading casks/formulae from relative paths.
2024-03-01 08:47:41 +00:00
Markus Reiter
3da0f8c4a6
Fix loading casks/formulae from relative paths.
2024-03-01 04:05:15 +01:00
Markus Reiter
755c8aecad
Simplify Tap#cask_files_by_name
.
2024-02-29 22:47:43 +01:00
Bo Anderson
1d7101d8a3
Use HOMEBREW_TEMP more universally
2024-02-26 16:58:53 +00:00
Issy Long
f4218a6316
Fix RuboCop Performance/MapCompact
offenses
...
- Rename an iterator variable since it would make the line too long.
2024-02-25 22:59:59 +00:00
Markus Reiter
670eb3d02d
Remove CaskLoader::tap_paths
.
2024-02-20 18:25:11 +01:00
Markus Reiter
876535c670
Use HOMEBREW_DEFAULT_TAP_CASK_REGEX
in FromDefaultNameLoader
.
2024-02-13 21:52:45 +01:00
Markus Reiter
d506645667
Add separate loader for default tap.
2024-02-13 21:25:52 +01:00
Markus Reiter
a3a1b4c253
Check tap migrations for renames.
2024-02-13 06:03:10 +01:00
Markus Reiter
b4d602e70b
Don't warn about renamed installed casks.
2024-02-13 04:37:10 +01:00
Markus Reiter
eaf7b38995
Allow tap migrations with renames.
2024-02-13 04:17:43 +01:00
Markus Reiter
c39abef045
Always prefer default tap.
2024-02-12 21:45:07 +01:00
Markus Reiter
48c9897081
Convert FromNameLoader
to class.
2024-02-12 07:43:29 +01:00
Markus Reiter
8e04ab8b42
Fix type signature.
2024-02-12 07:14:28 +01:00
Markus Reiter
0211feebd7
Fix loading test fixtures.
2024-02-12 07:14:27 +01:00
Markus Reiter
6f28392d6e
Remove FromDefaultTapPathLoader
and FromDefaultTapLoader
.
2024-02-12 07:12:33 +01:00
Markus Reiter
d17aa66759
Avoid T.cast
.
2024-02-12 07:12:32 +01:00
Markus Reiter
3e61e3b428
Stop following recursive tap migrations.
2024-02-10 15:07:31 +01:00
Markus Reiter
cb13f95928
Avoid T.cast
.
2024-02-09 16:59:27 +01:00
Markus Reiter
1323262610
Rename constant.
2024-02-08 19:22:02 +01:00
Markus Reiter
76d8d6c840
Add type signatures.
2024-02-08 16:30:08 +01:00
Markus Reiter
a37afcb777
Fix loading renamed casks from API.
2024-02-08 16:29:31 +01:00
Markus Reiter
889854b0b3
Merge FromTapPathLoader
into FromPathLoader
.
2024-02-08 16:20:32 +01:00
Markus Reiter
dc21095731
Simplify multiple if
s into single case
statement.
2024-02-08 16:20:32 +01:00
Markus Reiter
732e4438f4
Use token
instead of name
for casks.
2024-02-08 16:20:31 +01:00
Markus Reiter
6e5b6b7cc9
Remove unused parameter from CaskLoader::tap_paths
.
2024-02-08 16:20:31 +01:00
Markus Reiter
c301b9c703
Readd debug logging.
2024-02-07 14:02:12 +01:00
Markus Reiter
825222cc83
Simplify code style.
...
Co-authored-by: Kevin <apainintheneck@gmail.com>
2024-02-07 14:02:10 +01:00
Markus Reiter
c559e6777c
Reuse rename logic for default cask tap.
2024-02-07 02:02:03 +01:00
Markus Reiter
889c3c38ed
Refactor CaskLoader::for
.
2024-02-07 02:02:02 +01:00
Markus Reiter
e5a6f765da
Revert "Merge pull request #16608 from bevanjkay/revert-16596-cask-rename-migrations"
...
This reverts commit 5799e8541567385c4d729cc3f0062b45e55b9936, reversing
changes made to 677517132782b276ba1c4ba77456adf7540d99ba.
2024-02-07 02:02:02 +01:00
Bevan Kay
f0b8845ad6
Revert "Handle tap migrations in CaskLoader
."
2024-02-06 20:16:03 +00:00
Markus Reiter
094761dcd9
Add tests for CaskLoader::for
.
2024-02-06 19:56:09 +01:00
Markus Reiter
ed00dc0b95
Add type annotations for cask loaders.
2024-02-06 16:04:08 +01:00
Markus Reiter
5cab0c8a6e
Handle tap migrations in CaskLoader
.
2024-02-06 01:08:23 +01:00
Eric Knibbe
e63b1f4da5
docs: monospace suggested values
2024-02-04 15:42:26 +01:00
Eric Knibbe
7698cf2098
audit: messaging improvements
2024-02-04 15:10:14 +01:00
Mike McQuaid
0d02aa3313
Merge pull request #16578 from dnicolson/fix-quick-look
...
Replace “QuickLook” with “Quick Look”
2024-02-04 12:09:45 +01:00
Dave Nicolson
31f09f8d30
Replace “QuickLook” with “Quick Look”
2024-02-03 23:54:04 +01:00
Douglas Eichelberger
e235bcf903
Add caveats.rbi
2024-01-31 22:23:40 -08:00
Douglas Eichelberger
eb7c3e52a0
Require SystemInclude only where needed
2024-01-31 11:42:01 -08:00
Douglas Eichelberger
f99d39faf9
Vendor CompactBlank cop
2024-01-26 15:03:59 -08:00
Mike McQuaid
86e1c8aacf
Merge pull request #16463 from dduugg/no-active-support
...
Remove ActiveSupport from runtime
2024-01-22 19:22:12 +00:00