Mike McQuaid
8baed211a7
brew style --fix
2024-04-08 19:23:33 +01:00
Bo Anderson
011dfc8f45
cask/artifact/moved: fix permission handling when removing directories
2024-03-15 21:31:37 +00:00
Mike McQuaid
a3702a28c4
cask/artifact: check the bundle version when using --adopt.
...
This makes `--adopt` considerably faster and more useful for application
bundles by checking the bundle version before failing to adopt the
bundle.
This could be further extended by e.g. checking if auto-updates are
enabled.
While we're here, also allow `adopt` to act a bit more like `force` in
a few other places assuming this initial check passes.
2024-03-14 10:31:31 +00:00
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Issy Long
f4218a6316
Fix RuboCop Performance/MapCompact offenses
...
- Rename an iterator variable since it would make the line too long.
2024-02-25 22:59:59 +00:00
Mike McQuaid
0d02aa3313
Merge pull request #16578 from dnicolson/fix-quick-look
...
Replace “QuickLook” with “Quick Look”
2024-02-04 12:09:45 +01:00
Dave Nicolson
31f09f8d30
Replace “QuickLook” with “Quick Look”
2024-02-03 23:54:04 +01:00
Douglas Eichelberger
eb7c3e52a0
Require SystemInclude only where needed
2024-01-31 11:42:01 -08:00
Douglas Eichelberger
f99d39faf9
Vendor CompactBlank cop
2024-01-26 15:03:59 -08:00
Mike McQuaid
86e1c8aacf
Merge pull request #16463 from dduugg/no-active-support
...
Remove ActiveSupport from runtime
2024-01-22 19:22:12 +00:00
Douglas Eichelberger
8efe73b32c
Add Object#deep_dup to extend/
2024-01-22 10:52:43 -08:00
Douglas Eichelberger
f6c7eb7124
Add hash/keys to extend/
2024-01-19 13:36:17 -08:00
Bevan Kay
bd6ab1d2b8
cask/uninstall: skip quit and signal directives when upgrading or reinstalling
2024-01-19 23:30:25 +11:00
Douglas Eichelberger
ffd761d2e9
Create dedicated Attrable mixin for attr_ methods
2023-12-28 11:46:27 -08:00
Douglas Eichelberger
3abbf4447e
Some minor regexp match perf improvements
2023-12-27 13:16:36 -08:00
Mike McQuaid
228b1d62ed
cask/artifact/abstract_uninstall: handle signal failures.
...
If the process is running as another user: this will always fail.
2023-12-20 19:43:46 +00:00
Patrick Linnane
9dee80cb2d
various: fix style errors
2023-12-18 09:34:01 -08:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop
2023-12-14 05:47:12 +00:00
Mike McQuaid
ff404fe5ab
Merge pull request #16184 from dduugg/rm-try
...
Remove use of ActiveSupport try
2023-11-06 13:11:01 +00:00
Douglas Eichelberger
75179e9239
brew style --fix
2023-11-05 12:18:31 -08:00
Douglas Eichelberger
00ba09d73d
Remove use of ActiveSupport try
2023-11-05 09:28:19 -08:00
Douglas Eichelberger
0191af7899
resolve typecheck errors
2023-11-05 08:55:58 -08:00
Mike McQuaid
eb1355e624
Add HOMEBREW_SUDO_THROUGH_SUDO_USER
...
This environment variable allows telling Homebrew to use the `SUDO_USER`
variable to `sudo` through that user when Homebrew (Cask) attempts to
run `sudo`.
While we're here, clarify in some messaging that we're running `sudo`
and that that's the password we're asking for; the specific password is
configuration dependent and not the specific password for the user.
Similarly, remove the `Package installers may write to any location`
output; it's kinda spammy and doesn't feel like the right place.
2023-09-29 18:49:44 +01:00
Bo Anderson
af7d744af0
Fixes for Ruby 3
2023-09-29 05:25:48 +01:00
Mike McQuaid
58df7885e6
cask/quarantine: sudo correctly during tests.
...
Use `NeverSudoSystemCommand` and pass it through to
`Quarantine.copy_xattrs` so `brew tests` doesn't try to `sudo`.
Fixes #15958
Co-authored-by: Bo Anderson <mail@boanderson.me>
Co-authored-by: Kevin <apainintheneck@gmail.com>
2023-09-06 10:03:45 -04:00
JBYoshi
97b9b61061
Change permission failure from fatal to warning.
2023-05-26 11:13:23 -05:00
JBYoshi
40352cb2da
Make Homebrew check for App Management permissions before updating apps.
2023-05-24 22:11:16 -05:00
Markus Reiter
935c5efaf8
Use sudo for rmdir if necessary.
2023-05-13 06:46:59 +02:00
Markus Reiter
2c71d9dcd8
Use sudo for symlinks if necessary.
2023-05-13 03:42:00 +02:00
JBYoshi
84ad387661
Clean up code for feedback.
2023-05-11 13:29:56 -05:00
JBYoshi
29c9921726
Also use / above.
2023-05-11 12:47:37 -05:00
JBYoshi
d0e64e2c57
Use / for path concatenation.
2023-05-11 12:46:05 -05:00
JBYoshi
2e8232de39
Replace wildcard copy with a loop over children.
...
Fixes one of the errors in https://github.com/orgs/Homebrew/discussions/4498 (specifically "cp: [...].app/*:
No such file or directory").
2023-05-11 11:47:16 -05:00
Markus Reiter
df620ad3ba
Make manual installers easier to open.
2023-05-08 08:25:32 +02:00
Mike McQuaid
0e387fee8c
Merge pull request #15138 from JBYoshi/cask-move-contents
...
Don't remove cask directories when upgrading.
2023-05-04 11:43:44 +01:00
JBYoshi
4935a8fbb2
Remove unreachable warning.
2023-04-30 12:29:40 -05:00
Ilya Kulakov
476d97934f
sudo: change sudo_user to sudo_as_root.
2023-04-28 11:22:54 -07:00
Ilya Kulakov
d470661b37
sudo: add the sudo_user arg to SystemCommand.
2023-04-28 11:11:53 -07:00
Ilya Kulakov
563387a7b4
sudo: explicitly specify the root user where necessary
...
With sudoers one may override default sudo user. This mostly works
provided the admin configured the replacement appropriately. However
there are exceptions that absolutely must be run by root such as
/usr/sbin/installer and, under certain circumstances, /bin/launchctl.
2023-04-28 11:11:53 -07:00
JBYoshi
a1571702d3
Merge remote-tracking branch 'origin/master' into cask-move-contents
2023-04-25 15:44:29 -05:00
Douglas Eichelberger
08af78a2a5
brew style --fix
2023-04-25 09:26:24 -07:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
JBYoshi
432e0c6b5b
Extract artifact checks to matching_artifact? function.
2023-04-24 10:59:01 -05:00
JBYoshi
f97bce040f
Update for feedback.
2023-04-24 10:50:01 -05:00
JBYoshi
2e85f2beb2
Merge remote-tracking branch 'origin/master' into cask-move-contents
2023-04-15 21:37:56 -05:00
EricFromCanada
b9dab243b5
cask/artifact: fix up some definitions
...
And expand the list of artifacts that target: works with.
2023-04-14 15:47:33 -04:00
JBYoshi
9fedaee462
Only keep empty directories when the new version also has them.
2023-04-08 16:13:12 -05:00
Mike McQuaid
63d8de3600
brew style --fix
2023-04-07 19:10:22 +01:00
JBYoshi
dcc4ae76e8
Also keep app directories with "brew reinstall".
2023-04-04 11:36:27 -05:00
JBYoshi
3f8998a4fc
Reset extended attributes of the base directories.
2023-04-03 20:21:37 -05:00
