This will reduce the time it takes for the tap-syntax job
to complete (currently that is the slowest one) and will
allow us to audit casks as well as formulae (casks weren't
getting audited before in CI).
- make the CodeCov CI job informational. We don't want red PRs just
because the coverage varies slightly. We still get comments inline
saying where code coverage is met; this is more useful during review
than a single number and failing status
- make the Triage CI job do less: instead of enforcing a time period for
review window, make it only exist to self-approve PRs for merge and
require a maintainer otherwise to review
- This was failing to push the existing changes if there was nothing to
commit. Add an extra `if`.
```
==> Bumping Sorbet `typed` sigils...
Checking files...
No file to bump from false to true
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[sorbet-files-update 7c3c04e94] sorbet: Update RBI files.
1 file changed, 5 insertions(+), 1 deletion(-)
On branch sorbet-files-update
nothing to commit, working tree clean
Error: Process completed with exit code 1.
```
- The 18.04 runners are deprecated and going away in less than a month.
Today was another scheduled brownout from GitHub
(https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/),
and they've been unmarked as required checks in the branch protections
because the images are unavailable and the jobs were failing.
- However, we still need to test that Homebrew works correctly on
non-latest Ubuntu versions so that we can test that we're correctly
using brewed gcc/glibc, hence upgrading to 20.04 which is still old.
This command was being called with the wrong relative path, so it
silently did nothing. Now that `update-reset` errors out from invalid
arguments, we know that running `update-reset` here is not needed.
- This will stop the `Style/Documentation` filepath includes getting out of
sync with what we declare as a public API, thus ensuring that everything is
documented.
- Maybe we could also add a job here to check that _all_ the paths in the
RuboCop config still exist, but that's for another time.
- Never bother to do `brew cleanup` after `brew install`
- Skip `brew test-bot --only-cleanup-before` in more places it's not
needed
- Move `brew config`/`brew doctor` into the default formula run
(through `brew test-bot --only-setup`)
- Install `buildpulse-test-reporter` rather than letting `brew tests`
do it
- Improve the formatting of the `brew tests` step
- Further shorten the code coverage filenames
- Don't output BuildPulse results upload status unless failed
- Extract update tests into separate tests.
- Make `brew tests --online` run only once in its own job. This job
could be made non-required to fight flakiness.
- Split up the various macOS runs into several steps now that we have
more parallel macOS workers available.
- Cleanup some flaky tests.
