admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
46,362 Commits 15 Branches 471 Tags
Commit Graph

6215 Commits

Author SHA1 Message Date
JBYoshi
d697037aca
Merge remote-tracking branch 'origin/master' into cask-upgrade/wildcards 2023-05-11 17:32:36 -05:00
JBYoshi
5e23a0563a
Switch base case expect() to allow(). 2023-05-11 17:10:41 -05:00
JBYoshi
7a108d3db0
Merge and_call_original instruction into expect() calls. 2023-05-11 17:09:27 -05:00
JBYoshi
84ad387661
Clean up code for feedback. 2023-05-11 13:29:56 -05:00
JBYoshi
a1780c842c
Improve unit test to make sure the sudo version is used. 2023-05-11 12:44:35 -05:00
Markus Reiter
5c9c089b68
Improve #to_str and #to_json for Version::NULL. 2023-05-11 19:16:42 +02:00
JBYoshi
2e8232de39
Replace wildcard copy with a loop over children. 
Fixes one of the errors in https://github.com/orgs/Homebrew/discussions/4498 (specifically "cp: [...].app/*:
No such file or directory").
 2023-05-11 11:47:16 -05:00
Mike McQuaid
04866b6e39
Merge pull request #15392 from reitermarkus/remove-rubocop 
Remove `NoDslVersion` cop.
 2023-05-10 13:13:35 +01:00
Markus Reiter
46b9dba03c
Remove NoDslVersion cop. 2023-05-10 01:02:42 +02:00
Markus Reiter
f7168bf234
Merge pull request #15336 from reitermarkus/version-head-null 
Merge `HeadVersion` and `NullVersion` into `Version`.
 2023-05-10 01:01:21 +02:00
Markus Reiter
8274920217
Rename OS::Mac::Version to MacOSVersion. 2023-05-09 05:08:38 +02:00
Markus Reiter
02dbeb62fc
Refactor RuboCop tests. 2023-05-09 04:28:25 +02:00
Markus Reiter
fe19ddc3a7
Remove Version#empty?. 2023-05-09 01:13:55 +02:00
Markus Reiter
a1efaf1864
Merge HeadVersion and NullVersion into Version. 2023-05-09 01:13:54 +02:00
Markus Reiter
b05de929c6
Merge pull request #15351 from reitermarkus/livecheck-head 
Use `curl_headers` and `curl_output` for `Livecheck` strategies.
 2023-05-09 00:55:34 +02:00
Mike McQuaid
b61d3500aa
Merge pull request #15270 from SMillerDev/feature/livecheck/github_latest_api 
feat: use API for GitHub latest release strategy
 2023-05-08 16:45:41 +01:00
Mike McQuaid
63ad10392d
Merge pull request #15230 from reitermarkus/installer-manual-open 
Make manual installers easier to open.
 2023-05-08 12:46:34 +01:00
Markus Reiter
df620ad3ba
Make manual installers easier to open. 2023-05-08 08:25:32 +02:00
Sam Ford
cfba45fb56
GithubLatest: Use API URL as generated value 
The generated URL should reflect what we're actually checking, which
is now the `/releases/latest` API URL.
 2023-05-07 10:21:48 +02:00
Sean Molenaar
573d87cdfa
feat: use API for GitHub latest release strategy 2023-05-07 10:21:48 +02:00
Markus Reiter
1df501b0ac
Tweak tests. 2023-05-07 10:04:28 +02:00
Markus Reiter
81fdb3716e
Implement StanzaOrder cop using on_cask_stanza_block. 2023-05-07 08:30:29 +02:00
Issy Long
704482d815
wip a test for ordering of both on_* blocks and their contents 
- This is very broken, "detected clobbering" errors.
 2023-05-07 08:29:31 +02:00
Issy Long
bd6e9e72a1
rubocops/cask: Check for correct stanza ordering within on_* blocks 
- Now that we detect correct stanza _grouping_ within `on_*` blocks in
  Casks (PR 15211), correct stanza _ordering_ in `on_*` blocks was the
  next logical step. For example, `url` has to come after `version` and
  `sha256` in an `on_macos` or `on_intel` block for consistency with the
  top-level stanza order we enforce elsewhere.
- Still not doing the nested `on_os` inside `on_arch`, that felt
  excessive for an edge case that isn't present in any actual real
  Casks we have. I removed the test with that specific TODO.
 2023-05-07 08:27:43 +02:00
Markus Reiter
353818f508
Rename curl_head to curl_headers. 2023-05-06 03:41:35 +02:00
Markus Reiter
dfc9d94c5b
Type livecheck.rb. 2023-05-06 03:27:42 +02:00
Mike McQuaid
0e387fee8c
Merge pull request #15138 from JBYoshi/cask-move-contents 
Don't remove cask directories when upgrading.
 2023-05-04 11:43:44 +01:00
Issy Long
40f697e96e
diagnostic: Check for unnecessary Core and Cask taps 
- If the user doesn't have `HOMEBREW_DEVELOPER` or
  `HOMEBREW_NO_INSTALL_FROM_API` set but does have `homebrew/core` or
  `homebrew/cask` taps installed this can cause problems with installing
  outdated software.
- Hence, warn them in `brew doctor` if they have either of these taps
  installed, with instructions on how to remove them.
 2023-04-30 15:25:56 +01:00
Ruoyu Zhong
254941c6f7
rubocops/service: check for more cellar paths 
This is a follow-up to #15154. In addition to `bin`, the `service` block
can also reference other cellar paths like `libexec`. They don't work
with the API either, as reported in
https://github.com/orgs/Homebrew/discussions/4459.

Violations are already corrected in Homebrew/homebrew-core#129736
and Homebrew/homebrew-core#129737.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
 2023-04-30 07:39:25 +08:00
Mike McQuaid
cd683aefa8
Merge pull request #14629 from Kentzo/sudo-user 
sudo: explicitly specify the root user where necessary
 2023-04-29 11:17:21 +01:00
Carlo Cabrera
f3724f00d2
determine-test-runners: fix test 2023-04-29 11:36:31 +08:00
Ilya Kulakov
6a4322833f sudo: Fix tests. 2023-04-28 11:22:54 -07:00
Bo Anderson
44f058edb5
Refactor formula, cask and Ruby source downloads to use shared code 2023-04-27 23:23:07 +01:00
Mike McQuaid
9d5b017bb9
Merge pull request #15322 from carlocab/rm-linux-cleanup 
github_runner_matrix: remove `HOMEBREW_LINUX_CLEANUP`
 2023-04-27 12:28:45 +01:00
Carlo Cabrera
ff728da97b
github_runner_matrix: remove HOMEBREW_LINUX_CLEANUP 
This will allow us to remove handling of this in our workflow files in
Homebrew/core.
 2023-04-27 16:45:51 +08:00
Bo Anderson
a696bd8203
Support multiple oldnames for formulae 2023-04-27 05:15:43 +01:00
Mike McQuaid
6b33197d54
Merge pull request #15313 from carlocab/deps-build-on-github 
github_runner_matrix: test dependents on GitHub runners
 2023-04-27 00:34:54 +01:00
Carlo Cabrera
3bfe3e3037
github_runner_matrix: fix tests 2023-04-27 07:20:58 +08:00
JBYoshi
a1571702d3
Merge remote-tracking branch 'origin/master' into cask-move-contents 2023-04-25 15:44:29 -05:00
Douglas Eichelberger
08af78a2a5 brew style --fix 2023-04-25 09:26:24 -07:00
Carlo Cabrera
f3ff42f9c5
github_runner: fix test 2023-04-25 17:06:17 +08:00
Carlo Cabrera
0c21ad20cd
macos_runner_spec: fix test 2023-04-25 17:05:05 +08:00
Carlo Cabrera
1a86a91c1b
determine-test-runners: fix test 2023-04-25 16:42:02 +08:00
Carlo Cabrera
2568e5aec4
github_runner_matrix: fix test 2023-04-25 16:41:24 +08:00
Douglas Eichelberger
f52cbbb9da
Vendor mechanize gem outside Gemfile 
We only need a single file and it avoids pulling in e.g. `nokogiri`
which is vulnerable.

Allow updating it using `brew vendor-gems`.
 2023-04-24 14:03:55 +01:00
Mike McQuaid
763c41f006
Merge pull request #15290 from apainintheneck/substitute-home-dir-in-caveats 
formulary: sub home placeholder in caveats
 2023-04-24 09:24:05 +01:00
Issy Long
935649abaf
Merge pull request #15263 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rspec-2.20.0 
build(deps): bump rubocop-rspec from 2.19.0 to 2.20.0 in /Library/Homebrew
 2023-04-22 18:58:03 +01:00
apainintheneck
d57f291a1e formulary: sub home placeholder in caveats 
We set a placeholder for the home directory when generating
API JSON so we should substitute the actual home directory
back in when printing caveats locally. This allows people
to use `Dir.home` in caveats and have it display correctly
no matter the platform or operating system.
 2023-04-22 10:17:16 -07:00
Douglas Eichelberger
ec39fe7bb1
Merge pull request #15283 from dduugg/no-false-sigil 
Remove `# typed: false` sigil in tests
 2023-04-21 19:44:09 -07:00
Issy Long
4a87c624d7
Fix new RSpec/IndexedLet offenses 2023-04-22 01:02:38 +01:00