48 Commits

Author SHA1 Message Date
botantony
d3cfc3d193
unpack .dmg: ignore .HFS+ Private* metadata directories
Signed-off-by: botantony <antonsm21@gmail.com>
2025-03-18 12:59:21 +01:00
Carlo Cabrera
86b27eb0f3
unpack_strategy/dmg: more UID handling fixes
Follow-up to #18040.
2024-09-27 17:55:32 +08:00
Bo Anderson
467666c8b3
unpack_strategy/dmg: fix UID handling 2024-08-13 17:50:34 +01:00
Issy Long
af6e1194d2
unpack_strategy/dmg: Convert to Sorbet typed: strict
- I missed this, whoops.
2024-07-11 21:34:26 -04:00
Issy Long
9c6430954b
All the extract_to_dirs return void now 2024-07-11 11:05:47 +01:00
Douglas Eichelberger
4ebf1116d7 Introduce UnpackStrategyImpl 2024-07-08 12:56:19 +01:00
Mike McQuaid
0bbfa434cf
unpack_strategy/dmg: fix permissions when needed.
`ditto` behaves weirdly when the EUID is different from the UID. This
fix ensures that the BOM file is written with the correct permissions
in this case.
2024-04-01 09:49:10 +01:00
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args. 2024-03-07 16:20:20 +00:00
Bo Anderson
1d7101d8a3
Use HOMEBREW_TEMP more universally 2024-02-26 16:58:53 +00:00
Issy Long
f4218a6316
Fix RuboCop Performance/MapCompact offenses
- Rename an iterator variable since it would make the line too long.
2024-02-25 22:59:59 +00:00
Douglas Eichelberger
eb7c3e52a0 Require SystemInclude only where needed 2024-01-31 11:42:01 -08:00
Douglas Eichelberger
24cf6076e8 brew style --fix 2023-04-24 20:42:39 -07:00
Douglas Eichelberger
f38a672938 brew style --fix 2023-03-21 17:37:48 -07:00
Douglas Eichelberger
82dc57dfea Enable UnpackStrategy types 2023-03-21 17:37:46 -07:00
Markus Reiter
c6a5d79ef9
Remove explicit error for empty BOM retry. 2023-03-21 00:39:26 +01:00
Markus Reiter
1e0e12cc43
Retry if DMG BOM is empty. 2023-03-13 18:32:56 +01:00
Mike McQuaid
6a25229567
brew style --fix 2023-01-02 19:18:51 +00:00
Michael Cho
1a398f9aaf cask install: increase APFS test sleep to avoid slow eject fail 2021-04-03 10:21:50 -07:00
Michael Cho
cf8d96e0b2 cask install: fix APFS DMG eject to use physical disk 2021-03-29 19:59:20 -07:00
Bo Anderson
323ff660fa rubocop: use consistent array/hash indentation 2021-02-11 13:27:42 +00:00
EricFromCanada
571179ff0e pass second argument to ohai when applicable 2021-01-26 15:36:43 -05:00
Markus Reiter
794b128969 Work around BOM find bug. 2020-11-26 14:13:01 +01:00
Markus Reiter
db980464f6 Try retrying BOM find command. 2020-11-25 22:36:29 +01:00
Markus Reiter
daea3c090e Add debug output of find command when creating BOM. 2020-11-25 19:37:36 +01:00
Markus Reiter
b9fc7e100b Add more BOM debug information. 2020-11-24 22:12:17 +01:00
Markus Reiter
c324155295 Add debug information for empty BOM error. 2020-11-24 18:26:15 +01:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
miccal
54e4be2f64 unpack_strategy/dmg: remove deprecated IDME attach flag 2020-09-19 21:20:25 +08:00
Markus Reiter
0e7f18a51e Document UnpackStrategy. 2020-08-26 03:13:58 +02:00
Markus Reiter
cc234d1948 Fix Dmg detection. 2019-10-14 10:44:52 +02:00
Markus Reiter
67d51ef0e1 Fix Dmg being detected as Tar. 2019-10-13 17:19:02 +02:00
Markus Reiter
9a1e3fbab4 Fix #system_dir_symlink? not working when target doesn't exist. 2019-10-09 11:15:48 +02:00
L. E. Segovia
8ec48b0c72
Fix symlink validation in Mojave 2019-10-06 23:27:24 +00:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
Markus Reiter
edb8a2486b Remove -quiet flag when verbose. 2018-11-02 11:46:06 +01:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Markus Reiter
81939dc496 Pass verbose to unpack strategies. 2018-08-02 15:52:55 +02:00
Markus Reiter
281ead3096 Look for extension first, then fall back to magic number. 2018-08-01 00:56:36 +02:00
Markus Reiter
e8f7a88976 Only call hdiutil if it’s a bzip2 or zlib. 2018-08-01 00:56:36 +02:00
Markus Reiter
83a1e8dd97 Refactor UnpackStrategy::Dmg. 2018-07-24 16:44:27 +02:00
Markus Reiter
eccd20e276 Merge Hbc::Container classes into UnpackStrategy. 2018-07-24 16:44:27 +02:00