3424 Commits

Author SHA1 Message Date
ilovezfs
cebe137499 audit: exempt wine's deps from the universal deprecation
This can be reverted when wine's dependencies are all vendored.
2017-01-20 07:18:51 -08:00
Gautham Goli
0b3d9031e2 Add --fix option to brew audit command 2017-01-18 22:35:37 +05:30
Mike McQuaid
9f183be358 Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
4f0505f759 audit: only warn on versioned conflicts_with.
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
This would have eliminated the need for Homebrew/homebrew-core#9000, for
instance.
2017-01-17 10:26:01 -05:00
Mike McQuaid
dac66c4ada Add keg_only :versioned_formula.
This is used to indicate a formula is a version of another formula.
This will be used to provide a consistent interface for older formulae
versions and replaces the use of `conflicts_with`.
2017-01-17 10:50:04 +00:00
Mike McQuaid
aa104137e5 Merge pull request #1844 from MikeMcQuaid/audit-universal
audit: don't allow universal for new formulae.
2017-01-17 10:08:44 +00:00
Mike McQuaid
feea90c0dd create: handle null versions.
Fixes #1821
2017-01-16 20:15:32 +00:00
Mike McQuaid
f4496e85e5 audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.
2017-01-15 02:31:11 -08:00
ilovezfs
9dca10f9dc audit: whitelist unstable versions already in core
also allow higher stable versions with the same version prefix
2017-01-13 18:59:23 -08:00
William Woodruff
82c046b3e1
audit: Check for invocations of cctools.
Now that ruby-macho is available, cctools should be invoked as little
as possible.
2017-01-11 23:07:26 -05:00
Mike McQuaid
9cce3414fb Merge pull request #1806 from MikeMcQuaid/audit-virtualenv-setuptools
audit: check virtualenv and setuptools resource.
2017-01-09 14:08:30 +00:00
Mike McQuaid
346d68eb04 audit: check virtualenv and setuptools resource.
`virtualenv_install_with_resources` will automatically define and
install a `setuptools` resource so this is unnecessary.

References https://github.com/Homebrew/homebrew-core/pull/8570
2017-01-09 13:24:51 +00:00
Mike McQuaid
c276a44eba bump-formula-pr: check for URL presence.
If it's not there, produce a nicer error.

Fixes #1805.
2017-01-09 12:16:55 +00:00
Mike McQuaid
e7a81caaf4 Allow brew audit to fake a Safari user-agent.
This allows us to detect if homepages such as e.g. `aiccu` which
blocks `curl` are up or not.
2017-01-07 14:03:08 +00:00
Mike McQuaid
a3bffe70bc Use docs.brew.sh links. 2017-01-04 11:13:41 +00:00
Mike McQuaid
d7ab913f31 audit: deprecate env :std/:userpaths for strict.
This should apply only for new formulae but we should start gradually
phasing it out for older ones too.
2017-01-03 22:12:21 +00:00
Mike McQuaid
b3c6334d3c audit: use new curl_args form.
This will use Curl’s default user agent to reduce homepage errors and
provides a function that can be used for other audits to perform
similar tests on URLs.
2016-12-30 20:17:34 +00:00
Mike McQuaid
59180ec370 audit: improve reliability of homepage audit.
- Don't run on Yosemite where the system Curl is too old for some modern
  HTTPS homepages
- Try up to 3 times in case of transient failures.
2016-12-29 12:51:12 +00:00
Mike McQuaid
8ffe231f44 audit: don't allow openssl & libressl dependency.
Formulae should not depend on both OpenSSL and LibreSSL (even
optionally). This is to avoid descending into madness where every
formulae that could use LibreSSL has to have option and switching logic.

Homebrew has standardised on OpenSSL and will do so everywhere that
LibreSSL is not a hard requirement.
2016-12-29 11:46:51 +00:00
Mike McQuaid
5b806c09ae Merge pull request #1719 from zmwangx/strip-x11-from-new-formula-template
create: remove :x11 dep from new formula template
2016-12-23 19:51:12 +00:00
Mike McQuaid
9bfeb91562 Merge pull request #1715 from zmwangx/bump-formula-pr-fix-removal-of-old-mirror
bump-formula-pr: fix removal of old mirrors
2016-12-23 19:42:31 +00:00
Mike McQuaid
161bd20fcd Merge pull request #1663 from tschoonj/meson-create-support
brew create: add meson support
2016-12-23 19:24:15 +00:00
Mike McQuaid
cd13e306a8 Merge pull request #1693 from broder/homepage_check
Updated homepage 404 check to use explicit parameters and return the …
2016-12-23 19:14:08 +00:00
David Broder-Rodgers
3c566399cf Added check for insecure mirror URLs 2016-12-23 14:55:08 +00:00
Zhiming Wang
1ab8b5e35b
create: remove :x11 dep from new formula template 2016-12-22 18:57:57 -05:00
Zhiming Wang
3ebd7df62d
bump-formula-pr: fix removal of old mirrors
Previously, old mirrors are only removed if the requested spec is
stable, and if the mirror lines only have two leading spaces. This leads
to stale mirror line(s) when the formula a stable block like

    stable do
      url "http://example.com/v1.0.tar.gz"
      mirror "http://example.net/v1.0.tar.gz"
    end

where the mirror line is lead by four spaces.

In this commit, we discard the /(^ mirror .*\n)?/ pattern, and instead
create a pattern with the exact url and flexible leading spaces for each
mirror of the requested spec.
2016-12-22 00:54:08 -05:00
Mike McQuaid
8f85eb64c4 audit: fix 32-bit check. 2016-12-20 14:26:53 +00:00
Mike McQuaid
ef6b55125c Merge pull request #1695 from MikeMcQuaid/audit-revision-map-nil
audit: handle a nil revision map.
2016-12-20 10:55:41 +00:00
Mike McQuaid
1d2390b2de Merge pull request #1698 from MikeMcQuaid/deprecate-32-bit
Deprecate 32-bit options.
2016-12-20 10:54:54 +00:00
Mike McQuaid
f98304026b Deprecate 32-bit options.
These were formerly supported but as it has been a very long time since
32-bit software was necessary on macOS these have been deprecated with
a `brew audit` warning and a future `odeprecated`.
2016-12-20 10:22:30 +00:00
Tom Schoonjans
cc09bb14c1 brew create: add meson support
meson is quickly gaining popularity as build system, in combination with
ninja. Several Gnome projects for example are currently transitioning
from autotools to meson, mostly because it allows for Visual Studio
builds, which is impossible to accomplish with autotools.

In order to facilitate generating meson based Formulas, I added support
for meson to brew-create.
2016-12-19 21:51:57 +01:00
David Broder-Rodgers
637aae48e4 Markups 2016-12-19 08:45:21 +00:00
Mike McQuaid
41a248786f audit: handle a nil revision map. 2016-12-18 15:46:02 -08:00
Mike McQuaid
339ff9400f audit: don't allow use of OS.mac?/OS.linux?.
Forbid their use in Homebrew/core which only supports macOS. This may
be added to more/all official taps in future.
2016-12-18 15:30:06 -08:00
David Broder-Rodgers
0a007fc983 Updated homepage 404 check to use explicit parameters and return the status code 2016-12-18 22:37:26 +00:00
Mike McQuaid
61e370fb7a create: handle Version::NULL correctly.
Fixes #1688.
2016-12-18 13:32:29 -08:00
Mike McQuaid
cf1fa0c5bc audit: flag use of "fails_with :llvm".
Also, add TODOs for deprecating this properly at a later point.
2016-12-13 02:10:11 +00:00
Mike McQuaid
60b1be6795 Merge pull request #1629 from zmwangx/bump-formula-pr-download-to-correct-version
bump-formula-pr: use correct version in download path when --version is specified
2016-12-07 22:09:54 +00:00
Zhiming Wang
417f27f40f
bump-formula-pr: use correct version in download
When a --version is specified, use this specified version in the name of
the downloaded file rather than the default that is parsed from the URL.
For instance,

  brew bump-formula-pr --devel \
    --url=http://www.zsh.org/pub/development/zsh-5.2-test-2.tar.gz \
    --version=5.2-test-2 zsh

should download to $HOMEBREW_CACHE/zsh-5.2-test-2.tar.gz (correct
behavior after this commit) rather than
$HOMEBREW_CACHE/zsh-2.tar.gz (wrong behavior before this commit).
2016-12-06 17:30:10 -05:00
Zhiming Wang
59f926cfd3
boneyard-formula-pr: checkout last branch when done
Make its behavior more consistent with that of bump-formula-pr.
2016-12-06 15:20:04 -05:00
Zhiming Wang
0fe532c242
boneyard-formula-pr: use ohai to print messages
Make its behavior more consistent with that of bump-formula-pr.
2016-12-06 15:19:51 -05:00
Mike McQuaid
0d8fc920d6 tap-new: use latest Travis CI recommended config.
Pretty sure no-one cares about this except me but this works
consistently across a variety of different taps and is faster than the
old version.
2016-12-03 13:47:52 +00:00
Mike McQuaid
22b121c4c1 tap-new: cleanup and update Travis configuration.
- Use macOS Sierra 10.12 and Xcode 8.
- Add indentation.
2016-11-26 16:30:43 +00:00
Mike McQuaid
1980af52de audit: allow deprecated options on new @ formulae.
As these may be migrations from another tap where we want to migrate
options across correctly.
2016-11-23 11:03:10 +00:00
Mike McQuaid
c3f959d6af Merge pull request #1542 from woodruffw/deprecate-utils-json
compat: deprecate Utils::JSON in favor of corelib JSON.
2016-11-21 18:45:20 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
William Woodruff
4a9601ab82
audit: check formula name against blacklisted names. 2016-11-20 00:40:54 -05:00
Mike McQuaid
5e073f1f40 Merge pull request #1528 from MikeMcQuaid/audit-devel-revision
audit: don't check devel version_scheme/revision.
2016-11-18 13:53:22 +00:00
Mike McQuaid
f4810e4eb1 Merge pull request #1530 from MikeMcQuaid/audit-homebrew-prefix-test-path
audit: check for HOMEBREW_PREFIX test path usage.
2016-11-18 12:37:46 +00:00