admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
46,507 Commits 15 Branches 471 Tags
Commit Graph

306 Commits

Author SHA1 Message Date
Eric Knibbe
626b6aca2d
RubyDoc output fixes 2025-08-05 17:13:42 -04:00
Patrick Linnane
4513a43d53
Fix RuboCop failures. 
Co-authored-by: Patrick Linnane <patrick@linnane.io>
Co-authored-by: Carlo Cabrera <github@carlo.cab>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2025-07-14 19:12:38 +01:00
Mike McQuaid
9375fc21f4
requirements: set typed: strict 2025-06-17 16:34:59 +01:00
Mike McQuaid
7345607ca0
a*.rb: move to strict Sorbet sigil. 
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
 2025-06-17 08:18:33 +01:00
Eric Knibbe
5027a9d2f2
cask/audit: skip audit_rosetta on Intel-only casks & OSes 2025-05-21 10:14:08 -04:00
Issy Long
45978435e7
rubocop: Use Sorbet/StrictSigil as it's better than comments 
- Previously I thought that comments were fine to discourage people from
  wasting their time trying to bump things that used `undef` that Sorbet
  didn't support. But RuboCop is better at this since it'll complain if
  the comments are unnecessary.

- Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501.

- I've gone for a mixture of `rubocop:disable` for the files that can't
  be `typed: strict` (use of undef, required before everything else, etc)
  and `rubocop:todo` for everything else that should be tried to make
  strictly typed. There's no functional difference between the two as
  `rubocop:todo` is `rubocop:disable` with a different name.

- And I entirely disabled the cop for the docs/ directory since
  `typed: strict` isn't going to gain us anything for some Markdown
  linting config files.

- This means that now it's easier to track what needs to be done rather
  than relying on checklists of files in our big Sorbet issue:

```shell
$ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l
    268
```

- And this is confirmed working for new files:

```shell
$ git status
On branch use-rubocop-for-sorbet-strict-sigils
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Library/Homebrew/bad.rb
        Library/Homebrew/good.rb

nothing added to commit but untracked files present (use "git add" to track)

$ brew style
Offenses:

bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true.
^^^^^^^^^^^^^

1340 files inspected, 1 offense detected
```
 2024-08-12 15:24:27 +01:00
Eric Knibbe
f627c6331d
cask/audit: support on_os blocks in audit_min_os 2024-06-21 19:25:51 -04:00
Eric Knibbe
2d00e50071
cask: skip variations for inapplicable versions 2024-06-03 12:33:00 -04:00
Mike McQuaid
6e9288470e
brew style --fix 2024-05-23 17:15:43 +01:00
Markus Reiter
caf87c0336
Warn about undocumented non-private APIs. 2024-05-01 11:35:20 +02:00
Markus Reiter
0f0055ede4
Make documentation @api private by default. 2024-04-26 19:04:20 +02:00
Markus Reiter
fe4ef62aa9
Hide #inspect in docs. 2024-04-26 13:20:05 +02:00
Mike McQuaid
7da934f7e2
Deprecate/disable/delete code. 
The next release after this is merged will be 4.1.0.

Co-authored-by: Markus Reiter <me@reitermark.us>
 2023-07-06 16:56:20 +01:00
Markus Reiter
8274920217
Rename OS::Mac::Version to MacOSVersion. 2023-05-09 05:08:38 +02:00
Douglas Eichelberger
24cf6076e8 brew style --fix 2023-04-24 20:42:39 -07:00
Carlo Cabrera
ffcc4cd75f
Merge remote-tracking branch 'origin/master' into test-runners 2023-04-05 23:55:01 +08:00
Douglas Eichelberger
a237a1ff9f Update call sites 2023-04-04 18:14:54 -07:00
Carlo Cabrera
a4ebb96fe6
Remove MacOS definition from generic OS 
We don't want to define `MacOS` in the generic OS, so let's make sure we
refer to it as `OS::Mac` in the places we need it.

This reverts commit 575cb0263cb1428c63b9428bbd913ffde83bd317.
 2023-04-04 23:10:51 +08:00
Nanda H Krishna
f03e462995
xcode_requirement: improve outputs 2023-03-07 14:12:40 -05:00
Nanda H Krishna
56703a49ed
macos_requirement: fix version_specified?, improve outputs 2023-03-07 14:12:40 -05:00
Bo Anderson
e86a8c2477
Move HOMEBREW_NO_INSTALL_FROM_API defaults to shell 2023-02-24 21:53:08 +00:00
Douglas Eichelberger
4deb4c1813
Enable typing in Requirement classes 2023-02-15 14:22:03 +00:00
Bo Anderson
9eac310468
Allow multiple macOS requirements 2022-11-09 01:19:46 +00:00
Mike McQuaid
f43e9b6c04
os/mac/version: remove Yosemite. 
It's no longer possible to run Homebrew there.

Co-authored-by: Bo Anderson <mail@boanderson.me>
 2022-06-06 05:18:53 +01:00
Mike McQuaid
d73351251c
Deprecate, disable, delete code for next major/minor version. 
Do the usual dance for bumping our major/minor version.
 2021-04-09 09:30:36 +01:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
hyuraku
5181405d5c requirements/java_requirement: delete adoptopenjdk condition 2021-01-29 22:25:12 +09:00
Mike McQuaid
74fb058c7e
More deprecations 
More deprecations, disabling and removal for Homebrew 2.7.0.
 2020-12-18 14:17:37 +00:00
Mike McQuaid
87dd13aea6
Deprecate cask requirements. 
This probably has to wait until 2.7.0 now and will require a bunch of
formula changes/deprecations but we should probably start moving in this
direction given we're not installing any of these on our CI any more.
 2020-12-15 14:19:45 +00:00
Markus Reiter
5be4c9b5e0 Upgrade typed sigils. 2020-11-25 17:04:19 +01:00
Mike McQuaid
f364f0c841
Merge remote-tracking branch 'origin/master' into deprecate-cask-commands 2020-11-25 09:39:00 +00:00
Mike McQuaid
d496f5c121
Deprecations for Homebrew 2.6.0 
Do the usual deprecate/disable dance for the Homebrew 2.6.0 release.

Not to be merged until the next release will definitely be 2.6.0.
 2020-11-24 16:44:02 +00:00
Markus Reiter
3c2ec1c60f Deprecate remaining cask commands. 2020-11-21 19:56:12 +01:00
EricFromCanada
4f330c5e19 macos_requirement: fix display of versions as array 2020-11-16 23:22:18 -05:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
EricFromCanada
5c6a12e5b7 requirements: allow depends_on arch: :arm64 2020-11-07 11:00:41 -05:00
EricFromCanada
212367c1c0 requirements: reword error messages for consistency 
also add formatting to download URLs
 2020-11-01 15:20:02 -05:00
EricFromCanada
635233b37e requirements: reword inspect() to place tags at end 
This more closely matches requirements' display in the DSL.
 2020-11-01 15:20:02 -05:00
EricFromCanada
a232ac8b1e requirements: improve display in brew info 2020-11-01 15:20:02 -05:00
EricFromCanada
f4aeb3e956 arch_requirement: update and add to JSON representation of formulae 2020-11-01 11:57:00 -05:00
Michka Popoff
3aec8a0398 xcode_requirement: support linux 
2020-10-12T21:29:03.7866574Z [31mError:[0m undefined method `latest_version' for OS::Mac::Xcode:Module
2020-10-12T21:29:03.7867686Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/requirements/xcode_requirement.rb:33:in `message'
2020-10-12T21:29:03.7868902Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:199:in `map'
2020-10-12T21:29:03.7870227Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:199:in `satisfied_requirements?'
2020-10-12T21:29:03.7871547Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:593:in `formula!'
2020-10-12T21:29:03.7873156Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:20:in `block in run!'
2020-10-12T21:29:03.7875029Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:19:in `each'
2020-10-12T21:29:03.7876299Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/formulae.rb:19:in `run!'
2020-10-12T21:29:03.7877495Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:119:in `run_tests'
2020-10-12T21:29:03.7878705Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:36:in `block in run!'
2020-10-12T21:29:03.7879908Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/delegate.rb:83:in `each'
2020-10-12T21:29:03.7881136Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/delegate.rb:83:in `method_missing'
2020-10-12T21:29:03.7882519Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:25:in `run!'
2020-10-12T21:29:03.7883735Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_bot.rb:126:in `run!'
2020-10-12T21:29:03.7884875Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/cmd/test-bot.rb:75:in `test_bot'
2020-10-12T21:29:03.7885882Z /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'
 2020-10-26 22:22:16 +01:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Mike McQuaid
2e5272d04c Deprecate/disable code for Homebrew 2.5.0. 
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
 2020-09-03 10:34:22 +01:00
Markus Reiter
a9c271ddba Document XcodeRequirement. 2020-08-26 03:13:59 +02:00
Markus Reiter
481eb098c2 Document X11Requirement. 2020-08-26 03:13:59 +02:00
Markus Reiter
22eee27926 Document TuntapRequirement. 2020-08-26 03:13:59 +02:00
Markus Reiter
918eeb5493 Document OsxfuseRequirement. 2020-08-26 03:13:59 +02:00
Markus Reiter
f755e084d8 Document MacOSRequirement. 2020-08-26 03:13:59 +02:00
Markus Reiter
497a622654 Document LinuxRequirement. 2020-08-26 03:13:59 +02:00