2402 Commits

Author SHA1 Message Date
Max Mueggler
23376bad75
Speed up cask pkg uninstallation when there's many directories to delete.
Results in an order of magnitude speedup for uninstalling large packages such as mactex.
2021-04-02 03:01:07 +02:00
Markus Reiter
571208c8ee
Only call find on directories. 2021-04-02 03:01:07 +02:00
Markus Reiter
d2a3944e70
Skip url do URLs in offline audit. 2021-04-02 01:55:35 +02:00
Markus Reiter
0b6b05d1aa
Implement nested url do API. 2021-04-02 01:41:44 +02:00
Markus Reiter
3f4706d9e6
Don't suggest adding unnecessary appcast. 2021-03-31 08:13:48 +02:00
Mike McQuaid
a2099461dc
cask/dsl/version: remove another invalid character 2021-03-30 16:29:03 +01:00
Mike McQuaid
9b725a5851
cask/dsl/version: reject invalid characters.
There was a `invalid_characters` method already but it was not being
used.
2021-03-30 14:15:14 +01:00
Michael Cho
a0261c4b39 cask uninstall script: allow tilde expansion to '$HOME' 2021-03-28 09:52:49 -07:00
Nanda H Krishna
eecbd5887c
Apply suggestion from review
Co-authored-by: Markus Reiter <me@reitermark.us>
2021-03-26 02:28:51 +05:30
nandahkrishna
94737ef41d
cask: add password warning for pkg uninstall 2021-03-26 00:11:39 +05:30
Rylan Polster
57b2660cae
Revert "Merge pull request #10864 from reitermarkus/command-timeout"
This reverts commit d55bdd3ddbe7ff2b1f106a41bd994dc117ca5142, reversing
changes made to 3c3bf1c74d1d7ef1d2c792719574623b6c3c4d25.
2021-03-24 01:22:18 -04:00
Rylan Polster
b4a36bef64
audit: fix --display-failures-only failure messaging 2021-03-22 22:20:04 -04:00
Rylan Polster
2b8d19e0bd
audit: limit non-failure cask output 2021-03-22 22:16:54 -04:00
Markus Reiter
3c6a7b39e2
Merge pull request #10894 from reitermarkus/mandatory-livecheck
Make `livecheck` audit mandatory for versioned casks.
2021-03-23 01:34:00 +01:00
Markus Reiter
1e55837c53
Merge pull request #10893 from reitermarkus/new-casks-livecheck
New casks should use `livecheck`.
2021-03-23 01:16:37 +01:00
Markus Reiter
41fec99591 Make livecheck audit mandatory for versioned casks. 2021-03-23 01:11:35 +01:00
Bo Anderson
32d532fb49
cmd/list: fix Cask listing 2021-03-22 16:21:02 +00:00
Bo Anderson
25373a18cc
Merge pull request #10880 from Bo98/cli-stronger-types
Stricter handling of CLI args
2021-03-22 14:13:01 +00:00
Markus Reiter
b0fd4831d5 New casks should use livecheck. 2021-03-20 22:20:55 +01:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Mike McQuaid
d55bdd3ddb
Merge pull request #10864 from reitermarkus/command-timeout
Allow specifying timeouts for commands and downloads.
2021-03-18 13:15:42 +00:00
Lucendio
aceb021254 Move existence check into helper script
This way, it'll run as `root`, too.
2021-03-17 01:42:56 +01:00
Lucendio
7a22cda8dd
Fix broken rmdir script
Unfortunately, the removal shell script introduced in #10860 does not handle paths very well that dont exist, e.g.

* `find` runs before its `-exec` test, thus throws `find: "${path}": No such file or directory`
* it seem that `/bin/rmdir` is intended to break is certain cases, thus `-f` is not desired.
  so, if `${path}` does not exist, it'll still break, which is most likely not one of those cases.

This change reintroduces a check for existence. This way, it is ensured that there is actually
a directory to be removed when invoking the script.
2021-03-17 00:35:08 +01:00
Markus Reiter
712a95fdd0 Allow specifying timeouts for commands and downloads. 2021-03-16 18:15:21 +01:00
Markus Reiter
1a4874dc62 Simplify package uninstallation. 2021-03-16 03:00:14 +01:00
Cassidy Marble
267040e5df
bugfix: Add args and options to lazy url block 2021-03-12 10:26:59 -07:00
Nanda H Krishna
1e3dab1401
Merge pull request #10831 from nandahkrishna/cask-autotap
cask_loader: do not auto-tap in FromTapLoader
2021-03-12 20:10:38 +05:30
nandahkrishna
585ec90878
cask_loader: do not auto-tap in FromTapLoader 2021-03-11 21:09:42 +05:30
Markus Reiter
65d1747b29 Check homepage with both browser and default user agent. 2021-03-11 16:19:21 +01:00
Mike McQuaid
9663567501
Fix brew style. 2021-03-01 13:43:47 +00:00
Seeker
880a82d21a
uninstall: delete references to unused --binaries flag 2021-02-22 19:48:43 -08:00
nandahkrishna
a0b7580dc4
Fix eql? in Cask::Cask 2021-02-17 01:18:25 +05:30
Nanda H Krishna
b9cbeb3019
Merge pull request #10608 from nandahkrishna/assignment-condition-parentheses
style: use parentheses for assignment in conditions
2021-02-15 18:43:54 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Bo Anderson
323ff660fa rubocop: use consistent array/hash indentation 2021-02-11 13:27:42 +00:00
Carlos Álvaro
aebf4c9100
Safe access to tap attributes
Prevent calling name tap attribute when the tap is nil

Co-Authored-By: Rylan Polster <rslpolster@gmail.com>
2021-02-08 13:20:41 +01:00
Carlos Álvaro
84d80cf0bf
Add tap to cask json output 2021-02-08 13:20:40 +01:00
Carlos Álvaro
4f5f3824c6
Add full_token to cask json output 2021-02-08 13:20:40 +01:00
nandahkrishna
d0200e8737
cask/config: fix explicit_s 2021-02-03 13:37:53 +05:30
Mike McQuaid
851bf9aab9
Merge pull request #10465 from vitorgalvao/no-desc-fonts
cask audit: do not require description for fonts
2021-02-02 16:35:26 +00:00
Vítor Galvão
e3d515105b cask audit: do not require description for fonts 2021-02-02 14:06:11 +00:00
EricFromCanada
f39fb5d6b2 cask/config: new method for cask.config.explicit as string 2021-02-01 10:44:19 -05:00
Mike McQuaid
861da37f55
Merge pull request #10456 from SeekingMeaning/cask-audit-format-url
cask/audit: underline URLs in audit errors
2021-02-01 09:05:53 +00:00
Mike McQuaid
b8d55e5a77
Merge pull request #10397 from MikeMcQuaid/deprecations-disables
Homebrew 3.0.0 deprecations/disables
2021-02-01 08:37:22 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
Seeker
571a13b99e cask/audit: underline URLs in audit errors 2021-01-28 16:17:40 -08:00
Seeker
00e5e1f9fc cask/audit: error if verified does not match, regardless of url 2021-01-28 15:27:00 -08:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00