From fff2c3ea794915f5ef900fd8ec26e87ac966b225 Mon Sep 17 00:00:00 2001 From: Anatoli Babenia Date: Fri, 11 Apr 2025 17:14:21 +0300 Subject: [PATCH] edit: move no_env and no_install checks out of the loop --- Library/Homebrew/dev-cmd/edit.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/dev-cmd/edit.rb b/Library/Homebrew/dev-cmd/edit.rb index 92e6ac6955..ed1b040e06 100644 --- a/Library/Homebrew/dev-cmd/edit.rb +++ b/Library/Homebrew/dev-cmd/edit.rb @@ -64,19 +64,18 @@ module Homebrew exec_editor(*paths) is_formula = T.let(false, T::Boolean) - if paths.any? do |path| + show_hint = !Homebrew::EnvConfig.no_env_hints? + if show_hint && paths.any? do |path| next if path == "--project" - break if Homebrew::EnvConfig.no_install_from_api? - break if Homebrew::EnvConfig.no_env_hints? - is_formula = core_formula_path?(path) is_formula || core_cask_path?(path) || core_formula_tap?(path) || core_cask_tap?(path) end from_source = " --build-from-source" if is_formula + no_api = "HOMEBREW_NO_INSTALL_FROM_API=1 " unless Homebrew::EnvConfig.no_install_from_api? puts <<~EOS To test your local edits, run: - HOMEBREW_NO_INSTALL_FROM_API=1 brew install#{from_source} --verbose --debug #{args.named.join(" ")} + #{no_api}brew install#{from_source} --verbose --debug #{args.named.join(" ")} EOS end end