admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18151 from Homebrew/speed-up-cask-files-by-name

Browse Source 
Speed up `CoreCaskTap#cask_files_by_name`
This commit is contained in:
Bo Anderson 2024-08-24 20:17:11 +01:00 committed by GitHub
commit ff8bb50cfa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/tap.rb
View File

@ -1427,12 +1427,16 @@ class CoreCaskTap < AbstractCoreTap
def cask_files_by_name def cask_files_by_name
return super if Homebrew::EnvConfig.no_install_from_api? return super if Homebrew::EnvConfig.no_install_from_api?
@cask_files_by_name ||= Homebrew::API::Cask.all_casks.each_with_object({}) do |item, hash| @cask_files_by_name ||= begin
tap_path = path.to_s
Homebrew::API::Cask.all_casks.each_with_object({}) do |item, hash|
name, cask_hash = item name, cask_hash = item
# If there's more than one item with the same path: use the longer one to prioritise more specific results. # If there's more than one item with the same path: use the longer one to prioritise more specific results.
existing_path = hash[name] existing_path = hash[name]
new_path = path/cask_hash["ruby_source_path"] # Pathname equivalent is slow in a tight loop
hash[name] = new_path if existing_path.nil? || existing_path.to_s.length < new_path.to_s.length new_path = File.join(tap_path, cask_hash.fetch("ruby_source_path"))
hash[name] = Pathname(new_path) if existing_path.nil? || existing_path.to_s.length < new_path.length
end
end end
end end