admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Don't query analytics for third-party formulae/casks in brew info

Browse Source
This commit is contained in:
Rylan Polster 2025-08-11 18:54:09 -04:00
parent cd5cd2d04d
commit ff5edb73c2
No known key found for this signature in database
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cask/info.rb
View File

@ -36,6 +36,8 @@ module Cask
def self.info(cask, args:) def self.info(cask, args:)
puts get_info(cask) puts get_info(cask)
return unless cask.tap.core_cask_tap?
require "utils/analytics" require "utils/analytics"
::Utils::Analytics.cask_output(cask, args:) ::Utils::Analytics.cask_output(cask, args:)
end end

6
Library/Homebrew/cmd/info.rb
View File

@ -159,9 +159,9 @@ module Homebrew
case obj case obj
when Formula when Formula
Utils::Analytics.formula_output(obj, args:) Utils::Analytics.formula_output(obj, args:) if obj.core_formula?
when Cask::Cask when Cask::Cask
Utils::Analytics.cask_output(obj, args:) Utils::Analytics.cask_output(obj, args:) if obj.tap.core_cask_tap?
when FormulaOrCaskUnavailableError when FormulaOrCaskUnavailableError
Utils::Analytics.output(filter: obj.name, args:) Utils::Analytics.output(filter: obj.name, args:)
else else
@ -380,6 +380,8 @@ module Homebrew
ohai "Caveats", caveats_string ohai "Caveats", caveats_string
end end
return unless formula.core_formula?
Utils::Analytics.formula_output(formula, args:) Utils::Analytics.formula_output(formula, args:)
end end

4
Library/Homebrew/utils/analytics.rb
View File

@ -329,6 +329,8 @@ module Utils
require "api" require "api"
return unless Homebrew::API::Formula.all_formulae.key? formula.name
json = Homebrew::API::Formula.formula_json formula.name json = Homebrew::API::Formula.formula_json formula.name
return if json.blank? || json["analytics"].blank? return if json.blank? || json["analytics"].blank?
@ -345,6 +347,8 @@ module Utils
require "api" require "api"
return unless Homebrew::API::Cask.all_casks.key? cask.token
json = Homebrew::API::Cask.cask_json cask.token json = Homebrew::API::Cask.cask_json cask.token
return if json.blank? || json["analytics"].blank? return if json.blank? || json["analytics"].blank?