From ff2ce2f0936bf5a271a1fbdf834f55b94c08062a Mon Sep 17 00:00:00 2001 From: Caleb Xu Date: Sat, 25 Aug 2018 13:35:08 -0400 Subject: [PATCH] extract: better success message Fixes the empty rev string when copying file from HEAD; explicitly set rev to HEAD in that case. --- Library/Homebrew/dev-cmd/extract.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/extract.rb b/Library/Homebrew/dev-cmd/extract.rb index fb0066d347..8c9239b167 100644 --- a/Library/Homebrew/dev-cmd/extract.rb +++ b/Library/Homebrew/dev-cmd/extract.rb @@ -95,6 +95,7 @@ module Homebrew odie "Could not find #{name}! The formula or version may not have existed." if test_formula.nil? result = Git.last_revision_of_file(repo, file, before_commit: rev) elsif File.exist?(file) + rev = "HEAD" version = Formulary.factory(file).version result = File.read(file) else @@ -122,7 +123,7 @@ module Homebrew ohai "Overwriting existing formula at #{path}" if ARGV.debug? path.delete end - ohai "Writing formula for #{name} from #{rev} to #{path}" + ohai "Writing formula for #{name} from revision #{rev} to #{path}" path.write result end