From fef8b0871de845dd7e9f5f6a40dbcda7620a4960 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 18 Sep 2014 21:48:54 -0500 Subject: [PATCH] Remove obsolete nil guard This was added in 3a7a3619f7016c75c3e53e944221bf7f6354a63b to make the tests pass, but this method is now stubbed out in the tests, so we can assume $? will be non-nil. --- Library/Homebrew/cmd/update.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/update.rb b/Library/Homebrew/cmd/update.rb index 96d3fdd09d..6e065b1991 100644 --- a/Library/Homebrew/cmd/update.rb +++ b/Library/Homebrew/cmd/update.rb @@ -220,8 +220,8 @@ class Updater def `(cmd) out = super - if $? && !$?.success? - $stderr.puts out + unless $?.success? + $stderr.puts(out) unless out.empty? raise ErrorDuringExecution.new(cmd) end ohai(cmd, out) if ARGV.verbose?