admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bump-formula-pr: fix duplicates check

Browse Source 
`return unless pull_requests && !pull_requests.empty?` and
`return unless pull_requests&.empty?` are not equivalent.
This commit is contained in:
ilovezfs 2017-09-25 23:01:36 -07:00
parent 6098998674
commit feda0242be
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/dev-cmd/bump-formula-pr.rb
View File

@ -89,7 +89,8 @@ module Homebrew
def check_for_duplicate_pull_requests(formula) def check_for_duplicate_pull_requests(formula)
pull_requests = fetch_pull_requests(formula) pull_requests = fetch_pull_requests(formula)
return unless pull_requests&.empty? return unless pull_requests
return if pull_requests.empty?
duplicates_message = <<-EOS.undent duplicates_message = <<-EOS.undent
These open pull requests may be duplicates: These open pull requests may be duplicates:
#{pull_requests.map { |pr| "#{pr["title"]} #{pr["html_url"]}" }.join("\n")} #{pull_requests.map { |pr| "#{pr["title"]} #{pr["html_url"]}" }.join("\n")}