admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Invoke non interactive shell from brew edit

Browse Source 
Fixes Homebrew/homebrew#12779. Closes Homebrew/homebrew#12784.

utils.rb invokes bash as a non interactive shell to run the editor
when you run brew edit.

Non-interactive shells are not intended to capture user input and for running scripts. Whilst the invocation of the editor is a script the actual editor is intended for accept user input so this is an issue with brew and not emacs.

This causes issues with emacs which has different behaviors when not running under an interactive shell.

Signed-off-by: Max Howell <mxcl@me.com>
This commit is contained in:
Dean Smith 2012-06-12 16:40:57 +01:00 committed by Max Howell
parent 0c237a8679
commit fe32e6343d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/utils.rb
View File

@ -178,7 +178,7 @@ def exec_editor *args
# Invoke bash to evaluate env vars in $EDITOR
# This also gets us proper argument quoting.
# See: https://github.com/mxcl/homebrew/issues/5123
system "bash", "-c", which_editor + ' "$@"', "--", *args
system "bash", "-i", "-c", which_editor + ' "$@"', "--", *args
end
# GZips the given paths, and returns the gzipped paths