From fe0c018a1ae0c5b8db11bdd89cf0ecda91feb407 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sun, 13 Jul 2014 10:50:56 -0500 Subject: [PATCH] No need to cache lookup that is only done once --- Library/Homebrew/extend/ENV/shared.rb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Library/Homebrew/extend/ENV/shared.rb b/Library/Homebrew/extend/ENV/shared.rb index 9225b997f6..a9fd071166 100644 --- a/Library/Homebrew/extend/ENV/shared.rb +++ b/Library/Homebrew/extend/ENV/shared.rb @@ -196,15 +196,12 @@ module SharedEnvExtension gcc_name = "gcc-#{version}" gcc_version_name = "gcc#{version.delete('.')}" - ivar = "@#{gcc_version_name}_version" - return instance_variable_get(ivar) if instance_variable_defined?(ivar) - gcc_path = HOMEBREW_PREFIX.join "opt/gcc/bin/#{gcc_name}" gcc_formula = Formulary.factory "gcc" gcc_versions_path = \ HOMEBREW_PREFIX.join "opt/#{gcc_version_name}/bin/#{gcc_name}" - formula = if gcc_path.exist? + if gcc_path.exist? gcc_formula elsif gcc_versions_path.exist? Formulary.factory gcc_version_name @@ -215,8 +212,6 @@ module SharedEnvExtension else gcc_formula end - - instance_variable_set(ivar, formula) end def warn_about_non_apple_gcc(gcc)