From fd0ba6904f68016c14d868a9e7c7391711d2bb31 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Fri, 5 Sep 2014 15:36:08 -0500 Subject: [PATCH] Less code in begin block --- Library/Homebrew/formula.rb | 74 +++++++++++++++++++------------------ 1 file changed, 38 insertions(+), 36 deletions(-) diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 3f09b14e30..9048803efb 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -510,44 +510,46 @@ class Formula mkdir_p(logd) log = File.open(logfn, "w") - log.puts Time.now, "", cmd, args, "" - log.flush - - if verbose - rd, wr = IO.pipe - begin - pid = fork do - rd.close - log.close - exec_cmd(cmd, args, wr, logfn) - end - wr.close - - while buf = rd.gets - log.puts buf - puts buf - end - ensure - rd.close unless rd.closed? - end - else - pid = fork { exec_cmd(cmd, args, log, logfn) } - end - - Process.wait(pid) - - $stdout.flush - - unless $?.success? + begin + log.puts Time.now, "", cmd, args, "" log.flush - Kernel.system "/usr/bin/tail", "-n", "5", logfn unless verbose - log.puts - require 'cmd/config' - Homebrew.dump_build_config(log) - raise BuildError.new(self, cmd, args) + + if verbose + rd, wr = IO.pipe + begin + pid = fork do + rd.close + log.close + exec_cmd(cmd, args, wr, logfn) + end + wr.close + + while buf = rd.gets + log.puts buf + puts buf + end + ensure + rd.close unless rd.closed? + end + else + pid = fork { exec_cmd(cmd, args, log, logfn) } + end + + Process.wait(pid) + + $stdout.flush + + unless $?.success? + log.flush + Kernel.system "/usr/bin/tail", "-n", "5", logfn unless verbose + log.puts + require 'cmd/config' + Homebrew.dump_build_config(log) + raise BuildError.new(self, cmd, args) + end + ensure + log.close unless log.closed? end - ensure - log.close if log && !log.closed? end private