From fb5ddde5ade4c5bec23de41769b5fdced416f8d0 Mon Sep 17 00:00:00 2001 From: thibhero Date: Wed, 11 Jun 2025 22:36:57 -0400 Subject: [PATCH] resolving discussions --- Library/Homebrew/test/cmd/install_spec.rb | 4 ++-- Library/Homebrew/test/cmd/upgrade_spec.rb | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Library/Homebrew/test/cmd/install_spec.rb b/Library/Homebrew/test/cmd/install_spec.rb index 917633db1e..ebc4afd61c 100644 --- a/Library/Homebrew/test/cmd/install_spec.rb +++ b/Library/Homebrew/test/cmd/install_spec.rb @@ -103,7 +103,7 @@ RSpec.describe Homebrew::Cmd::InstallCmd do setup_test_formula "testball1", <<~RUBY depends_on "testball5" - #depends_on "testball-build" => :build + #depends_on "build" => :build depends_on "installed" RUBY setup_test_formula "installed" @@ -112,7 +112,7 @@ RSpec.describe Homebrew::Cmd::InstallCmd do RUBY setup_test_formula "testball4", "" setup_test_formula "hiop" - setup_test_formula "testball-build", "" + setup_test_formula "build", "" # Mock `Formula#any_version_installed?` by creating the tab in a plausible keg directory keg_dir = HOMEBREW_CELLAR/"installed"/"1.0" diff --git a/Library/Homebrew/test/cmd/upgrade_spec.rb b/Library/Homebrew/test/cmd/upgrade_spec.rb index a0b57c0e74..0913af485d 100644 --- a/Library/Homebrew/test/cmd/upgrade_spec.rb +++ b/Library/Homebrew/test/cmd/upgrade_spec.rb @@ -32,8 +32,7 @@ RSpec.describe Homebrew::Cmd::UpgradeCmd do it "upgrades dependencies with asking for user prompts", :integration_test do setup_test_formula "testball", <<~RUBY depends_on "testball5" - # should work as its not building but test doesnt pass if dependant - #depends_on "testball-build" => :build + #depends_on "build" => :build depends_on "installed" RUBY setup_test_formula "installed" @@ -42,7 +41,7 @@ RSpec.describe Homebrew::Cmd::UpgradeCmd do RUBY setup_test_formula "testball4" setup_test_formula "hiop" - setup_test_formula "testball-build" + setup_test_formula "build" (HOMEBREW_CELLAR/"testball/0.0.1/foo").mkpath (HOMEBREW_CELLAR/"testball5/0.0.1/foo").mkpath @@ -88,7 +87,6 @@ RSpec.describe Homebrew::Cmd::UpgradeCmd do content = <<~RUBY depends_on "testball5" - # should work as its not building but test doesnt pass if dependant depends_on "testball-build" => :build depends_on "installed" version "0.1"