admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #13750 from carlocab/gcc-dependency-check

Browse Source 
formula_auditor: refactor GCC dependency check into separate method
This commit is contained in:
Carlo Cabrera 2022-08-25 21:41:05 +08:00 committed by GitHub
commit fb2b21b298
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
Library/Homebrew/formula_auditor.rb
View File

@ -332,13 +332,6 @@ module Homebrew
end end
return unless @core_tap return unless @core_tap
bad_gcc_dep = linux_only_gcc_dep?(formula) && (@strict || begin
fv = FormulaVersions.new(formula)
fv.formula_at_revision("origin/HEAD") { |prev_f| !linux_only_gcc_dep?(prev_f) }
end)
problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC." if bad_gcc_dep
return if formula.tap&.audit_exception :versioned_dependencies_conflicts_allowlist, formula.name return if formula.tap&.audit_exception :versioned_dependencies_conflicts_allowlist, formula.name
# The number of conflicts on Linux is absurd. # The number of conflicts on Linux is absurd.
@ -412,6 +405,22 @@ module Homebrew
end end
end end
def audit_gcc_dependency
return unless @git
return unless @core_tap
return if !@strict && !formula.tap.git? # git log is required for non-strict audit
return unless Homebrew::SimulateSystem.simulating_or_running_on_linux?
return unless linux_only_gcc_dep?(formula)
bad_gcc_dep = @strict || begin
fv = FormulaVersions.new(formula)
fv.formula_at_revision("origin/HEAD") { |prev_f| !linux_only_gcc_dep?(prev_f) }
end
return unless bad_gcc_dep
problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC."
end
def audit_postgresql def audit_postgresql
return unless formula.name == "postgresql" return unless formula.name == "postgresql"
return unless @core_tap return unless @core_tap
@ -862,14 +871,27 @@ module Homebrew
end end
def linux_only_gcc_dep?(formula) def linux_only_gcc_dep?(formula)
# TODO: Make this check work when running on Linux and not simulating macOS too. odie "`#linux_only_gcc_dep?` works only on Linux!" if Homebrew::SimulateSystem.simulating_or_running_on_macos?
return false unless Homebrew::SimulateSystem.simulating_or_running_on_macos? return false if formula.deps.map(&:name).exclude?("gcc")
formula_hash = formula.to_hash_with_variations variations = formula.to_hash_with_variations["variations"]
deps = formula_hash["dependencies"] # The formula has no variations, so all OS-version-arch triples depend on GCC.
linux_deps = formula_hash.dig("variations", :x86_64_linux, "dependencies") return false if variations.blank?
deps.exclude?("gcc") && linux_deps&.include?("gcc") MacOSVersions::SYMBOLS.each_key do |macos_version|
[:arm, :intel].each do |arch|
bottle_tag = Utils::Bottles::Tag.new(system: macos_version, arch: arch)
next unless bottle_tag.valid_combination?
variation = variations[bottle_tag.to_sym]
# This variation does not exist, so it must match Linux.
return false if variation.blank?
# We found a non-Linux variation that depends on GCC.
return false if variation["dependencies"]&.include?("gcc")
end
end
true
end end
end end
end end