From f9fe5b6798d9fb4acbbe2779ab745a33d745108f Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 7 Sep 2016 11:40:25 +0100 Subject: [PATCH] test-bot: handle missing tap in exception. Handle the case where a `FormulaUnavailableError` does not contain a tap reference so fall back to `CoreTap` in this case. --- Library/Homebrew/dev-cmd/test-bot.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/dev-cmd/test-bot.rb b/Library/Homebrew/dev-cmd/test-bot.rb index bf332ac256..dc176f52e0 100644 --- a/Library/Homebrew/dev-cmd/test-bot.rb +++ b/Library/Homebrew/dev-cmd/test-bot.rb @@ -248,8 +248,9 @@ module Homebrew def safe_formula_canonical_name(formula_name) Formulary.factory(formula_name).full_name rescue TapFormulaUnavailableError, FormulaUnavailableError => e - raise if e.tap.installed? - test "brew", "tap", e.tap.name + exception_tap = e.tap || CoreTap.instance + raise if exception_tap.installed? + test "brew", "tap", exception_tap.name retry unless steps.last.failed? onoe e puts e.backtrace