From f9b6407110d7fb98a65b470d166fc5b7be6052ee Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sat, 30 Dec 2017 19:15:52 +0000 Subject: [PATCH] lines_cop: deprecate 'needs :openmp'. --- Library/Homebrew/rubocops/lines_cop.rb | 4 ++++ Library/Homebrew/test/rubocops/lines_cop_spec.rb | 11 +++++++++++ 2 files changed, 15 insertions(+) diff --git a/Library/Homebrew/rubocops/lines_cop.rb b/Library/Homebrew/rubocops/lines_cop.rb index fdeb165ed5..4e7aa1adb2 100644 --- a/Library/Homebrew/rubocops/lines_cop.rb +++ b/Library/Homebrew/rubocops/lines_cop.rb @@ -276,6 +276,10 @@ module RuboCop problem "'fails_with :llvm' is now a no-op so should be removed" end + find_method_with_args(body_node, :needs, :openmp) do + problem "'needs :openmp' should be replaced with 'depends_on \"gcc\"'" + end + find_method_with_args(body_node, :system, /^(otool|install_name_tool|lipo)/) do next if @formula_name == "cctools" problem "Use ruby-macho instead of calling #{@offensive_node.source}" diff --git a/Library/Homebrew/test/rubocops/lines_cop_spec.rb b/Library/Homebrew/test/rubocops/lines_cop_spec.rb index ee1de059c9..19492c252b 100644 --- a/Library/Homebrew/test/rubocops/lines_cop_spec.rb +++ b/Library/Homebrew/test/rubocops/lines_cop_spec.rb @@ -731,6 +731,17 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do RUBY end + it "deprecated needs :openmp usage" do + expect_offense(<<~RUBY) + class Foo < Formula + desc "foo" + url 'http://example.com/foo-1.0.tgz' + needs :openmp + ^^^^^^^^^^^^^ 'needs :openmp' should be replaced with 'depends_on \"gcc\"' + end + RUBY + end + it "deprecated MACOS_VERSION const usage" do expect_offense(<<~RUBY) class Foo < Formula