diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index e3fb3a5809..a5f7fb8fb3 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -949,7 +949,7 @@ class ResourceAuditor problem http_content_problem end elsif strategy <= GitDownloadStrategy - unless Utils.git_remote_exists url + unless Utils.git_remote_exists? url problem "The URL #{url} is not a valid git URL" end elsif strategy <= SubversionDownloadStrategy diff --git a/Library/Homebrew/test/utils/git_spec.rb b/Library/Homebrew/test/utils/git_spec.rb index 48fc1338e6..7184400148 100644 --- a/Library/Homebrew/test/utils/git_spec.rb +++ b/Library/Homebrew/test/utils/git_spec.rb @@ -121,10 +121,10 @@ describe Utils do end end - describe "::git_remote_exists" do + describe "::git_remote_exists?" do it "returns true when git is not available" do stub_const("HOMEBREW_SHIMS_PATH", HOMEBREW_PREFIX/"bin/shim") - expect(described_class.git_remote_exists("blah")).to be_truthy + expect(described_class.git_remote_exists?("blah")).to be_truthy end context "when git is available" do @@ -139,11 +139,11 @@ describe Utils do system git, "remote", "add", "origin", url end - expect(described_class.git_remote_exists(url)).to be_truthy + expect(described_class.git_remote_exists?(url)).to be_truthy end it "returns false when git remote does not exist" do - expect(described_class.git_remote_exists("blah")).to be_falsey + expect(described_class.git_remote_exists?("blah")).to be_falsey end end end diff --git a/Library/Homebrew/utils/git.rb b/Library/Homebrew/utils/git.rb index af0eea92ab..7846389c8a 100644 --- a/Library/Homebrew/utils/git.rb +++ b/Library/Homebrew/utils/git.rb @@ -67,7 +67,7 @@ module Utils @git_version = nil end - def self.git_remote_exists(url) + def self.git_remote_exists?(url) return true unless git_available? quiet_system "git", "ls-remote", url end