admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocop: remove BINARY_URLS_WHITELIST and rust nightly

Browse Source 
This url is not used anymore, we replaced it with a new stable version
of rust.
This commit is contained in:
Michka Popoff 2020-02-01 13:17:14 +01:00
parent d83afb1c0a
commit f96342713b
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/rubocops/urls.rb
View File

@ -24,12 +24,6 @@ module RuboCop
rust rust
].freeze ].freeze
# specific rust-nightly temporarily acceptable until a newer version is released.
# DO NOT RE-ADD A NEWER RUST-NIGHTLY IN FUTURE.
BINARY_URLS_WHITELIST = %w[
https://static.rust-lang.org/dist/2019-08-24/rust-nightly-x86_64-apple-darwin.tar.xz
].freeze
def audit_formula(_node, _class_node, _parent_class_node, body_node) def audit_formula(_node, _class_node, _parent_class_node, body_node)
urls = find_every_func_call_by_name(body_node, :url) urls = find_every_func_call_by_name(body_node, :url)
mirrors = find_every_func_call_by_name(body_node, :mirror) mirrors = find_every_func_call_by_name(body_node, :mirror)
@ -232,7 +226,6 @@ module RuboCop
audit_urls(urls, /(darwin|macos|osx)/i) do |_, url| audit_urls(urls, /(darwin|macos|osx)/i) do |_, url|
next if url !~ /x86_64/i && url !~ /amd64/i next if url !~ /x86_64/i && url !~ /amd64/i
next if BINARY_FORMULA_URLS_WHITELIST.include?(@formula_name) next if BINARY_FORMULA_URLS_WHITELIST.include?(@formula_name)
next if BINARY_URLS_WHITELIST.include?(url)
problem "#{url} looks like a binary package, not a source archive; " \ problem "#{url} looks like a binary package, not a source archive; " \
"homebrew/core is source-only." "homebrew/core is source-only."