admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/urls: In regexps, only allow valid hostname characters

Browse Source 
> This regular expression has an unrestricted wildcard '.*' which may cause 'googlecode\.com/files' to be matched anywhere in the URL, outside the hostname.
This commit is contained in:
Issy Long 2022-04-15 16:36:58 +01:00
parent aa36b343ca
commit f8d9a5c2db
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/urls.rb
View File

@ -177,7 +177,7 @@ module RuboCop
end end
# Check for new-url Google Code download URLs, https:// is preferred # Check for new-url Google Code download URLs, https:// is preferred
google_code_pattern = Regexp.union([%r{^http://.*\.googlecode\.com/files.*}, google_code_pattern = Regexp.union([%r{^http://[A-Za-z0-9\-.]*\.googlecode\.com/files.*},
%r{^http://code\.google\.com/}]) %r{^http://code\.google\.com/}])
audit_urls(urls, google_code_pattern) do |_, url| audit_urls(urls, google_code_pattern) do |_, url|
problem "Please use https:// for #{url}" problem "Please use https:// for #{url}"