From f85863cbd0f5cc105908273dbeca532d24893823 Mon Sep 17 00:00:00 2001 From: Adam Vandenberg Date: Sun, 23 Jun 2013 12:48:45 -0700 Subject: [PATCH] Clean the cleaner * Fix a comment; we pass in formulae not names * Don't pass the formula to factory; this is just a pass-through * Move require to top-level --- Library/Homebrew/cleaner.rb | 4 ++-- Library/Homebrew/formula_installer.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/cleaner.rb b/Library/Homebrew/cleaner.rb index 8d89b7698d..f58f7c8c17 100644 --- a/Library/Homebrew/cleaner.rb +++ b/Library/Homebrew/cleaner.rb @@ -6,9 +6,9 @@ # * sets permissions on executables class Cleaner - # Create a cleaner for the given formula name, and clean the keg + # Create a cleaner for the given formula and clean its keg def initialize f - @f = Formula.factory f + @f = f [f.bin, f.sbin, f.lib].select{ |d| d.exist? }.each{ |d| clean_dir d } if ENV['HOMEBREW_KEEP_INFO'] diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 9d6fa08488..2aec26befe 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -6,6 +6,7 @@ require 'keg' require 'tab' require 'bottles' require 'caveats' +require 'cleaner' class FormulaInstaller attr_reader :f @@ -409,7 +410,6 @@ class FormulaInstaller puts "in the formula." return end - require 'cleaner' Cleaner.new f rescue Exception => e opoo "The cleaning step did not complete successfully"